From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>, Joe Damato <joe@dama.to>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 1/9] net: tso: add tso_features_check()
Date: Fri, 3 Apr 2026 13:47:32 -0700 [thread overview]
Message-ID: <20260403134732.26e39509@kernel.org> (raw)
In-Reply-To: <CANn89iLUN1F-NzdCpaPhZBFVZR6KjEuyPNhNXtWr6Hu4BFdyMw@mail.gmail.com>
On Fri, 3 Apr 2026 00:20:13 -0700 Eric Dumazet wrote:
> > I forgot that netif_skb_features() uses:
> >
> > if (dev->netdev_ops->ndo_features_check)
> > features &= dev->netdev_ops->ndo_features_check(skb, dev,
> > features);
> > else
> > features &= dflt_features_check(skb, dev, features);
> >
> > So I need to call vlan_features_check() from tso_features_check()
>
> I could be wrong though, vlan_features_check() is about skbs with
> multiple vlan tags,
> and net/core/tso.c should support them just fine.
But we probably still need to clear NETIF_F_IP_CSUM for example?
Better safe than sorry. (I won't repeat the sashiko complaints
assuming you saw those ;))
next prev parent reply other threads:[~2026-04-03 20:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 4:32 [PATCH net-next 0/9] net: safe guard net/core/tso.c users Eric Dumazet
2026-04-03 4:32 ` [PATCH net-next 1/9] net: tso: add tso_features_check() Eric Dumazet
2026-04-03 6:41 ` Eric Dumazet
2026-04-03 7:20 ` Eric Dumazet
2026-04-03 20:47 ` Jakub Kicinski [this message]
2026-04-03 20:49 ` Eric Dumazet
2026-04-03 21:00 ` Eric Dumazet
2026-04-03 4:32 ` [PATCH net-next 2/9] net: mvneta: use tso_features_check() Eric Dumazet
2026-04-03 4:32 ` [PATCH net-next 3/9] net: thunderx: " Eric Dumazet
2026-04-03 4:32 ` [PATCH net-next 4/9] dpaa2-eth: " Eric Dumazet
2026-04-03 4:32 ` [PATCH net-next 5/9] net: enetc: " Eric Dumazet
2026-04-03 4:32 ` [PATCH net-next 6/9] net: fec: " Eric Dumazet
2026-04-03 4:32 ` [PATCH net-next 7/9] net: mv643xx_eth: " Eric Dumazet
2026-04-03 4:32 ` [PATCH net-next 8/9] net: mvpp2: " Eric Dumazet
2026-04-03 4:32 ` [PATCH net-next 9/9] octeontx2-pf: " Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403134732.26e39509@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox