From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B38213C3C14; Fri, 3 Apr 2026 16:02:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775232173; cv=none; b=Hv1ga3Zx48zDyAJF+KL62/9J1zjZpUDkN+Pq1xErRVnyg++hYirYpIHJBf/3mSQTo26KMMUkZEMlsTMMAuiqxE4hKnMaYBbGwL+tVrsdutUrL/cUatx6Jq67cCOggK81tBU6N4hYOF/wsUqPLTUINni8KYZEOkroE6ZUDXnX980= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775232173; c=relaxed/simple; bh=BNPbGQtpMtb7EJLXPZZidRn5FnuViXRDcfBMEOcMpoM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A9WL63W7x+xbJ6wQzy2KlPkwloWXpI/OVqE9D02oC3fuBB2hU/eBXPRvYyLr5h0VicKwFj4/eYsgIX7tko1KdFYB/Nqk3Mv+6c28PdWgr1w5wRh97SY0AjOU23CiD66HF7hf8VJ6Nla/1cvCcy0WGGjnpOtVELzYh1EGIHlvCRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h+T2BHhW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h+T2BHhW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DE9AC4CEF7; Fri, 3 Apr 2026 16:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775232173; bh=BNPbGQtpMtb7EJLXPZZidRn5FnuViXRDcfBMEOcMpoM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h+T2BHhW+QNMdiKBVw4bPtbVkFy0PePJKkJXdRp6yu2l4mvddNz380uIuM/oK/wDe pKAKNLZ9I0IWO+BLyDnNSQAC3nJbK0SthBdWGVvhCjAu6HJkyAwvdohNPnzxCP3Xxm 1Ur9EEdoIWyVV6CHt2Xi4xLAfpjR/YVfgxs/CRlAVNFNAk/JTmaX5V+Ig0bQG6eumo A6Y5Qwt4P8A2a4Bu+zkHEJHpNyElmTqfSPAjRRRMaX/tYEwGWIaOWvl6K+IZ5Fvt2Z AwfigUc8ltso8I5SJmTVFxOtC/GZEsAmkD9iS9dhNVHeBS/L2RZlrvmnioLOvWEtdE Hh0zd3XHG5bzQ== Date: Fri, 3 Apr 2026 17:02:48 +0100 From: Simon Horman To: Arnd Bergmann Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: fec: make FIXED_PHY dependency unconditional Message-ID: <20260403160248.GN113102@horms.kernel.org> References: <20260402141048.2713445-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260402141048.2713445-1-arnd@kernel.org> On Thu, Apr 02, 2026 at 04:10:40PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_FIXED_PHY is in a loadable module, the fec driver cannot be > built-in any more: > > x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe': > fec_main.c:(.text+0xc4f367): undefined reference to `fixed_phy_unregister' > x86_64-linux-ld: vmlinux.o: in function `fec_enet_close': > fec_main.c:(.text+0xc59591): undefined reference to `fixed_phy_unregister' > x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe.cold': > > Select the fixed phy support on all targets to make this build > correctly, not just on coldfire. > > Notat that Essentially the stub helpers in include/linux/phy_fixed.h > cannot be used correctly because of this build time dependency, > and we could just remove them to hit the build failure more often > when a driver uses them without the 'select FIXED_PHY'. > > Fixes: dc86b621e1b4 ("net: fec: register a fixed phy using fixed_phy_register_100fd if needed") > Signed-off-by: Arnd Bergmann > --- > I sent the same fix for B44 earlier, see commit 3f0f591b44b0 ("net: b44: > always select CONFIG_FIXED_PHY"). I checked that there are no other > conditional users of FIXED_PHY this time. Reviewed-by: Simon Horman