From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DD902BEC41 for ; Fri, 3 Apr 2026 16:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775233031; cv=none; b=qtrg55QAcQuKcKrBr3RTYS4koLqQmR46gLdYTYJmCI4bWyVk9+qpAHpsaOIfiRSnxNQBouP72Y8rTekindWBGdiD/dOU1NpE/hO29OcKIxMQkiJUep/hBNw0SFrCxbw6FJihSzm3ypcNp71UFynIvMILY+O2eDL8h1KxIDdA8Ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775233031; c=relaxed/simple; bh=dszPWaFvEEgSfOdk090ISCqiTWOzjpJpNLJrnyM2IEI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MVoFt+l7XaAuVQjUJTSS3AsBZrxnLYrISEdpznz66L21FHMT4w7hYBusp0V17l9+qB8uYhY7w+FTbtE6bCGe//NFZ/oNyCsV+gD++XmFbY7qls7sRtr0q3OIFC/Q+lhb13XIat1PHFqRTA7OWej4YJQjs4YTX9XbSNad0nUW8qw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CMdFZk3Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CMdFZk3Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7670C4CEF7; Fri, 3 Apr 2026 16:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775233031; bh=dszPWaFvEEgSfOdk090ISCqiTWOzjpJpNLJrnyM2IEI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CMdFZk3ZJa7s9RipUHciL5wrHDEiW5PMEiWI1TBXhbZ1yrPTqKP2RIGXbQsI9FFyA qlNxjTbUhJiPo8d8gLqDyL8sxUnTHHSw9JEYnDZLA0htge0fzHG9SZDkVvVSyY4Q7H 78PvXLsaItg0GhVQXXsKwe2+8V8YPJL55fcy5+TjGeINGx+6UsGE6CsZAiy9bJKUQy X/nlq15rT2u1TQbP0RhO+xZZhgUG9KYx4dIejCvRHMvGSCe0YMTERJCSYHJg9VI5u5 009WgklRQvU9wn7yyV9cRkGGmhPikQ8dECkBwdMPTx7Q2vKadNZIsAV2Lwm21gF8Ra O9VC2Pi3LRT7g== Date: Fri, 3 Apr 2026 17:17:07 +0100 From: Simon Horman To: Kevin Hao Cc: Nicolas Ferre , Claudiu Beznea , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/4] net: macb: Remove dedicated IRQ handler for WoL Message-ID: <20260403161707.GO113102@horms.kernel.org> References: <20260328-macb-irq-v1-0-7b3e622fb46c@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260328-macb-irq-v1-0-7b3e622fb46c@gmail.com> On Sat, Mar 28, 2026 at 06:17:44PM +0800, Kevin Hao wrote: > During debugging of a suspend/resume issue, I observed that the macb driver > employs a dedicated IRQ handler for Wake-on-LAN (WoL) support. To my knowledge, > no other Ethernet driver adopts this approach. This implementation unnecessarily > complicates the suspend/resume process without providing any clear benefit. > Instead, we can easily modify the existing IRQ handler to manage WoL events, > avoiding any overhead in the TX/RX hot path. > > I am skeptical that the minor optimizations to the IRQ handler proposed in this > patch series would yield any measurable performance improvement. However, it > does appear that the execution time of the macb_interrupt() function is > slightly reduced. > > The following data(net throughput and execution time of macb_interrupt) were > collected from my AMD Zynqmp board using the commands: > taskset -c 1,2,3 iperf3 -c 192.168.3.4 -t 60 -Z -P 3 -R > cat /sys/kernel/debug/tracing/trace_stat/function0 ... For the series: Reviewed-by: Simon Horman