From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] net: always inline some skb helpers
Date: Fri, 3 Apr 2026 17:31:52 +0100 [thread overview]
Message-ID: <20260403163152.GQ113102@horms.kernel.org> (raw)
In-Reply-To: <20260402152654.1720627-1-edumazet@google.com>
On Thu, Apr 02, 2026 at 03:26:54PM +0000, Eric Dumazet wrote:
> Some performance critical helpers from include/linux/skbuff.h
> are not inlined by clang.
>
> Use __always_inline hint for:
>
> - __skb_fill_netmem_desc()
> - __skb_fill_page_desc()
> - skb_fill_netmem_desc()
> - skb_fill_page_desc()
> - __skb_pull()
> - pskb_may_pull_reason()
> - pskb_may_pull()
> - pskb_pull()
> - pskb_trim()
> - skb_orphan()
> - skb_postpull_rcsum()
> - skb_header_pointer()
> - skb_clear_delivery_time()
> - skb_tstamp_cond()
> - skb_warn_if_lro()
>
> This increases performance and saves ~1200 bytes of text.
>
> $ scripts/bloat-o-meter -t vmlinux.old vmlinux.new
> add/remove: 4/24 grow/shrink: 66/12 up/down: 4104/-5306 (-1202)
...
> Total: Before=29652698, After=29651496, chg -0.00%
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2026-04-03 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 15:26 [PATCH net-next] net: always inline some skb helpers Eric Dumazet
2026-04-03 16:31 ` Simon Horman [this message]
2026-04-03 23:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403163152.GQ113102@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox