From: Simon Horman <horms@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v3 1/7] net/sched: netem: fix probability gaps in 4-state loss model
Date: Sat, 4 Apr 2026 10:50:00 +0100 [thread overview]
Message-ID: <20260404095000.GV113102@horms.kernel.org> (raw)
In-Reply-To: <20260402202037.176299-2-stephen@networkplumber.org>
On Thu, Apr 02, 2026 at 01:19:29PM -0700, Stephen Hemminger wrote:
> The 4-state Markov chain in loss_4state() has gaps at the boundaries
> between transition probability ranges. The comparisons use:
>
> if (rnd < a4)
> else if (a4 < rnd && rnd < a1 + a4)
>
> When rnd equals a boundary value exactly, neither branch matches and
> no state transition occurs. The redundant lower-bound check (a4 < rnd)
> is already implied by being in the else branch.
>
> Remove the unnecessary lower-bound comparisons so the ranges are
> contiguous and every random value produces a transition, matching
> the GI (General and Intuitive) loss model specification.
>
> This bug goes back to original implementation of this model.
>
> Fixes: 661b79725fea ("netem: revised correlated loss generator")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-04-04 9:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 20:19 [PATCH net v3 0/7] net/sched: netem: bug fixes Stephen Hemminger
2026-04-02 20:19 ` [PATCH net v3 1/7] net/sched: netem: fix probability gaps in 4-state loss model Stephen Hemminger
2026-04-04 9:50 ` Simon Horman [this message]
2026-04-02 20:19 ` [PATCH net v3 2/7] net/sched: netem: fix queue limit check to include reordered packets Stephen Hemminger
2026-04-04 9:50 ` Simon Horman
2026-04-02 20:19 ` [PATCH net v3 3/7] net/sched: netem: only reseed PRNG when seed is explicitly provided Stephen Hemminger
2026-04-04 9:50 ` Simon Horman
2026-04-02 20:19 ` [PATCH net v3 4/7] net/sched: netem: restructure dequeue to avoid re-entrancy with child qdisc Stephen Hemminger
2026-04-04 9:49 ` Simon Horman
2026-04-06 15:41 ` Jakub Kicinski
2026-04-06 17:12 ` Stephen Hemminger
2026-04-02 20:19 ` [PATCH net v3 5/7] net/sched: netem: null-terminate tfifo linear queue tail Stephen Hemminger
2026-04-04 9:50 ` Simon Horman
2026-04-02 20:19 ` [PATCH net v3 6/7] net/sched: netem: check for invalid slot range Stephen Hemminger
2026-04-04 9:51 ` Simon Horman
2026-04-02 20:19 ` [PATCH net v3 7/7] net/sched: netem: fix slot delay calculation overflow Stephen Hemminger
2026-04-04 9:51 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260404095000.GV113102@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox