From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628533A961E; Sat, 4 Apr 2026 09:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775296257; cv=none; b=JAho7C2TP6isu+nsZtoyCwBjPNPEwO39GYMgh6gQrs1kB0CmK4ej/wShfNKdtMf5CXP2nYAiKICiOBPBvm7oChSqrKMZ3tLV8/IG2SGWqJtDIiYmJ/0xfXDIEirHVPThqTd5WNLo6LJUBbML6YhL6M0cMDae72UrMVP2oRUcLFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775296257; c=relaxed/simple; bh=0SJtuqC39KmtSUyzWuWOAf4tJ3L7EgcDLpoqKFEXrA4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lZWi2RA5/trcB2R0vM1kE08er6CToSY4jhpVBQdQUH80qIpAPYsN0aGq/oA7lzqu/sesMPaXCKZxyj7nZrIhmCgWpcoJOeZVs04YMtAcwEweMU2VcHrVKAWbSitwNhXLCU1jwjZeKDgOAGqfI9Rm2rUAEUcCgcHtKvBeTXYmY4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SjNSRcGt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SjNSRcGt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17ED6C19421; Sat, 4 Apr 2026 09:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775296257; bh=0SJtuqC39KmtSUyzWuWOAf4tJ3L7EgcDLpoqKFEXrA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SjNSRcGtho/CUbRtovxR7IFPS9yxMDD9USMLDMRohHW2BEf8kZF3ZE3w9Kahz5Smd 98x21CqJfsdfTR+IPZnZTBBRotTymNpvBu/yIUlvdui99PcPMUOY2EAPqzHhc7qPT0 zeX8KoLTfQ0GlEpkzcfur4QgsFIYJpunD68oVaz2JaAiyEPiJ1IKfZOx6aeJpZ7CCr 8/7IHrRH+pRqSsRWRU/DGYuL9e6lhHIk64zb5l3ALDnKvT/Md34f8/pCCThjZ+/7DO 5RWo2uoekm262uGdgnf2zMQUskIQv7awuvJL7vfhTvnuFXgBND6NFJtNzS9IJK/ReH Pv5van8ipZ/Zg== Date: Sat, 4 Apr 2026 10:50:52 +0100 From: Simon Horman To: Stephen Hemminger Cc: netdev@vger.kernel.org, Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peter Oskolkov , open list Subject: Re: [PATCH net v3 5/7] net/sched: netem: null-terminate tfifo linear queue tail Message-ID: <20260404095052.GY113102@horms.kernel.org> References: <20260402202037.176299-1-stephen@networkplumber.org> <20260402202037.176299-6-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260402202037.176299-6-stephen@networkplumber.org> On Thu, Apr 02, 2026 at 01:19:33PM -0700, Stephen Hemminger wrote: > When tfifo_enqueue() appends a packet to the linear queue tail, > nskb->next is never set to NULL. The list terminates correctly > only by accident if the skb arrived with next already NULL. > > Explicitly null-terminate the tail to prevent list corruption. > > Fixes: d66280b12bd7 ("net: netem: use a list in addition to rbtree") > Signed-off-by: Stephen Hemminger Reviewed-by: Simon Horman