From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8E27368277 for ; Sun, 5 Apr 2026 05:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775368368; cv=none; b=ltHsXF77j7rsXvSljI0GoGNIXziZ+BdZP4kw43wfWDrDs/BQtBNyQbDtEfifQOn78nczz/nJbNEB+a2yYzh1ytITolKUXgcxNK6flV9zNjCKaZHUuxytpbLwog4hiLWEKNaOXwGH7IgIoVGn1tDP2RJZKWp0c9kfZXz0wJpGpOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775368368; c=relaxed/simple; bh=0tTTbC/ebQuK84WVTeLENCfRkHSaH8uFUAbuP1W5FdY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z4PHX9tqcq1m/rX+IYPRQ5qh9pIAeWMeFmH/c3EXRKGaMiPg6g9m2j3axzAsMO4qa/8yWy8pBY1/tey3fL8rknP8AY+aSU/pUu0hYLpLZgdAT1cesDNIum0xclxzKedwDi+2fypC0IgL5+CcBOsgI/icIqVPfWQIDLfQAnQlB8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GZ/KsOGd; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GZ/KsOGd" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so30316985e9.1 for ; Sat, 04 Apr 2026 22:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775368366; x=1775973166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e7nMVD+VOcNWUuhtqvwltUnQm85Jrmb6cAMzCcy5HCI=; b=GZ/KsOGd41hD4c3HUTOhAwJATP8z7SYWev84NsPtekiKicIwETvw4yv3KjqijLEH5t MTH6+iViXXozluCaWxBqF/H0Iimx0EDH7S9wSYFvvDNJ9zWBduxkKOq4+KaE42IZsNTN wiU7aMAQDQB+KUIaAFljXeX1fnX4PHnsyZcQ/9IUE2br5gtidcNJkQiQxuahDTEavybS cGU5jW+CHi8mfcVpfT5WxaGZyVO787I6T8QOqCRWkcrMIUIGQ3qFD3vUo1bcklNNRhNY wWdv6ukY+0XJxgyglEpY/6X4oiBnFGpOq6nQCtzoVNzJT+nJjYaY3wiv9Smc593xVcQk qGMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775368366; x=1775973166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e7nMVD+VOcNWUuhtqvwltUnQm85Jrmb6cAMzCcy5HCI=; b=M6CoX9W8BL5bAEQsKLfTazBPQavF+FN3sD73+l1BN6hJhf6ocYRxp3KbDcIRlgG3Vm JCnex8dAR+CeQAsV296OkZn6CoqxdFzEY0FGYG5Y3kLxJOQvf8kmAucKN+qNPJdTyQ/B Uo5YydTjfC1mVKmA14LkJhAOpy5AOnb2xvQTgNJozk/k230i1ec+NGK649jvs77fqb4X 00hy+oATObYAelIWPXKHDLWPO7e/OYu0Y2r36hYUgaFaGR1A/+SgbAaMN16zmmEQft0I 7sqeXLPm5kdrCZWbyvFxYm8VVZ3920cN2CDSgg464LFwBGQFBzyOJbq1ualHj9qDzqY4 +kqg== X-Forwarded-Encrypted: i=1; AJvYcCVYUgNiQsUJuurVt7VIwIo1u7U5zKGa2dgYyH4Uz4gexbKzOQXF2gQkLJxnFMBOE9231ovs3ag=@vger.kernel.org X-Gm-Message-State: AOJu0Yzmhs5lXcIsRj0pVNBBR2fUBaH8E+/Bf4P5ZApgy8yqMxLBFyJ4 o++lE10cMSWj7fALKa+utbjSPEsFXleU0cN9iKYYYFTCY6ecaCmWyT1i X-Gm-Gg: AeBDiesIkBxukehM4zWbDPZau7B5WUSvhRL5S03eZN2pwyh6h9sFieqXcbITHkTUOk3 R34ESiabetRhbT68oRX6P2OZoJHW5rLGLMDDt1A9lk8PeppGFFrmdyGEPrN6b/6Pl4QQipRKMLR tcWOMeBA+YogBDcbW/g/cJIwF2kBf/35MVzG6m+7JePyEg7mzNoDSXXZjLJIsFU9c3iNFBNHqb0 JuoPY0jllrd8+prDKTzG0LEs0O9WF2QhpZl1sWNMxOOk9RFILLuDsiJfdat9wPDXZIR2kwNQ6W0 emd20iEzO2a68TcqQ099no7oycFNC6ZNBuXPSnyA+lo45u/uW53gfxibFT02movMDObqFv9p/02 DSnzXvAu7vuAvZzeJ4b2uYrcykGHa25ADIePN74Lh29z9Dj+ROAvyCqIe5IEPDtUa6lF+61DDM7 qwEc+cqi3CwwkXHFpO0iqEq+ngnj5G1uWc5h/sondkxuGl9d+bx7rUrqSnbJxXsBRXVdPS0iNZR Tbtb3BIPFdm X-Received: by 2002:a05:600c:4f87:b0:486:faa8:9e4 with SMTP id 5b1f17b1804b1-488994a77b1mr117703095e9.12.1775368366063; Sat, 04 Apr 2026 22:52:46 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48899e960a7sm55847465e9.27.2026.04.04.22.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 22:52:45 -0700 (PDT) From: David Carlier To: horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, David Carlier Subject: [PATCH net v3 v3 1/3] net: lan966x: fix page_pool error handling in lan966x_fdma_rx_alloc_page_pool() Date: Sun, 5 Apr 2026 06:52:39 +0100 Message-ID: <20260405055241.35767-2-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260405055241.35767-1-devnexen@gmail.com> References: <20260405055241.35767-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit page_pool_create() can return an ERR_PTR on failure. The return value is used unconditionally in the loop that follows, passing the error pointer through xdp_rxq_info_reg_mem_model() into page_pool_use_xdp_mem(), which dereferences it, causing a kernel oops. Add an IS_ERR check after page_pool_create() to return early on failure. Fixes: 11871aba1974 ("net: lan96x: Use page_pool API") Cc: stable@vger.kernel.org Signed-off-by: David Carlier --- drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c index 7b6369e43451..74851c63e46a 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_fdma.c @@ -91,6 +91,8 @@ static int lan966x_fdma_rx_alloc_page_pool(struct lan966x_rx *rx) pp_params.dma_dir = DMA_BIDIRECTIONAL; rx->page_pool = page_pool_create(&pp_params); + if (unlikely(IS_ERR(rx->page_pool))) + return PTR_ERR(rx->page_pool); for (int i = 0; i < lan966x->num_phys_ports; ++i) { struct lan966x_port *port; -- 2.53.0