From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tipi-net.de (mail.tipi-net.de [194.13.80.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 573B43264DF; Mon, 6 Apr 2026 08:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.13.80.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775464612; cv=none; b=bPZwh31BvjRcOTeg17p9qgYPXglmY3FRHtjsk+mZSJ7Hngm94v/u8PYYmQuaihE3znYEjB8PzEilUWOexOqs3YC9PyQ/SvNibitKiyZuWgHP2VpLnahn5aiPYVKwVZeNN816ty9TqQTVxoERheCo5ZeKas5encGlmwNpWti7Xkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775464612; c=relaxed/simple; bh=/7ZTXIeUr4zab79LXbnb5qi5sTskX8yvt3YWo1xx3I8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XS9WTS+07t9fDdmKUganEh9CG8kcp1rshOp3X0Oz5Fe2A64P4jylGF/34L2ayyZu5SG+C8UXk/eUJv38ZyTQWDPwQ1nYAPfe9m1HvNHZ3vIdW4Apk7hPTw2IYVZSs/sarCltDfKieLP4Wde3vN1tmvg0ywMRLYrnnKlQfDdNAF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tipi-net.de; spf=pass smtp.mailfrom=tipi-net.de; dkim=pass (2048-bit key) header.d=tipi-net.de header.i=@tipi-net.de header.b=skWPKw/s; arc=none smtp.client-ip=194.13.80.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tipi-net.de header.i=@tipi-net.de header.b="skWPKw/s" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8168FA58A5; Mon, 6 Apr 2026 10:36:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tipi-net.de; s=dkim; t=1775464600; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=AyLnzSNiMQns4RdSjIaZ2rVewJYi0nvzX4Kz82VqEPs=; b=skWPKw/sqKtIPoSEdGcEzzRfUJFSVyCl5v6+XmoRVUMTtHM7uTkg8WUSDyw9EqOkNXS80e tCB1+0Hd7G2o9PWOwl/oyTI0/fA+X/dVh8hAZ3m3AO0G4nyy/pkrGU/YMpXBDRPs9fWnrp hR0MkE3m+UcrbP7kKrAGC3f7YxZwVIpff1tdIKrnBrsHQoLBI7uyoiw6ra3crf56LRN474 wQV/MA+b2YrFLCAvy9lAesG/3yYGVTmno1U+rMT37yPf1KWMqSVUYiIVsL/cbp8UC1RKNG OYC0bhSVNQrDlkkS7N/XLKhvbxUDV9Tqig5c5FwrXy11SpOzEcZstz6i8TfZPQ== From: Nicolai Buchwitz To: netdev@vger.kernel.org Cc: Justin Chen , Simon Horman , Mohsin Bashir , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Eric Dumazet , Paolo Abeni , Nicolai Buchwitz , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH net-next v6 6/7] net: bcmgenet: add XDP statistics counters Date: Mon, 6 Apr 2026 10:35:30 +0200 Message-ID: <20260406083536.839517-7-nb@tipi-net.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260406083536.839517-1-nb@tipi-net.de> References: <20260406083536.839517-1-nb@tipi-net.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Expose per-action XDP counters via ethtool -S: xdp_pass, xdp_drop, xdp_tx, xdp_tx_err, xdp_redirect, and xdp_redirect_err. These use the existing soft MIB infrastructure and are incremented in bcmgenet_run_xdp() alongside the existing driver statistics. Signed-off-by: Nicolai Buchwitz --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 15 +++++++++++++++ drivers/net/ethernet/broadcom/genet/bcmgenet.h | 6 ++++++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index b725ffa9c746..7d0c9a848331 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -1170,6 +1170,13 @@ static const struct bcmgenet_stats bcmgenet_gstrings_stats[] = { STAT_GENET_SOFT_MIB("tx_realloc_tsb", mib.tx_realloc_tsb), STAT_GENET_SOFT_MIB("tx_realloc_tsb_failed", mib.tx_realloc_tsb_failed), + /* XDP counters */ + STAT_GENET_SOFT_MIB("xdp_pass", mib.xdp_pass), + STAT_GENET_SOFT_MIB("xdp_drop", mib.xdp_drop), + STAT_GENET_SOFT_MIB("xdp_tx", mib.xdp_tx), + STAT_GENET_SOFT_MIB("xdp_tx_err", mib.xdp_tx_err), + STAT_GENET_SOFT_MIB("xdp_redirect", mib.xdp_redirect), + STAT_GENET_SOFT_MIB("xdp_redirect_err", mib.xdp_redirect_err), /* Per TX queues */ STAT_GENET_Q(0), STAT_GENET_Q(1), @@ -2424,6 +2431,7 @@ static unsigned int bcmgenet_run_xdp(struct bcmgenet_rx_ring *ring, switch (act) { case XDP_PASS: + priv->mib.xdp_pass++; return XDP_PASS; case XDP_TX: /* Prepend a zeroed TSB (Transmit Status Block). The GENET @@ -2436,6 +2444,7 @@ static unsigned int bcmgenet_run_xdp(struct bcmgenet_rx_ring *ring, sizeof(struct status_64) + sizeof(struct xdp_frame)) { page_pool_put_full_page(ring->page_pool, rx_page, true); + priv->mib.xdp_tx_err++; return XDP_DROP; } xdp->data -= sizeof(struct status_64); @@ -2455,19 +2464,24 @@ static unsigned int bcmgenet_run_xdp(struct bcmgenet_rx_ring *ring, xdpf, false))) { spin_unlock(&tx_ring->lock); xdp_return_frame_rx_napi(xdpf); + priv->mib.xdp_tx_err++; return XDP_DROP; } bcmgenet_xdp_ring_doorbell(priv, tx_ring); spin_unlock(&tx_ring->lock); + priv->mib.xdp_tx++; return XDP_TX; case XDP_REDIRECT: if (unlikely(xdp_do_redirect(priv->dev, xdp, prog))) { + priv->mib.xdp_redirect_err++; page_pool_put_full_page(ring->page_pool, rx_page, true); return XDP_DROP; } + priv->mib.xdp_redirect++; return XDP_REDIRECT; case XDP_DROP: + priv->mib.xdp_drop++; page_pool_put_full_page(ring->page_pool, rx_page, true); return XDP_DROP; default: @@ -2475,6 +2489,7 @@ static unsigned int bcmgenet_run_xdp(struct bcmgenet_rx_ring *ring, fallthrough; case XDP_ABORTED: trace_xdp_exception(priv->dev, prog, act); + priv->mib.xdp_drop++; page_pool_put_full_page(ring->page_pool, rx_page, true); return XDP_ABORTED; } diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h b/drivers/net/ethernet/broadcom/genet/bcmgenet.h index 8966d32efe2f..c4e85c185702 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.h +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.h @@ -156,6 +156,12 @@ struct bcmgenet_mib_counters { u32 tx_dma_failed; u32 tx_realloc_tsb; u32 tx_realloc_tsb_failed; + u32 xdp_pass; + u32 xdp_drop; + u32 xdp_tx; + u32 xdp_tx_err; + u32 xdp_redirect; + u32 xdp_redirect_err; }; struct bcmgenet_tx_stats64 { -- 2.51.0