From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 532C42DFA4A for ; Mon, 6 Apr 2026 14:07:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775484427; cv=none; b=fx9QljOLoU+LtjGoGBUo6ZuA7P91D/71fUCPybSHLA/o44A/AxsjZAc6YOKjnK9aNyASvPTk3K5KuSN0cCLDp7TgwWFQgpOQ5S/bzIR20ZGNMZQPoZ0OqAwiguWRTP5drXnIxayvgkeb1vzswalXuO0cSTF5JO26MjQpqpRilc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775484427; c=relaxed/simple; bh=MAH6RptzeDcpL5V+g/KSRmtMJlqdvpcbYjcxWTTBuNE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qMwNSSSy15aTuO2bH/buXfQZI+sZZVot7sAnTEez0mZm61/6f4EINFded5LawJ7E7r1qF65kM5oTEe//UugdPZ9QrK2XDZtfbWa0vlY+piIuAwlZQ878dJKOAAF/Gn1THWiPaU85dlHAKlR70VPfX0EBDQBZxIxsJGFiQPb2frs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CMjTvXiF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CMjTvXiF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92EE4C4CEF7; Mon, 6 Apr 2026 14:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775484426; bh=MAH6RptzeDcpL5V+g/KSRmtMJlqdvpcbYjcxWTTBuNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CMjTvXiFqY1RT8PIZv436z/iQGl8Ay6NcjanNYH15fxJmVRsksQBoblZLQvKslbhA rITkdThslYEyw/3zQXVQDFTbSrp/8vivYgHuar5g+NzKgvU4rSRznWmFq6KC6HbGCL 5Lh+y/YJV/H8AV+B6MF3A+RPODuYrVd7axqEXyCHO2dOeqPdA4oDcP5uWIpYUxlKZm 1QnFxzuC+mIhlzBiaKClEAbhgxGUq+Jl1+u4tqecdPHP0Gg1FVFR2mRZ9yJ96WPGbS v+DnTfwNADqx483FGIvNWDb5XNdF7xGPVy5yPU0tw25owTMX7WrBPXSSEZAdxyt0e3 MvNrspYXMturg== Date: Mon, 6 Apr 2026 15:07:03 +0100 From: Simon Horman To: "Keller, Jacob E" Cc: "Loktionov, Aleksandr" , "intel-wired-lan@lists.osuosl.org" , "Nguyen, Anthony L" , "netdev@vger.kernel.org" , Marcin Szycik Subject: Re: [PATCH iwl-next] ixgbe: use ktime_get_real_ns() in ixgbe_ptp_reset() Message-ID: <20260406140703.GD395680@kernel.org> References: <20260327073046.134085-1-aleksandr.loktionov@intel.com> <20260327073046.134085-5-aleksandr.loktionov@intel.com> <20260403131035.GA113102@horms.kernel.org> <20260403131159.GA114708@horms.kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Apr 03, 2026 at 08:26:20PM +0000, Keller, Jacob E wrote: > > > > -----Original Message----- > > From: Simon Horman > > Sent: Friday, April 3, 2026 6:12 AM > > To: Loktionov, Aleksandr > > Cc: intel-wired-lan@lists.osuosl.org; Nguyen, Anthony L > > ; netdev@vger.kernel.org; Keller, Jacob E > > ; Marcin Szycik > > Subject: Re: [PATCH iwl-next] ixgbe: use ktime_get_real_ns() in > > ixgbe_ptp_reset() > > > > On Fri, Apr 03, 2026 at 02:10:38PM +0100, Simon Horman wrote: > > > On Fri, Mar 27, 2026 at 08:30:39AM +0100, Aleksandr Loktionov wrote: > > > > From: Jacob Keller > > > > > > > > Replace ktime_to_ns(ktime_get_real()) with the direct equivalent > > > > ktime_get_real_ns() in ixgbe_ptp_reset(). Using the combined helper > > > > avoids the unnecessary intermediate ktime_t variable and makes the > > > > intent clearer. > > > > > > > > Signed-off-by: Jacob Keller > > > > Signed-off-by: Aleksandr Loktionov > > > > Reviewed-by: Marcin Szycik > > > > > > Reviewed-by: Simon Horman > > > > > > FWIIW, this pattern also seems to exist in e1000e, ixgbe and igb (twice). > > > > Of course, with this patch applied it's not present in ixgbe anymore :^) > > Right. Given that e1000e and igb are basically on life support only, I > would limit touching them unless we have relevant work to do in that area > in the future. Sure, that is fine by me.