From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f226.google.com (mail-qt1-f226.google.com [209.85.160.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFB633909A4 for ; Mon, 6 Apr 2026 17:58:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775498285; cv=none; b=qG/9WxkDljsF63F87Un1TlMUqGZqF4IN3vEVvaIHlJUFeBKvGZWl4Ag0V2coKq2J2MGHUkfo2bNMOz2FXa7VehEvwpDPU2gZczo9ixET8nkM5L6Wvpz6diJzeeVKNI/ILFovF5A54NXXNxTqsznMooFwCPtmFkZTecQBInI3R1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775498285; c=relaxed/simple; bh=1NlIS9xcxbFxK3vP/VmB0WSnGsgTNlhEU1DqSondv8A=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=o7R1PBsc4ICErO030DVJURWu5VJmbfwbqaEMZQek4nJTdWq8gnl5PYVbRuwDFq1fN8+bzpASzDB+CFOHUpHnNyZHpLwQO4HFdAWlyjlJh62MCEch33d2jTpEmnT7rXdzAgqjZ5/lKNblihw0hlV3xZVaNHygMJm9QJvxG8j5PQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Vt2orQUJ; arc=none smtp.client-ip=209.85.160.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Vt2orQUJ" Received: by mail-qt1-f226.google.com with SMTP id d75a77b69052e-50b2b2aa276so41394821cf.3 for ; Mon, 06 Apr 2026 10:58:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775498283; x=1776103083; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SzTj5O42wXMyYqLPUybTBY9GP0xdyTb+BoKz6aKizPE=; b=bqs6R7vTel9yY3Uh3W3EvNVO+tVOb6h4IcCA2hII1agaXLcgqMwjvKVOOiQLc0kiun ZLmTfnPkKPMh3x7T6QthO6Owd1DOu64BMUieL/W/w3NuEw6ppRmAYy2w6lPWZMfPiE/Q i0owhN4C6rdRWOmNAREkEYQs4iJHcvl0s+G5PfcW8ILLn4pPFxGO6b/zpWG9BfCALfKU Z8M0oShK3Vb8q94/993cHnWwmiUgVmCa0Kj5JQVbefUAqChlY/3T/e6QWDzQG9TSIZx6 qY+d2ZqPNihdlhj0CD2rLDwlgwSX+KrFPHApxidUXEU3byofcU41g/vb9GJ9vFkfis34 qRKQ== X-Gm-Message-State: AOJu0YxjJ9qOKFjmyWDMOOHqW5qqmdFb18w9lmufUhn+L/C0fpCGCagv YS3kJj0fhKku/HURywXsbDRU6sFTyOa6s83F1Oi8wyOi9CbpP2RppkzGIm1WdEQsprBKcS+ytR0 3/HW9YOv5ufBb2Na4lBOE03PuBA6bh7qn+BxWx84ZO1EkvUJilQFvcI5HW3YbkIfclk+L6/2W02 86YZOBY1QNqMhbXHyUqzGlU58sk2PuVzhtkgFkkKvRx4DmyWE418d09tAGNB2/ao5hnLsHjRU22 LnwDvFWEQ== X-Gm-Gg: AeBDieupjeFCdibM804r7ZDbhuuHf8IaYtd3LvqOGwM5HhHAO7CwORGFX35ldjkVxQQ CVtIfgjjsdxlq/GH8bEqaDmAtYp/osxbVJmzsHIdPups1lLhsNHyfjI4WwyNNI+uPc49Nl+HdT+ jldtsmK1Ibt/UtrBAwLdYhYEZXYLG2dEBsXrun7hrU8omePRrKeOiywefLKrSnLFkoZdLJqtcqh pIm84NTRuuRMbSz0vydUVJMrjeBD3BWX8d10xYwkyymTAoe47rlsxFCIq23B7Xaw5p45TH4BpSz kuUmTCTi+ZMwzSOGNtu73O54Z3jE2pX+R1xvqir9Xjd75uUfwQCHXZYbfHXM5mvk8/zfJVUP13W ZOArDzdDYEP0EBwItVS0OxLhr3Z8UsMspU3wtk9XI2RUOI/EO7wJCM3mg6nix/fkOsFyQR+f38S TcIn6movIwrtbp8QGFFrY4pFPSf5J60xT60YIRmCRNfHmnJQgGXyhr7hI= X-Received: by 2002:a05:622a:4e09:b0:509:3d06:96a with SMTP id d75a77b69052e-50d62b12664mr201371861cf.53.1775498282725; Mon, 06 Apr 2026 10:58:02 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24]) by smtp-relay.gmail.com with ESMTPS id d75a77b69052e-50d4f6ad262sm9257251cf.9.2026.04.06.10.58.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Apr 2026 10:58:02 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89f670976acso117038896d6.0 for ; Mon, 06 Apr 2026 10:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1775498281; x=1776103081; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SzTj5O42wXMyYqLPUybTBY9GP0xdyTb+BoKz6aKizPE=; b=Vt2orQUJ+3fMR3tTiurAmnGmHp9CJGuPvjioUgKGR4nWGQoc5RJE3PKhZmzwhiLj48 3SK1TeDGYPKEnB96bpG8LgtWfv7k1azlZQ9gJdpkY+CotFe4oB8Tn5CvxpK2d3btAUO6 90zBK6Qg7ivAPcSSd2qYoBM/AeaXP+DMoLw1s= X-Received: by 2002:a05:6214:224b:b0:89a:107a:5ad with SMTP id 6a1803df08f44-8a704cb262cmr224865736d6.45.1775498281150; Mon, 06 Apr 2026 10:58:01 -0700 (PDT) X-Received: by 2002:a05:6214:224b:b0:89a:107a:5ad with SMTP id 6a1803df08f44-8a704cb262cmr224865246d6.45.1775498280564; Mon, 06 Apr 2026 10:58:00 -0700 (PDT) Received: from stbsdo-bld-1.sdg.broadcom.net ([192.19.161.248]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8a596915986sm141462266d6.24.2026.04.06.10.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 10:58:00 -0700 (PDT) From: Justin Chen To: netdev@vger.kernel.org Cc: pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, opendmb@gmail.com, nb@tipi-net.de, Justin Chen Subject: [PATCH net v3 0/3] net: bcmgenet: fix queue lock up Date: Mon, 6 Apr 2026 10:57:53 -0700 Message-Id: <20260406175756.134567-1-justin.chen@broadcom.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e We have been seeing reports of logs like this. # [ 39.713199] bcmgenet 1001300000.ethernet eth0: NETDEV WATCHDOG: CPU: 0: transmit queue 2 timed out 7991 ms [ 41.761198] bcmgenet 1001300000.ethernet eth0: NETDEV WATCHDOG: CPU: 0: transmit queue 2 timed out 10039 ms [ 43.745198] bcmgenet 1001300000.ethernet eth0: NETDEV WATCHDOG: CPU: 0: transmit queue 2 timed out 12023 ms [ 45.729198] bcmgenet 1001300000.ethernet eth0: NETDEV WATCHDOG: CPU: 0: transmit queue 2 timed out 14007 ms We have two issues. The persistent queue timeouts and the eventual lock up of the entire transmit. We address the lock up issue first. The queue timeouts are due to a fundamental design issue not a bug perse. Timeouts still persist, but we should no longer lock up. v3 - Dropped this patch. Not relevant yet. net: bcmgenet: relax the xmit ring full case v2 - These patches stayed the same. net: bcmgenet: fix off-by-one in bcmgenet_put_txcb net: bcmgenet: fix leaking free_bds - New patches that fix a few other slightly related issues. net: bcmgenet: fix off-by-one in bcmgenet_put_txcb net: bcmgenet: relax the xmit ring full case Justin Chen (3): net: bcmgenet: fix off-by-one in bcmgenet_put_txcb net: bcmgenet: fix leaking free_bds net: bcmgenet: fix racing timeout handler .../net/ethernet/broadcom/genet/bcmgenet.c | 30 +++++++++---------- 1 file changed, 14 insertions(+), 16 deletions(-) -- 2.34.1