From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FEBF304BDF; Mon, 6 Apr 2026 21:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775511044; cv=none; b=i7vnfpFTSq7cASiFpKo/h2G7GZ/4B3U1XQacMgtcrnNT+g9rETYH/CFQ9kHsismVp3rmz1/1sDEdRFrkp8rwvI8TBRyrMxhwvdrX/8OHkFdcv58enZ0MEoOEaP0b0FThXulBde4aWSFgTGJE+7L407381Q9JFDamWeaED5H0Evo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775511044; c=relaxed/simple; bh=EBBX5AvIPQbD/OevBQffUNUxIiVWvmO32BVoUF8K2vA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qlGpjtD504bu3G6m6aqiUXFustHG7S7wKdQ/CsXk1UQryNT4Gldb6CirgToq9a9h5HPkqng996SAs+fpdNuyBHsoWf0sD0CqcJhYUyTiF3oUGm8h8U5yukgpzRkEV+V+Vrp0hmoQMZfMb7dYbK11F9dVL1IQWUd111NrMj2KcIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MPtw7w1p; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MPtw7w1p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775511043; x=1807047043; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EBBX5AvIPQbD/OevBQffUNUxIiVWvmO32BVoUF8K2vA=; b=MPtw7w1pIeFiyee+hx9uN2Oau+u/VeUzygSxbCJlkh8UZRfl95Rmwyz8 T6IjLEfYFv3UJo1e748v2FdqkDdElxYayiBrXaeFk9XRbDSuqprRaxv+D MdhOOqCHdFGV72UfjcJLlUatNKnUEDiZ3SbelnO2S230r3sE033c4h4pw rxHwTTLAA9MKu+wNO+6B6tuZwH+vPxKdbWCPiMT30yGPkkGK9sJdQHkCC Wm+bk1C6gqoRi6ySUR130nYt5lvYMTHnDyljZXuuj2ypiThbJDZdGOn1N z4kVqrV9TVH6PA7mKcQIIhXwAztApWcSDNGsNHea/fyjjn1qLW8H8DWwy g==; X-CSE-ConnectionGUID: Ua0k16H5SrKR0TSeiis3yg== X-CSE-MsgGUID: 877EuXMnSUK05GXVXH3Mpg== X-IronPort-AV: E=McAfee;i="6800,10657,11751"; a="79057388" X-IronPort-AV: E=Sophos;i="6.23,164,1770624000"; d="scan'208";a="79057388" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2026 14:30:41 -0700 X-CSE-ConnectionGUID: 4Jo9KR5mRWqdTESjopBtWQ== X-CSE-MsgGUID: wlc/CXaaTCeXh1hCfsQNxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,164,1770624000"; d="scan'208";a="228248101" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orviesa007.jf.intel.com with ESMTP; 06 Apr 2026 14:30:40 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org Cc: Emil Tantilov , anthony.l.nguyen@intel.com, bigeasy@linutronix.de, clrkwllms@kernel.org, rostedt@goodmis.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org, Ray Zhang , Aleksandr Loktionov , Samuel Salin Subject: [PATCH net 2/9] idpf: improve locking around idpf_vc_xn_push_free() Date: Mon, 6 Apr 2026 14:30:29 -0700 Message-ID: <20260406213038.444732-3-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260406213038.444732-1-anthony.l.nguyen@intel.com> References: <20260406213038.444732-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Emil Tantilov Protect the set_bit() operation for the free_xn bitmask in idpf_vc_xn_push_free(), to make the locking consistent with rest of the code and avoid potential races in that logic. Fixes: 34c21fa894a1 ("idpf: implement virtchnl transaction manager") Cc: stable@vger.kernel.org Reported-by: Ray Zhang Signed-off-by: Emil Tantilov Reviewed-by: Aleksandr Loktionov Acked-by: Sebastian Andrzej Siewior Tested-by: Samuel Salin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c index 582e0c8e9dc0..fbd5a15b015c 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -402,7 +402,9 @@ static void idpf_vc_xn_push_free(struct idpf_vc_xn_manager *vcxn_mngr, struct idpf_vc_xn *xn) { idpf_vc_xn_release_bufs(xn); + spin_lock_bh(&vcxn_mngr->xn_bm_lock); set_bit(xn->idx, vcxn_mngr->free_xn_bm); + spin_unlock_bh(&vcxn_mngr->xn_bm_lock); } /** -- 2.47.1