From: Jakub Kicinski <kuba@kernel.org>
To: Marc Harvey <marcharvey@google.com>, kuniyu@google.com
Cc: Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v5 00/10] Decouple receive and transmit enablement in team driver
Date: Tue, 7 Apr 2026 18:17:08 -0700 [thread overview]
Message-ID: <20260407181708.7a426a90@kernel.org> (raw)
In-Reply-To: <CANkEMgmeHoJkffx3B+N04buW-V0pHD9c=jajNWafmev6f6K85A@mail.gmail.com>
On Tue, 7 Apr 2026 16:06:02 -0700 Marc Harvey wrote:
> Thank you very much to kuniyu@google.com, who figured out how to
> recreate the issue on Fedora. Fedora's /etc/services maps TCP port
> 1234 to the "search-agent" service (normal), which tcpdump then uses
> to text-replace port numbers in its output. So the tests were looking
> for ${ip_address}.1234, but tcpdump was spitting out
> ${ip_address}.search_agent. What is strange is that the test already
> uses tcpdump's "-n" option: "Don't convert addresses (i.e., host
> addresses, port numbers, etc.) to names."
>
> It turns out that Fedora has a patched version of tcpdump that
> separates the normal "-n" option into two options! "-n" handles host
> addresses, and "-nn" handles port and protocol numbers. The tcpdump
> invocation used by the selftests only uses "-n". What's stranger is
> that passing "-nn" to tcpdump is actually portable, because under the
> hood it is treated as a counter, with or without the Fedora patch:
> https://github.com/the-tcpdump-group/tcpdump/blob/master/tcpdump.c#L1915
> (thanks again to Kuniyuki for discovering this).
Oh wow! Thanks to both of you for not giving up and getting to the
bottom of this :)
next prev parent reply other threads:[~2026-04-08 1:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 3:03 [PATCH net-next v5 00/10] Decouple receive and transmit enablement in team driver Marc Harvey
2026-04-06 3:03 ` [PATCH net-next v5 01/10] net: team: Annotate reads and writes for mixed lock accessed values Marc Harvey
2026-04-07 11:56 ` Jiri Pirko
2026-04-06 3:03 ` [PATCH net-next v5 02/10] net: team: Remove unused team_mode_op, port_enabled Marc Harvey
2026-04-07 11:56 ` Jiri Pirko
2026-04-06 3:03 ` [PATCH net-next v5 03/10] net: team: Rename port_disabled team mode op to port_tx_disabled Marc Harvey
2026-04-06 3:03 ` [PATCH net-next v5 04/10] selftests: net: Add tests for failover of team-aggregated ports Marc Harvey
2026-04-06 3:03 ` [PATCH net-next v5 05/10] selftests: net: Add test for enablement of ports with teamd Marc Harvey
2026-04-06 3:03 ` [PATCH net-next v5 06/10] net: team: Rename enablement functions and struct members to tx Marc Harvey
2026-04-07 11:56 ` Jiri Pirko
2026-04-06 3:03 ` [PATCH net-next v5 07/10] net: team: Track rx enablement separately from tx enablement Marc Harvey
2026-04-07 11:56 ` Jiri Pirko
2026-04-06 3:03 ` [PATCH net-next v5 08/10] net: team: Add new rx_enabled team port option Marc Harvey
2026-04-07 11:57 ` Jiri Pirko
2026-04-06 3:03 ` [PATCH net-next v5 09/10] net: team: Add new tx_enabled " Marc Harvey
2026-04-07 11:57 ` Jiri Pirko
2026-04-06 3:03 ` [PATCH net-next v5 10/10] selftests: net: Add tests for team driver decoupled tx and rx control Marc Harvey
2026-04-06 14:44 ` [PATCH net-next v5 00/10] Decouple receive and transmit enablement in team driver Jakub Kicinski
2026-04-07 5:04 ` Marc Harvey
2026-04-07 23:06 ` Marc Harvey
2026-04-08 1:17 ` Jakub Kicinski [this message]
2026-04-07 11:55 ` Jiri Pirko
2026-04-08 0:12 ` Marc Harvey
2026-04-08 9:00 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407181708.7a426a90@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcharvey@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox