From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE7318871F for ; Wed, 8 Apr 2026 02:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775614545; cv=none; b=mzPt7plLrnkXRG44bAnW5A634HXgLzDrRAeZWm0gvh56xOCDFUqOcsgHFoZyBQWjwxY0TSYfsUZ2ZoJpb7kUzx43n83/sgADoeX+hfWYK4kmN3EExVuzaj3ibVFmefU+fyLa90boUXS0oS0uFiIpTZVLUbUMVOiGwXX9bNSda54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775614545; c=relaxed/simple; bh=uRgCcXnxqAK8WOFlzbn9Lfj/9x1GvwDCBtC97jUzkkQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FBaclVv1icB0grZ/RAwk+YTvvDaVrbn1DZhG8IhNcbVpYh5dZFFziBrDHKSUR206QW38K9tUYGnF/nbkhEdmBy+koe+D9EjGENkJPEZ8O/ZDCYvtNh0mKY+xIliZB4gAzdXuopU9NxY9tLRbj5OKWw/9cDGjIYYS1BIY5N11E7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BoKIMZ+i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BoKIMZ+i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A59F8C116C6; Wed, 8 Apr 2026 02:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775614545; bh=uRgCcXnxqAK8WOFlzbn9Lfj/9x1GvwDCBtC97jUzkkQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BoKIMZ+io4pgGP98NQjU9FSNBkm6FHNDTaVx5WrUBr+jXLbF3W4wnnl5kVl2y/DOz fzk5zmXGIYox/Nc0Jcrcs3mBpxim7btxoR9mT9nnHPl76gfvmEGdHb1Muwk0xYFGLm LTNirlVmI40y1opATHkMmK5fiI3r7RlSRMQaWxwqwlsg5lz/9TcxyM6LIZyGvKrzAN 4R3CbHTG30a+mYLjqEgwjMbEqz3YFyd11iHF3RVAsLG88tlqs0q6DnbXR3LYBacTs5 erMREAi21cB71zzdQN1jLK9QbhcBCn3Kf8DfEvVLk5xby2WpOiSdUD18erWp1j4e9x gW5OYsl62CXsg== Date: Tue, 7 Apr 2026 19:15:43 -0700 From: Jakub Kicinski To: Willem de Bruijn Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, Willem de Bruijn Subject: Re: [PATCH net-next v3] selftests/net: convert so_txtime to drv-net Message-ID: <20260407191543.0593b5aa@kernel.org> In-Reply-To: <20260406025020.1636895-1-willemdebruijn.kernel@gmail.com> References: <20260406025020.1636895-1-willemdebruijn.kernel@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 5 Apr 2026 22:49:22 -0400 Willem de Bruijn wrote: > +@ksft_variants(_test_variants_mono()) > +def test_so_txtime_mono(cfg, ipver, args_tx, args_rx): > + """Run all variants of monotonic (fq) tests.""" > + cmd(f"tc qdisc replace dev {cfg.ifname} root fq") > + test_so_txtime(cfg, "mono", ipver, args_tx, args_rx, False) > + > + > +def _test_variants_etf(): > + for ipver in ["4", "6"]: > + for testcase in [ > + ["no_delay", "a,-1", "a,-1", True], > + ["zero_delay", "a,0", "a,0", True], > + ["one_pkt", "a,10", "a,10", False], > + ["in_order", "a,10,b,20", "a,10,b,20", False], > + ["reverse_order", "a,20,b,10", "b,10,a,20", False], > + ]: > + name = f"_v{ipver}_{testcase[0]}" nit: looking at the results in NIPA: https://netdev-ctrl.bots.linux.dev/logs/vmksft/net-drv/results/593442/5-so-txtime-py/stdout the leading _ seems unnecessary? > + yield KsftNamedVariant( > + name, ipver, testcase[1], testcase[2], testcase[3] > + ) > + > + > +@ksft_variants(_test_variants_etf()) > +def test_so_txtime_etf(cfg, ipver, args_tx, args_rx, expect_fail): > + """Run all variants of etf tests.""" > + try: > + # ETF does not support change, so remove and re-add it instead. > + cmd_prefix = f"tc qdisc replace dev {cfg.ifname} root" > + cmd(f"{cmd_prefix} pfifo_fast") > + cmd(f"{cmd_prefix} etf clockid CLOCK_TAI delta 400000") > + except Exception as e: > + raise KsftSkipEx("tc does not support qdisc etf. skipping") from e > + > + test_so_txtime(cfg, "tai", ipver, args_tx, args_rx, expect_fail) I _think_ we'll leave ETF installed on the device after the test? That seems not super great. As we discussed before rebuilding the whole hierarchy will be tedious but we could at least replace with mq on exit and let it put whatever the default qdisc is as its leaves?