From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f201.google.com (mail-qt1-f201.google.com [209.85.160.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F41053C73FF for ; Wed, 8 Apr 2026 12:56:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775652981; cv=none; b=O2yJyKi0yf9c7Qzj3ZSlo64Y+YQbjiBYab1SGLILgmFtetGceIVXDayAdKXIW9yOyQKr5S7MVmWNaVWq9Uk7KHcscL2F85j2KmcY46sWH8/MXM2F+2K0Az05iACV5CYqOwKiGhtWLGCczscJRzmnOzuDglgaWd5ABe1Ye8QBU/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775652981; c=relaxed/simple; bh=C3lB+1f0qaR30gLOF4c1HLoWdHCA1gdjUjWrDfHvPAQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=lGmvdwxN6CSARYGyYNavyZl/butmHCjigS+wkJcBOVpUcWZAUsHN4dlPHXPLPKv/Aq2dlioqcSmqEMKya3VwaXG+fX25rf3ZCpuKA5CQOyPibJhBogKfzXrRAL6bGtAaG5i8Jy2J7DoWPFlVnNi2JA8Ukk/Xt7hfqQ4gBBL6nrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=t6YTXZ80; arc=none smtp.client-ip=209.85.160.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edumazet.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="t6YTXZ80" Received: by mail-qt1-f201.google.com with SMTP id d75a77b69052e-50d84b5f73bso97613151cf.0 for ; Wed, 08 Apr 2026 05:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775652979; x=1776257779; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8lRHl8je5D2ZkoXYt/ZWfeFEvt0P0M+HOlaF2F0zd1Y=; b=t6YTXZ80ZiCWGwYkxnGZDMVslhFej2JlZcjZzdbED4utaNoOwcPQDtT8EbHJ1Ijft2 nJe1nFc5jEfa/RNbcCySwojmxiJrHB34ZRpZqDEutaAByAkESbCh6ORAxYC/KK8KSHQY uI/nTuFVQdqBwMW3OwnW3eSX+0nXG8Tk6SWM9IZMoGzx1qVe4kd1n++hPOPZKx1XgG4K MDjjM0zxjjJwfzCV1tE13nzSKdez3S8uArhGjgRrX24A9ODZHzF27rfctSDErRvGQGxV Tbeg3dBp7ej+YZIDPvpKtUVcT1BKWowu2bLcVWucrqghKe3cSsypyWLZebN7DKgRxVza ePrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775652979; x=1776257779; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8lRHl8je5D2ZkoXYt/ZWfeFEvt0P0M+HOlaF2F0zd1Y=; b=h2bee3neSjAoEzchqGl3tLeOQ42xQFVw7ZjN9NdvahIMIGHeC89Lj0B+zl9j2r+QOM As1AQRjonvX+FlUfvkpaVkL+fv/ZOeWXdv3F+PnQfHwaBcuiWgjZ+u9Qh+2xA2TFtExZ e9Pk3vdF026jzjkVFvN2eo3gaw4bvuz9d3JSqiAdgtRPqiRPRIWjmOS1N7mzu0AJJ5C3 HokLRn1nG1r+NYE9VyGqPd8+xjVO7CZzEtbtzBhRiYNRPCnNQI+iQ32UfaTVDBDgg6A4 MREL1eFQ96ZoiJp3oPUCO8C2CRV/MdcXUt31nGisevvjFWoJSge7kK+SRuvpSzkcWpp+ fqKw== X-Forwarded-Encrypted: i=1; AJvYcCXs36oZTuf7kM6KoH6OqrGb8scYzVTinUUP56cYuU/LEFAA6wFqaV3TyGlh7eINNHUlhg6+cok=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7OydDfcXHXlSjnz2uuda2PC2wEmpoFL5oNS039HHYi1pjRUTD TL9rA3rNqP5LcdW3jRdXpNO2n0UY22Crvo6UXY+WM9hSj/iXWXfzBMnwM5aDf6Qew86ABSD60iZ JXHv/jrNWXscM2A== X-Received: from qtwq16.prod.google.com ([2002:a05:622a:310:b0:506:bc2d:8fb2]) (user=edumazet job=prod-delivery.src-stubby-dispatcher) by 2002:a05:622a:15ca:b0:50d:b6dc:e4e0 with SMTP id d75a77b69052e-50db6dcea51mr25401741cf.29.1775652978731; Wed, 08 Apr 2026 05:56:18 -0700 (PDT) Date: Wed, 8 Apr 2026 12:55:59 +0000 In-Reply-To: <20260408125611.3592751-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260408125611.3592751-1-edumazet@google.com> X-Mailer: git-send-email 2.53.0.1213.gd9a14994de-goog Message-ID: <20260408125611.3592751-4-edumazet@google.com> Subject: [PATCH net-next 03/15] net/sched: add READ_ONCE() in gnet_stats_add_queue[_cpu] From: Eric Dumazet To: "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Jamal Hadi Salim , Jiri Pirko , Kuniyuki Iwashima , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet Content-Type: text/plain; charset="UTF-8" Stats are read locklessly, add READ_ONCE() to prevent load-stearing. Write side will be handled in separate patches. Signed-off-by: Eric Dumazet --- net/core/gen_stats.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c index b71ccaec0991461333dbe465ee619bca4a06e75b..1a2380e74272de8eaf3d4ef453e56105a31e9edf 100644 --- a/net/core/gen_stats.c +++ b/net/core/gen_stats.c @@ -345,11 +345,11 @@ static void gnet_stats_add_queue_cpu(struct gnet_stats_queue *qstats, for_each_possible_cpu(i) { const struct gnet_stats_queue *qcpu = per_cpu_ptr(q, i); - qstats->qlen += qcpu->qlen; - qstats->backlog += qcpu->backlog; - qstats->drops += qcpu->drops; - qstats->requeues += qcpu->requeues; - qstats->overlimits += qcpu->overlimits; + qstats->qlen += READ_ONCE(qcpu->qlen); + qstats->backlog += READ_ONCE(qcpu->backlog); + qstats->drops += READ_ONCE(qcpu->drops); + qstats->requeues += READ_ONCE(qcpu->requeues); + qstats->overlimits += READ_ONCE(qcpu->overlimits); } } @@ -360,11 +360,11 @@ void gnet_stats_add_queue(struct gnet_stats_queue *qstats, if (cpu) { gnet_stats_add_queue_cpu(qstats, cpu); } else { - qstats->qlen += q->qlen; - qstats->backlog += q->backlog; - qstats->drops += q->drops; - qstats->requeues += q->requeues; - qstats->overlimits += q->overlimits; + qstats->qlen += READ_ONCE(q->qlen); + qstats->backlog += READ_ONCE(q->backlog); + qstats->drops += READ_ONCE(q->drops); + qstats->requeues += READ_ONCE(q->requeues); + qstats->overlimits += READ_ONCE(q->overlimits); } } EXPORT_SYMBOL(gnet_stats_add_queue); -- 2.53.0.1213.gd9a14994de-goog