From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A18983A5E9F for ; Thu, 9 Apr 2026 18:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775760037; cv=none; b=XFRhqHcoF+oumFjVpaAwYRYpEvv4bqn36cN0uNPCGhWTVOWECsaqXNH7EANcWMQBjKiybM1/olMr7khZdO205Uc6dZiNsyKj65AV5R4uyjFPU1uneX58NRt2DdxwxRkzH97YlVBeW6Qp/1fl0TGupWKz/aBjBWXmRXnEysEuRpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775760037; c=relaxed/simple; bh=LVgn0vBdkVsmYtOJ2Mv8Tab1Z8bSNEKNjFGxlFR9yQ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bKnDFrVBtTqd0Z/pBdsFh+8D3yczhYP1NiitOds4dO/lcrE2QFzcGMgJkh0ltbqnyfPKdyi+WW7RpWCPDkDipPgeqSnhdi0sYVqovj3SHT8/iUTCQQtB8gCnw+0UNr6jflvazI6KHePoXoSgbPG81DyHqyu4Mzb7BFGPtiNb8II= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WhrvNbrl; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WhrvNbrl" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43b9d3ebed5so1003247f8f.1 for ; Thu, 09 Apr 2026 11:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775760034; x=1776364834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cbSeM7rVE+r24N6osWe4SerhDWF0/QD9ts6cYUU6inY=; b=WhrvNbrly25+Togsaly3e4BXhhMpkO1Yt3BoLHXbHTjLF1r7DBhemt9VulCZIJesqc QiMML/vmORrziXZQ+Wzyks3sa8icaSZdq7DKAQAveM3PcGPnfI4996aLTSKaSdFqU7+E xRfiKn9Rr2IWbtJl5OQwA93lgP1DpDPwWyI++znrU7mgUcVFgPIguRkAhLtYL00brI/A 1IlYNXdCSyNSt0E58Q00PgAjiYtTl1HHub0RpdLJyOFMVklKZxHpybv1jGv5adBDDJAF ApOmi0XLioQxMbd8FMdD+9L91fx/7T8xjNtMPFuQrwi2w5kbV2VP/jqbLldFajdwSts9 2srg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775760034; x=1776364834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cbSeM7rVE+r24N6osWe4SerhDWF0/QD9ts6cYUU6inY=; b=d/CkXlGC8FiuLb3RoUBKXz4tXnBXnM6ht6Rrw5lzu2EFx9StsOL8f4/3sDLOg5wubx 14HtzSCKyF3CGKZvxEnZe+vltYFLr5G68YWsm+z7b25k0ODsAATAj06M/yp5kT9/goaC Onfg4ZRzTY3vcmQgBbjvJJYleBb4CS1peKuG7G+GFEs7T6+tqJyOf2EH9imqWBweYyUo ZbLLWQV8l9tjyuHi5j3cIlEJCESB/+0fGjeNNh6uq/4J5Sn967JbvgqteozQGYbQmVh5 f+heWvRsfcZw3+ZBImTu+tho+DKc9V0Yx9HqzREOw6JTpCSuXgvhr8pviv5NR0zTZJpb o7IA== X-Gm-Message-State: AOJu0Yw0NQ7L6g5aDNX/ajx0tjf/mnWq7hOB6+5t7/3M3wCSu4tLGpzX Rn0itAAI6POeuS5WnkL1ykqtOPPYykuciOI/oQXYm99FWs62izfW4J6rX9ZDzE2ddyLPQw== X-Gm-Gg: AeBDies1muj06IxP7xjxSwGNWs/nmuM1XmehDOXe3AO8/N22snRNcoych9OhgX0L3vX a3tcIftIwi7yOB2+mEjrfUpyUnJdBJRavN9xP3o2EOLHIdvVTomUaPtH3HkR/78V+fcJjLk6S66 h6/BRZCvVE5wJm5W+S38JAE4zNE+TVw2q+wXYyxZ36VEBM8/BWxUvJd6bcnuPwXgmfiEX/Tuqvr q23EdfWt0rDt/5XiNN7TvEBGm8Fr3iiPSEmjqsYLwEJMLpTHKim5W5DN2NPs+Y7gJ7IxqaO99WV nyC8o/Q4a1enP6SzbtRqfvL4vhRzvD7UrSJ/X54Z6Wr4J6ZDAHt06/nx+nSH0DOTk9DBIIs5o2i SbHXzZKa8FP0mCImZLCJp62U2wVY10DhnCE96E6piozoTy8ReMR5GMyZOXIfDv7FzXJ9iYqJx1r 1PApXC6RtnA0jAE1rPTENVC5yFLeGyYcqyI8AbB2saD2JFL3cd3dDkMdSL02co2+qfwcOXoFt0z Ma9H5VeutKoUpoDlu/uX5s= X-Received: by 2002:a05:6000:40dc:b0:439:bd70:610f with SMTP id ffacd0b85a97d-43d642bac24mr244448f8f.44.1775760033721; Thu, 09 Apr 2026 11:40:33 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e5d88bsm560563f8f.37.2026.04.09.11.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 11:40:33 -0700 (PDT) From: David Carlier To: netdev@vger.kernel.org Cc: vburru@marvell.com, sedara@marvell.com, srasheed@marvell.com, sburla@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Carlier Subject: [PATCH net v2 2/2] octeon_ep_vf: add NULL check for napi_build_skb() Date: Thu, 9 Apr 2026 19:40:09 +0100 Message-ID: <20260409184009.930359-3-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260409184009.930359-1-devnexen@gmail.com> References: <20260409184009.930359-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit napi_build_skb() can return NULL on allocation failure. In __octep_vf_oq_process_rx(), the result is used directly without a NULL check in both the single-buffer and multi-fragment paths, leading to a NULL pointer dereference. Add NULL checks after both napi_build_skb() calls, properly advancing descriptors and consuming remaining fragments on failure. Fixes: 1cd3b407977c ("octeon_ep_vf: add Tx/Rx processing and interrupt support") Cc: stable@vger.kernel.org Signed-off-by: David Carlier --- .../marvell/octeon_ep_vf/octep_vf_rx.c | 30 +++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_rx.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_rx.c index 7bd1b9b8d7f5..d98247408242 100644 --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_rx.c +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_rx.c @@ -414,10 +414,15 @@ static int __octep_vf_oq_process_rx(struct octep_vf_device *oct, data_offset = OCTEP_VF_OQ_RESP_HW_SIZE; rx_ol_flags = 0; } - rx_bytes += buff_info->len; - if (buff_info->len <= oq->max_single_buffer_size) { skb = napi_build_skb((void *)resp_hw, PAGE_SIZE); + if (!skb) { + oq->stats->alloc_failures++; + desc_used++; + read_idx = octep_vf_oq_next_idx(oq, read_idx); + continue; + } + rx_bytes += buff_info->len; skb_reserve(skb, data_offset); skb_put(skb, buff_info->len); desc_used++; @@ -427,6 +432,27 @@ static int __octep_vf_oq_process_rx(struct octep_vf_device *oct, u16 data_len; skb = napi_build_skb((void *)resp_hw, PAGE_SIZE); + if (!skb) { + oq->stats->alloc_failures++; + desc_used++; + read_idx = octep_vf_oq_next_idx(oq, read_idx); + data_len = buff_info->len - oq->max_single_buffer_size; + while (data_len) { + dma_unmap_page(oq->dev, oq->desc_ring[read_idx].buffer_ptr, + PAGE_SIZE, DMA_FROM_DEVICE); + buff_info = (struct octep_vf_rx_buffer *) + &oq->buff_info[read_idx]; + buff_info->page = NULL; + if (data_len < oq->buffer_size) + data_len = 0; + else + data_len -= oq->buffer_size; + desc_used++; + read_idx = octep_vf_oq_next_idx(oq, read_idx); + } + continue; + } + rx_bytes += buff_info->len; skb_reserve(skb, data_offset); /* Head fragment includes response header(s); * subsequent fragments contains only data. -- 2.53.0