From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BDDC37EFE3; Fri, 10 Apr 2026 11:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775821202; cv=none; b=ctsbqARjuA7ArtU7SuSz+3fVDvbw0nYxJ1ItkbmZgGHeN5CE8oxBijc0PJAh4kW2GWKc1IDg3++IGz20T3WpK+j/bF5dPCu/yrXqs4RrJXIUmnZgLbTYiwNzimXqG/VNByKjDKL9z/8S3gLXxK9suzfEz6qjTnPKvmyV4bi71y0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775821202; c=relaxed/simple; bh=SH551Wjva/R27IpLZMFIIb7R0fTqglG5CniuwMHqU/4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kd1XEjCPy0nobZmhqo5w3646qkaTBIS87X7pq24hGuy0ve4moHTwXu4tesq/5+5tRfp552lqag5JpLPNzSRZI6kjBubrNj2iwwnAtPTK6vew7Zfsb53mjnZo2/95hy/kNuHkyyupTch/Uei3osavrzBtgHtWvlzz0FpL7cmlB9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eVb8i2ll; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eVb8i2ll" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C49CC19421; Fri, 10 Apr 2026 11:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775821201; bh=SH551Wjva/R27IpLZMFIIb7R0fTqglG5CniuwMHqU/4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eVb8i2lle/LvVlU4ii3wbKeY1nT6Jzrp5rnb9fslJQqq7veJPxTOBIo2QPiXVY4fw m5vFdKMR7jmiCOcAOcRRzmF6G5M/ejQEptOHQ6x3Ez+68Eja6wIGWUddSGJnaQsMGd 3ywOcL4xXlxIrTEUyfuEaOhrKFqJqr5Ca5+pA42CoUfePOVvIliUig5rIZZaxzhBxc 9pV7tSNUEwfecbytc3Zeo8uGAY0b+ON01lkyyQUFX7fbfyrqQsn8tlU41PbspDlh10 FrcTOB7qB80DkzvlQ0PTh59dT+bmQgUSKIaj1QFybKvYU5rhPY28c+GAJAKrToaqi4 LUJBEMY6a/OCg== Date: Fri, 10 Apr 2026 12:39:57 +0100 From: Simon Horman To: Stephen Hemminger Cc: netdev@vger.kernel.org, Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , open list Subject: Re: [PATCH net v4 4/8] net/sched: netem: refactor dequeue into helper functions Message-ID: <20260410113957.GV469338@kernel.org> References: <20260406172627.210894-1-stephen@networkplumber.org> <20260406172627.210894-5-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260406172627.210894-5-stephen@networkplumber.org> On Mon, Apr 06, 2026 at 10:25:12AM -0700, Stephen Hemminger wrote: > Extract the tfifo removal, slot accounting, and child/direct dequeue > paths from the monolithic netem_dequeue() into separate helpers: > > netem_pull_tfifo() - remove head packet from tfifo > netem_slot_account() - update slot pacing counters > netem_dequeue_child() - enqueue to child, then dequeue from child > netem_dequeue_direct()- dequeue from tfifo when no child > > This replaces the goto-based control flow with straightforward function > calls, making the code easier to follow and modify. > > No functional change intended. Manually verified (as best I could :) > > Signed-off-by: Stephen Hemminger Thanks for splitting this out. It was very helpful. Reviewed-by: Simon Horman