From: Jakub Kicinski <kuba@kernel.org>
To: wit_yuan <yuanzhaoming901030@126.com>
Cc: netdev@vger.kernel.org, Yuan Zhaoming <yuanzm2@lenovo.com>
Subject: Re: [PATCH next-next v2] net:mctp: fix setting mctp hdr ver reserved field cause data dropped
Date: Fri, 10 Apr 2026 14:43:39 -0700 [thread overview]
Message-ID: <20260410144339.0d1b289a@kernel.org> (raw)
In-Reply-To: <20260410063334.7531-2-yuanzhaoming901030@126.com>
On Fri, 10 Apr 2026 14:33:34 +0800 wit_yuan wrote:
> From: Yuan Zhaoming <yuanzm2@lenovo.com>
>
> from spec dsp0236_1.2.1.pdf page 26, the mctp header contains the
> RSVD(4bit) and Hdr version(4 bit).
>
> mctp_pkttype_receive invoke mctp_hdr, and get mh->ver whole byte
> compare the MCTP_VER_MIN, MCTP_VER_MAX. the reserver bits may be by
> misleading used.
>
> one type hba card will set pcie vdm header Pad Len the same with RSVD
> bit, this will not work on mctp kernel solution.
We ask that:
- new patches are not posted in reply to old ones
- at least 24h passes before new version is posted
> + if (((mh->ver & MCTP_HDR_VER_MASK)) < MCTP_VER_MIN || (mh->ver & MCTP_HDR_VER_MASK) > MCTP_VER_MAX)
> goto out;
Please save the masked version to a variable and compare that extracted
variable. This line is unnecessarily long (max line length is 80 in
networking).
--
pw-bot: cr
next prev parent reply other threads:[~2026-04-10 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ff147a3f0d27ef2aa6026cc86f9113d56a8c61ac.camel@codeconstruct.com.au/T/#rc39d8ae7e5ee7e74556d16fc836cc9f2bf745701>
2026-04-10 6:09 ` wit_yuan
2026-04-10 6:09 ` [PATCH next-next v2] net:mctp: fix setting mctp hdr ver reserved field cause data dropped wit_yuan
2026-04-10 6:33 ` wit_yuan
2026-04-10 6:33 ` [PATCH next-next v2] net:mctp: fix setting mctp hdr ver reserved field cause data dropped wit_yuan
2026-04-10 21:43 ` Jakub Kicinski [this message]
2026-04-10 0:13 [PATCH] net:mctp: split mctp hdr version to ver and rsvd Jeremy Kerr
2026-04-10 6:17 ` wit_yuan
2026-04-10 6:17 ` [PATCH next-next v2] net:mctp: fix setting mctp hdr ver reserved field cause data dropped wit_yuan
2026-04-10 7:05 ` Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410144339.0d1b289a@kernel.org \
--to=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuanzhaoming901030@126.com \
--cc=yuanzm2@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox