public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@google.com>
To: kuba@kernel.org
Cc: davem@davemloft.net, edumazet@google.com,
	gregkh@linuxfoundation.org,  horms@kernel.org,
	linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org,
	 netdev@vger.kernel.org, pabeni@redhat.com, stable@kernel.org,
	 workflows@vger.kernel.org, yizhe@darknavy.com
Subject: Re: [PATCH net] netrom: do some basic forms of validation on incoming frames
Date: Fri, 10 Apr 2026 22:11:47 +0000	[thread overview]
Message-ID: <20260410221220.1708137-1-kuniyu@google.com> (raw)
In-Reply-To: <20260410145448.38253e3c@kernel.org>

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 10 Apr 2026 14:54:48 -0700
> On Fri, 10 Apr 2026 14:30:42 -0700 Jakub Kicinski wrote:
> > On Fri, 10 Apr 2026 07:24:36 +0200 Greg Kroah-Hartman wrote:
> > > On Thu, Apr 09, 2026 at 08:32:35PM -0700, Jakub Kicinski wrote:  
> > > > Or for simplicity we could also be testing against skb_headlen()
> > > > since we don't expect any legit non-linear frames here? Dunno.    
> > > 
> > > I'll be glad to change this either way, your call.  Given that this is
> > > an obsolete protocol that seems to only be a target for drive-by fuzzers
> > > to attack, whatever the simplest thing to do to quiet them up I'll be
> > > glad to implement.
> > > 
> > > Or can we just delete this stuff entirely?  :)  
> > 
> > Yes.
> > 
> > My thinking is to delete hamradio, nfc, atm, caif.. [more to come]
> > Create GH repos which provide them as OOT modules.
> > Hopefully we can convince any existing users to switch to that.
> > 
> > The only thing stopping me is the concern that this is just the softest
> > target and the LLMs will find something else to focus on which we can't
> > delete. I suspect any PCIe driver can be flooded with "aren't you
> > trusting the HW to provide valid responses here?" bullshit.
> > 
> > But hey, let's try. I'll post a patch nuking all of hamradio later
> > today.
> 
> Well, either we "expunge" this code to OOT repos, or we mark it 
> as broken and tell everyone that we don't take security fixes
> for anything that depends on BROKEN. I'd personally rather expunge.

+1 for "expunge" to prevent LLM-based patch flood.

IIRC, we did that recently for one driver only used by OpenWRT ?


> 
> cc: workflows, we can't be the only ones still nursing Linux 2.2 code

  reply	other threads:[~2026-04-10 22:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  8:45 [PATCH net] netrom: do some basic forms of validation on incoming frames Greg Kroah-Hartman
2026-04-09 19:03 ` Simon Horman
2026-04-10  3:32   ` Jakub Kicinski
2026-04-10  5:24     ` Greg Kroah-Hartman
2026-04-10 10:28       ` Simon Horman
2026-04-10 15:12         ` jj
2026-04-10 16:38           ` David Ranch
2026-04-10 17:21             ` Dan Carpenter
2026-04-10 18:23           ` Dan Cross
2026-04-10 21:30       ` Jakub Kicinski
2026-04-10 21:54         ` Jakub Kicinski
2026-04-10 22:11           ` Kuniyuki Iwashima [this message]
2026-04-10 22:25             ` Hugh Blemings
2026-04-10 22:51               ` Craig
2026-04-10 23:38                 ` Hugh Blemings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260410221220.1708137-1-kuniyu@google.com \
    --to=kuniyu@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@kernel.org \
    --cc=workflows@vger.kernel.org \
    --cc=yizhe@darknavy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox