From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATTCH net v6 0/5] netem bug fixes
Date: Sun, 12 Apr 2026 08:23:50 -0700 [thread overview]
Message-ID: <20260412152429.143474-1-stephen@networkplumber.org> (raw)
These bugs were found when doing AI assisted review of sch_netem.c
during investigation of the packet duplication recursion problem
addressed in Jamal's series.
The fixes cover:
- probability gaps in the 4-state Markov loss model
- queue limit not accounting for reordered packets
- PRNG reseeded on every tc change, breaking reproducibility
- slot delay configuration not validated for inverted ranges
- slot delay arithmetic overflow for ranges above ~2.1 seconds
v6 - drop 3 unnecessary patches; focus on real bugs.
Stephen Hemminger (5):
net/sched: netem: fix probability gaps in 4-state loss model
net/sched: netem: fix queue limit check to include reordered packets
net/sched: netem: only reseed PRNG when seed is explicitly provided
net/sched: netem: check for invalid slot range
net/sched: netem: fix slot delay calculation overflow
net/sched/sch_netem.c | 43 +++++++++++++++++++++++++++++++------------
1 file changed, 31 insertions(+), 12 deletions(-)
--
2.53.0
next reply other threads:[~2026-04-12 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-12 15:23 Stephen Hemminger [this message]
2026-04-12 15:23 ` [PATTCH net v6 1/5] net/sched: netem: fix probability gaps in 4-state loss model Stephen Hemminger
2026-04-12 15:23 ` [PATTCH net v6 2/5] net/sched: netem: fix queue limit check to include reordered packets Stephen Hemminger
2026-04-12 15:23 ` [PATTCH net v6 3/5] net/sched: netem: only reseed PRNG when seed is explicitly provided Stephen Hemminger
2026-04-12 15:23 ` [PATTCH net v6 4/5] net/sched: netem: check for invalid slot range Stephen Hemminger
2026-04-12 15:23 ` [PATTCH net v6 5/5] net/sched: netem: fix slot delay calculation overflow Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260412152429.143474-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox