From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 758AD303CAB; Sun, 12 Apr 2026 17:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776014007; cv=none; b=ANm+7B3hSq1PsZqIvEouUO4EyitbTbPQxgvRl0cLw9NuAd9rSQTUU5ZF4BX3O5h2B2Daz5TLCqaRtNAvjV2x7vowU/wS3S7SHCChRorhGKz8QTtK9rzHxZDr93prFoW48X1Z+pNJH3ekARTYstVJGnVpETi6l8GdWPEAaQESa1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776014007; c=relaxed/simple; bh=39JX7mOtNhsldORKgBwOADkTQ2nxQT4XamazNshont4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BEiZWEOddWrI5Gio9PlmEPKguPt2QhYRZCVF6HazLr4yLQEJOTv0bv8eifAeyfrCu8JxbaTBuAilrpgxBAbu72ixygEQ5M+mnKhNURgXqIfdc3QsN7aEQwiyiikPXCla2COEubqtBEXyJcF0ZniMhR7MdYHCWIcWdtWTS9azork= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=AtlDHy3t; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Raca2YiA; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="AtlDHy3t"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Raca2YiA" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id 81710EC0098; Sun, 12 Apr 2026 13:13:24 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Sun, 12 Apr 2026 13:13:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1776014004; x=1776100404; bh=7f1hmyeIgfebnGinJ8rs0t5a3jQvl9wpW1r29MsIhUI=; b= AtlDHy3tkkMGrCo0+vZJ+mAcLPGVGBzuUZf1+o6FDuQa+nKonsBX2AHrMT7CL7tN oFcCXXWhOdMG0Vss5SetIWuX/9lpl9IYKe5J0xpYUKzmKbJhGpXWIV+0pOLsuKAG UaAGSTzV/6yN1gbdzJxGk78mIDP2aQiA8R0jAb2nDybqytnV32xov0B+/w0Fq6Pk kj9SVOuO4sN7p6E2KIqnANeXpcVIkQiTYGTidjy1hDTLMupU+x4nqTEymBFsF4Ea bpqTKpKcbOq5GmKS0JFn9ejnU6jQSx0SPgD/o7QV4EDyqZQ2SPOfG4+G50Zp7A/l lkHPkIS69irmS88PwfVbGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1776014004; x= 1776100404; bh=7f1hmyeIgfebnGinJ8rs0t5a3jQvl9wpW1r29MsIhUI=; b=R aca2YiArd/06bl2M/2WX+r4ac51k9yxGQgbux667vG6tKLSSsv0qLaG7C4WwZapa ZcFamUFije4qze1Aqw+/7gPg67D6BvKxl0xSs2fTFV0/2cprnVnKtBTYFKfpOFlt vrUOOPyCasCNi617sXE9C06oUz6pJ9wDlm9Q3nzzrxyijZy82qWyaM1NsQmDzMFZ fBrA7TihCfMaebgLMD+M6lQ7jsNkzrMjfnO00vBkORqZ7OU990Nn7ZV7NaXV6Y8n aB0tjphSB0yE6aCFxlKm0zXcW9qtzn5w0VaJ2MafXoPfui4OqMeSVm++gWgORCDW aU/khkcBn0o3PJufnm3Tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdefheekkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomheppfhikhhlrghs ucfunpguvghrlhhunhguuceonhhikhhlrghsrdhsohguvghrlhhunhguodhrvghnvghsrg hssehrrghgnhgrthgvtghhrdhsvgeqnecuggftrfgrthhtvghrnhepkeegveffvdejheff ieduleffkeeiteegieehkeetgeethefhvdfgkeetfeeuhfeknecuffhomhgrihhnpeguth hsrdhimhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehnihhklhgrshdrshhouggvrhhluhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthh drshgvpdhnsggprhgtphhtthhopedutddpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepghgvvghrtheslhhinhhugidqmheikehkrdhorhhgpdhrtghpthhtohephihoshhhih hhihhrohdrshhhihhmohgurgdruhhhsehrvghnvghsrghsrdgtohhmpdhrtghpthhtohep phgruhhlsehpsggrrhhkvghrrdguvghvpdhrtghpthhtoheprghnughrvgifodhnvghtug gvvheslhhunhhnrdgthhdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhn vghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhlvgdrtghomhdprhgtphhtth hopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepphgrsggvnhhisehrvggu hhgrthdrtghomhdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdroh hrgh X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Apr 2026 13:13:23 -0400 (EDT) Date: Sun, 12 Apr 2026 19:13:21 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Geert Uytterhoeven Cc: Yoshihiro Shimoda , Paul Barker , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [net-next] net: ethernet: ravb: Suspend and resume the transmission flow Message-ID: <20260412171321.GA1520797@ragnatech.se> References: <20260401183608.1852225-1-niklas.soderlund+renesas@ragnatech.se> <20260407185443.GC2551274@ragnatech.se> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Geert, On 2026-04-08 09:44:33 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Tue, 7 Apr 2026 at 20:54, Niklas Söderlund > wrote: > > On 2026-04-07 11:03:38 +0200, Geert Uytterhoeven wrote: > > > On Wed, 1 Apr 2026 at 20:39, Niklas Söderlund > > > wrote: > > > > > > > > From: Yoshihiro Shimoda > > > > > > > > The current driver does not follow the latest datasheet and does not > > > > suspend the flow when stopping DMA and resume it when starting. Update > > > > the driver to do so. > > > > > > > > Signed-off-by: Yoshihiro Shimoda > > > > [Niklas: Rebase from BSP and reword commit message] > > > > Signed-off-by: Niklas Söderlund > > > > > > Thanks for your patch, which is now commit 353d8e7989b6babe ("net: > > > ethernet: ravb: Suspend and resume the transmission flow") in > > > linux-next/master net-next. > > > > > > > --- a/drivers/net/ethernet/renesas/ravb_main.c > > > > +++ b/drivers/net/ethernet/renesas/ravb_main.c > > > > @@ -694,6 +694,9 @@ static int ravb_dmac_init(struct net_device *ndev) > > > > const struct ravb_hw_info *info = priv->info; > > > > int error; > > > > > > > > + /* Clear transmission suspension */ > > > > + ravb_modify(ndev, CCC, CCC_DTSR, 0); > > > > + > > > > /* Set CONFIG mode */ > > > > error = ravb_set_opmode(ndev, CCC_OPC_CONFIG); > > > > if (error) > > > > @@ -1103,6 +1106,12 @@ static int ravb_stop_dma(struct net_device *ndev) > > > > if (error) > > > > return error; > > > > > > > > + /* Request for transmission suspension */ > > > > + ravb_modify(ndev, CCC, CCC_DTSR, CCC_DTSR); > > > > + error = ravb_wait(ndev, CSR, CSR_DTS, CSR_DTS); > > > > + if (error) > > > > + netdev_err(ndev, "failed to stop AXI BUS\n"); > > > > > > This error message is printed during resume from s2idle or s2ram on > > > e.g. Salvator-XS and Gray Hawk Single. Ethernet (nfsroot) still works > > > fine, though. > > > > I was not able to reproduce this on M3N (r8a77965-salvator-xs.dts) nor > > Sparrow Hawk (r8a779g3-sparrow-hawk.dts). I'm using the following to > > test, is your test-case different? > > > > # echo enabled > /sys/class/tty/ttySC0/power/wakeup > > # echo s2idle > /sys/power/mem_sleep > > # echo 0 > /sys/module/printk/parameters/console_suspend > > # echo mem > /sys/power/state > > Looks good. Major difference seems to be that I use either Wake-on-LAN > or gpio-keys wake-up, and I always have WoL enabled for ravb. WoL was indeed the key. Having iperf3 blasting traffic to the target made no difference and access to URAM is allowed to be suspended and no warning was triggered, however just enabling WoL and no traffic. # ethtool -s end0 wol g And URAM access will not be suspended and reported active when checking DTS in CSR register and this warning will be printed. I will send a patch to ignore the check if WoL is enabled (when net-next open), but still keep the request to stop URAM access. Nice catch! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Kind Regards, Niklas Söderlund