From: Jakub Kicinski <kuba@kernel.org>
To: Antonio Quartulli <antonio@openvpn.net>
Cc: netdev@vger.kernel.org, ralf@mandelbit.com,
Sabrina Dubroca <sd@queasysnail.net>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 2/5] selftests: ovpn: fail notification check on mismatch
Date: Mon, 13 Apr 2026 17:00:14 -0700 [thread overview]
Message-ID: <20260413170014.12316e9b@kernel.org> (raw)
In-Reply-To: <20260412221121.410365-3-antonio@openvpn.net>
On Mon, 13 Apr 2026 00:11:18 +0200 Antonio Quartulli wrote:
> compare_ntfs doesn't fail when expected and received notification
> streams diverge.
>
> Fix this bug by trackink the diff exit status explicitly and return it
> to the caller so notification mismatches propagate as test failures.
Hm, this series nicely cleans up test_mark.sh failures
but test_tcp.sh now always fails on debug (slow) kernel
builds with:
# TAP version 13
# 1..12
# ok 1 setup network topology
# ok 2 run baseline data traffic
# ok 3 run LAN traffic behind peer1
# ok 4 run iperf throughput
# ok 5 run key rollout
# ok 6 query peers
# ok 7 query missing peer fails
# ok 8 peer lifecycle and key queries
# ok 9 delete peer while traffic
# ok 10 delete stale keys
# ok 11 check timeout behavior
# Checking notifications for peer 3... failed
# 1,9d0
# < {
# < "name": "peer-del-ntf",
# < "msg": {
# < "peer": {
# < "del-reason": "expired",
# < "id": 12
# < }
# < }
# < }
# validate listener output for peer 3: command failed with rc=1: ovpn_compare_ntfs 3
# not ok 12 validate notification output
# # Totals: pass:11 fail:1 xfail:0 xpass:0 skip:0 error:0
Similar failure in test_symmetric_id_tcp.sh
Only the debug kernels tho, non-debug kernels seem to pass.
So probably some race / slowness.
More runs if you want to compare
https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-extra-dbg&test=test-tcp-sh
This series landed in net-next-2026-04-13--06-00
next prev parent reply other threads:[~2026-04-14 0:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-12 22:11 [PATCH net-next 0/5] pull request: ovpn 2026-04-13 Antonio Quartulli
2026-04-12 22:11 ` [PATCH net-next 1/5] selftests: ovpn: add nftables config dependencies for test-mark Antonio Quartulli
2026-04-12 22:11 ` [PATCH net-next 2/5] selftests: ovpn: fail notification check on mismatch Antonio Quartulli
2026-04-14 0:00 ` Jakub Kicinski [this message]
2026-04-14 9:01 ` Antonio Quartulli
2026-04-12 22:11 ` [PATCH net-next 3/5] selftests: ovpn: flatten slurped notification JSON before filtering Antonio Quartulli
2026-04-12 22:11 ` [PATCH net-next 4/5] selftests: ovpn: add namespace to helpers and shared variables Antonio Quartulli
2026-04-12 22:11 ` [PATCH net-next 5/5] selftests: ovpn: align command flow with TAP Antonio Quartulli
2026-04-13 23:56 ` Jakub Kicinski
2026-04-14 9:02 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413170014.12316e9b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=antonio@openvpn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@mandelbit.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox