public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Fomichev <sdf.kernel@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: [PATCH net-next v7 09/15] iavf: convert to ndo_set_rx_mode_async
Date: Mon, 13 Apr 2026 10:11:25 -0700	[thread overview]
Message-ID: <20260413171131.550126-10-sdf@fomichev.me> (raw)
In-Reply-To: <20260413171131.550126-1-sdf@fomichev.me>

Convert iavf from ndo_set_rx_mode to ndo_set_rx_mode_async.
iavf_set_rx_mode now takes explicit uc/mc list parameters and
uses __hw_addr_sync_dev on the snapshots instead of __dev_uc_sync
and __dev_mc_sync.

The iavf_configure internal caller passes the real lists directly.

Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
---
 drivers/net/ethernet/intel/iavf/iavf_main.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index dad001abc908..3c1465cf0515 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -1150,14 +1150,18 @@ bool iavf_promiscuous_mode_changed(struct iavf_adapter *adapter)
 /**
  * iavf_set_rx_mode - NDO callback to set the netdev filters
  * @netdev: network interface device structure
+ * @uc: snapshot of uc address list
+ * @mc: snapshot of mc address list
  **/
-static void iavf_set_rx_mode(struct net_device *netdev)
+static void iavf_set_rx_mode(struct net_device *netdev,
+			     struct netdev_hw_addr_list *uc,
+			     struct netdev_hw_addr_list *mc)
 {
 	struct iavf_adapter *adapter = netdev_priv(netdev);
 
 	spin_lock_bh(&adapter->mac_vlan_list_lock);
-	__dev_uc_sync(netdev, iavf_addr_sync, iavf_addr_unsync);
-	__dev_mc_sync(netdev, iavf_addr_sync, iavf_addr_unsync);
+	__hw_addr_sync_dev(uc, netdev, iavf_addr_sync, iavf_addr_unsync);
+	__hw_addr_sync_dev(mc, netdev, iavf_addr_sync, iavf_addr_unsync);
 	spin_unlock_bh(&adapter->mac_vlan_list_lock);
 
 	spin_lock_bh(&adapter->current_netdev_promisc_flags_lock);
@@ -1210,7 +1214,9 @@ static void iavf_configure(struct iavf_adapter *adapter)
 	struct net_device *netdev = adapter->netdev;
 	int i;
 
-	iavf_set_rx_mode(netdev);
+	netif_addr_lock_bh(netdev);
+	iavf_set_rx_mode(netdev, &netdev->uc, &netdev->mc);
+	netif_addr_unlock_bh(netdev);
 
 	iavf_configure_tx(adapter);
 	iavf_configure_rx(adapter);
@@ -5153,7 +5159,7 @@ static const struct net_device_ops iavf_netdev_ops = {
 	.ndo_open		= iavf_open,
 	.ndo_stop		= iavf_close,
 	.ndo_start_xmit		= iavf_xmit_frame,
-	.ndo_set_rx_mode	= iavf_set_rx_mode,
+	.ndo_set_rx_mode_async	= iavf_set_rx_mode,
 	.ndo_validate_addr	= eth_validate_addr,
 	.ndo_set_mac_address	= iavf_set_mac,
 	.ndo_change_mtu		= iavf_change_mtu,
-- 
2.52.0


  parent reply	other threads:[~2026-04-13 17:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 17:11 [PATCH net-next v7 00/15] net: sleepable ndo_set_rx_mode Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 01/15] net: add address list snapshot and reconciliation infrastructure Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 02/15] net: introduce ndo_set_rx_mode_async and netdev_rx_mode_work Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 03/15] net: cache snapshot entries for ndo_set_rx_mode_async Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 04/15] net: move promiscuity handling into netdev_rx_mode_work Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 05/15] fbnic: convert to ndo_set_rx_mode_async Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 06/15] mlx5: " Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 07/15] bnxt: " Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 08/15] bnxt: use snapshot in bnxt_cfg_rx_mode Stanislav Fomichev
2026-04-13 17:11 ` Stanislav Fomichev [this message]
2026-04-13 17:11 ` [PATCH net-next v7 10/15] netdevsim: convert to ndo_set_rx_mode_async Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 11/15] dummy: " Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 12/15] netkit: " Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 13/15] net: warn ops-locked drivers still using ndo_set_rx_mode Stanislav Fomichev
2026-04-13 17:11 ` [PATCH net-next v7 14/15] selftests: net: add team_bridge_macvlan rx_mode test Stanislav Fomichev
2026-04-13 18:09   ` Breno Leitao
2026-04-13 17:11 ` [PATCH net-next v7 15/15] selftests: net: use ip commands instead of teamd in team " Stanislav Fomichev
2026-04-13 18:45 ` [PATCH net-next v7 00/15] net: sleepable ndo_set_rx_mode Jakub Kicinski
2026-04-14  2:08 ` Jakub Kicinski
2026-04-14 19:24   ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260413171131.550126-10-sdf@fomichev.me \
    --to=sdf.kernel@gmail.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox