From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3101134750F for ; Mon, 13 Apr 2026 17:11:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776100302; cv=none; b=pvpMvHz767HrQnNu7g3fSjOZBO6I+u3gMEqimud6O7NT6Tccgzb4ugMvp7Zi3UK5NjQ/JtndCWmfTwzmB1/OTAVMrpABTMDlMxkzNmAMmUfmZUMmCRy7Bg7605M3XVG8pD8gJQHbSsVwJyj5Y48uQM19RdvLghmK8WymARDUea0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776100302; c=relaxed/simple; bh=Ha+loX0JVubvlhVDjMyc8KFLsBSp75jlVlO4LbRd2Nk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fzEE+9EV4Q+emKLigkc5T1ZBcqrVVsCKQ0Whzoi11vLh2zg6rewcVQCy3zE27WmlhE5HTd2scLsUxxHnk316qOVXPQhmKvfRhwPrwKa1Rcnwl8lMp/D3mv+zWt8dZHpW9ZMr+teSjouM0nM/4drcxqJ0iTvlxwRi/idxpEpUBDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=km3SR9wI; arc=none smtp.client-ip=209.85.210.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="km3SR9wI" Received: by mail-ot1-f68.google.com with SMTP id 46e09a7af769-7dc3d28e2f3so1900331a34.0 for ; Mon, 13 Apr 2026 10:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776100300; x=1776705100; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HtgGAyqS8DwTcDUuPNHQIODcc+hJGqRr3oaNkxkpAZ0=; b=km3SR9wIp9bQinYcSdi4jWzmqyWA1X9H2I+4Z5AxabM07yfiMGv74Tti4lbx5UGhZG fB+IqKA4KYTUMqSrO2wLXEMy1OyAKuRJlaSi1Ld2mfh9TaitrNDV2GdaedGZ304XqWjB 68N3CSUykjtFIVTn4i84ueILmUQqfC86APLQa63NCWkf9QxlfEVCJN4TKmLHo2iMeBt4 bpw1L7DHd6on0sjJaGH+/2f0vNCtOBlBeujLeLH2txZYHaqTmcoTCJuhWt58RPG2myzI aZ9zWqQnIpqmcWHZ5IQ9/7wwXpHopAOSpBmkROb1L75hyGk/Wi7LQFjMCoedu1ttjPWu tGbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776100300; x=1776705100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HtgGAyqS8DwTcDUuPNHQIODcc+hJGqRr3oaNkxkpAZ0=; b=Ji9IFXRQClyWPp3ZyQf5ClbubiRTA2BV6H2WJNwD/aUb1/dNoZgW1e6S7+62WAvrdE KtpEVLtbaFgs5cCp9GmOQLIMNvOz99txEm9xmn2HCTRAHOgw+hWqHtQ4pPFbuSb0a3HL bgHqs/BY4POytTcQJ9FH6WddF0zR0tnngAhAHSS/UIo4PfHFZGBC6zpT4JDHnBF3VCPL +8xtgjU7cH+xn5AP1qFAiAEDEMt8yxCDz826SLCP7TUEi875Te0FvTK+DFtrWUCO3nPp 4g7P+RGUuQMGFhUJH/ZbGibmo6SmnNp6S+5qzUz8o0x4UFyf2ujoNTxs7UCMZCpvNcMf ZZNg== X-Gm-Message-State: AOJu0YzRqNg9/6dI53RrmtIx+QVyMkyCG1jAIhq+HcijW10GZdVtNRPU m8Znhu8CBC9DKJ0rjoj+Bvn3OI+k+XWtrkQQYkLeBvY1WM//T3TgsNpiNTk1foCL X-Gm-Gg: AeBDiespYO2auHRTXX+OZR8QNtN58o5awaQhn+s5JkoKzs/xd35TGeoZC9yGIbZwHgD VvLYIR8Ix+3ecG0YRDo0OMM3poh1TQwSxY/xd3QeaFl8OCa2nhBYKBspN+CY0FpbAqwJDZWqTCW nUgK35unEfzIZmFMMV0+53vodGgF3J8ylgTs1a+YjoIgOc7Kancg9Rpa1fep3UcSc92kg0L/6ML +rqKXk3pQZL2tY3T3r9Hz4fCfNeQruZt+xY0H2W06R58z+/w4RCkHhSuOtyR3vvKOqQCf5P01Tu w8EUpcdORWyjraXuHXUcOj/UHryJoTa7y7K3R9nQzi1JAw6ihtXa2x0mOvKR1B4YwvCvhLk+4Ji IAmbJZWj11b080NhK4d3+i2tnAXi4CuPAjffK/6s2KTY+a6uLMWCLzUJBHICmuwQf/0HMU8fe9b ohhrCFOfZ54DAbUED/KA== X-Received: by 2002:a05:6830:411c:b0:7d7:ecf8:6b with SMTP id 46e09a7af769-7dc27c67914mr7370783a34.2.1776100300066; Mon, 13 Apr 2026 10:11:40 -0700 (PDT) Received: from localhost ([2a03:2880:12ff:72::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dc26904c22sm8601830a34.16.2026.04.13.10.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 10:11:39 -0700 (PDT) From: Stanislav Fomichev X-Google-Original-From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Michael Chan , Pavan Chebbi , Aleksandr Loktionov Subject: [PATCH net-next v7 07/15] bnxt: convert to ndo_set_rx_mode_async Date: Mon, 13 Apr 2026 10:11:23 -0700 Message-ID: <20260413171131.550126-8-sdf@fomichev.me> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260413171131.550126-1-sdf@fomichev.me> References: <20260413171131.550126-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert bnxt from ndo_set_rx_mode to ndo_set_rx_mode_async. bnxt_set_rx_mode, bnxt_mc_list_updated and bnxt_uc_list_updated now take explicit uc/mc list parameters and iterate with netdev_hw_addr_list_for_each instead of netdev_for_each_{uc,mc}_addr. The bnxt_cfg_rx_mode internal caller passes the real lists under netif_addr_lock_bh. BNXT_RX_MASK_SP_EVENT is still used here, next patch converts to the direct call. Cc: Michael Chan Cc: Pavan Chebbi Reviewed-by: Michael Chan Reviewed-by: Aleksandr Loktionov Signed-off-by: Stanislav Fomichev --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 31 +++++++++++++---------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 2715632115a5..61d4a9911413 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -11132,7 +11132,8 @@ static int bnxt_setup_nitroa0_vnic(struct bnxt *bp) } static int bnxt_cfg_rx_mode(struct bnxt *); -static bool bnxt_mc_list_updated(struct bnxt *, u32 *); +static bool bnxt_mc_list_updated(struct bnxt *, u32 *, + const struct netdev_hw_addr_list *); static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init) { @@ -11222,7 +11223,7 @@ static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init) } else if (bp->dev->flags & IFF_MULTICAST) { u32 mask = 0; - bnxt_mc_list_updated(bp, &mask); + bnxt_mc_list_updated(bp, &mask, &bp->dev->mc); vnic->rx_mask |= mask; } @@ -13620,17 +13621,17 @@ void bnxt_get_ring_drv_stats(struct bnxt *bp, bnxt_get_one_ring_drv_stats(bp, stats, &bp->bnapi[i]->cp_ring); } -static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask) +static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask, + const struct netdev_hw_addr_list *mc) { struct bnxt_vnic_info *vnic = &bp->vnic_info[BNXT_VNIC_DEFAULT]; - struct net_device *dev = bp->dev; struct netdev_hw_addr *ha; u8 *haddr; int mc_count = 0; bool update = false; int off = 0; - netdev_for_each_mc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, mc) { if (mc_count >= BNXT_MAX_MC_ADDRS) { *rx_mask |= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count = 0; @@ -13654,17 +13655,17 @@ static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask) return update; } -static bool bnxt_uc_list_updated(struct bnxt *bp) +static bool bnxt_uc_list_updated(struct bnxt *bp, + const struct netdev_hw_addr_list *uc) { - struct net_device *dev = bp->dev; struct bnxt_vnic_info *vnic = &bp->vnic_info[BNXT_VNIC_DEFAULT]; struct netdev_hw_addr *ha; int off = 0; - if (netdev_uc_count(dev) != (vnic->uc_filter_count - 1)) + if (netdev_hw_addr_list_count(uc) != (vnic->uc_filter_count - 1)) return true; - netdev_for_each_uc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, uc) { if (!ether_addr_equal(ha->addr, vnic->uc_list + off)) return true; @@ -13673,7 +13674,9 @@ static bool bnxt_uc_list_updated(struct bnxt *bp) return false; } -static void bnxt_set_rx_mode(struct net_device *dev) +static void bnxt_set_rx_mode(struct net_device *dev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { struct bnxt *bp = netdev_priv(dev); struct bnxt_vnic_info *vnic; @@ -13694,7 +13697,7 @@ static void bnxt_set_rx_mode(struct net_device *dev) if (dev->flags & IFF_PROMISC) mask |= CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS; - uc_update = bnxt_uc_list_updated(bp); + uc_update = bnxt_uc_list_updated(bp, uc); if (dev->flags & IFF_BROADCAST) mask |= CFA_L2_SET_RX_MASK_REQ_MASK_BCAST; @@ -13702,7 +13705,7 @@ static void bnxt_set_rx_mode(struct net_device *dev) mask |= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count = 0; } else if (dev->flags & IFF_MULTICAST) { - mc_update = bnxt_mc_list_updated(bp, &mask); + mc_update = bnxt_mc_list_updated(bp, &mask, mc); } if (mask != vnic->rx_mask || uc_update || mc_update) { @@ -13721,7 +13724,7 @@ static int bnxt_cfg_rx_mode(struct bnxt *bp) bool uc_update; netif_addr_lock_bh(dev); - uc_update = bnxt_uc_list_updated(bp); + uc_update = bnxt_uc_list_updated(bp, &dev->uc); netif_addr_unlock_bh(dev); if (!uc_update) @@ -15986,7 +15989,7 @@ static const struct net_device_ops bnxt_netdev_ops = { .ndo_start_xmit = bnxt_start_xmit, .ndo_stop = bnxt_close, .ndo_get_stats64 = bnxt_get_stats64, - .ndo_set_rx_mode = bnxt_set_rx_mode, + .ndo_set_rx_mode_async = bnxt_set_rx_mode, .ndo_eth_ioctl = bnxt_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = bnxt_change_mac_addr, -- 2.52.0