Re: [PATCH net-next v2 09/14] net: macb: change caps helpers signatures

Théo Lebrun
2026-04-15T13:58:48Z

Hello Jakub,

On Tue Apr 14, 2026 at 2:47 AM CEST, Jakub Kicinski wrote:
> On Fri, 10 Apr 2026 21:51:57 +0200 Théo Lebrun wrote:
>> For parallel MACB context to start become a reality, many functions will
>> soon not have access to `struct macb *bp`. Those will still have access
>> to caps through ctx->info->caps.
>>
>> Change all caps helpers signatures, from taking `struct macb *bp` to
>> taking `u32 caps`.
>
> Subjectively I feel like this is a slight loss of type safety.
> Someone may pass the wrong u32 and compiler will not help?

Agreed. We can solve that using our new `struct macb` subset called
`struct macb_info`. It contains the caps and is available from both bp
and ctx.

So it will be one of:

macb_is_gem(bp->info)
macb_is_gem(ctx->info)

No more obscure u32 argument.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering