From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECB5D3B38BD for ; Tue, 14 Apr 2026 09:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776158191; cv=none; b=NkPIkt4/5i8YFYFPNHBjgPufYTlUUkaF0y4ALOsNSejCklFEvGKkWxxyzBDwcsnJKhQcvYe77qNi5a+A4wvifzHik90kA17AL48xnxFMZX86u9d575WQ5gN68w7/lwEdkLHhVZrWoEB0Ybzb0I7EJ9m56vXrtwQiA/QkhKwG6xI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776158191; c=relaxed/simple; bh=XdU3+uXpTQHIkDhg40fCylMNlGQWcd1ytCGfIDJGre4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rBjybuLQ1jxI4lRYQtBW7+F1hgogYTmiwgHqTt0nwidecFCd9nR3glPT4Ij3N8efHFWYN3bsquh3A22nBZlqCJqDWOHpTz+S9dsWuA7Jsvxrvm1k3x2z9RjRRyaEkow/ChzN20EClQBcvR/sC7azlm6+0ctvNxG6lMAOlRuEv5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NwGVb1Pj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NwGVb1Pj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E78DC2BCB5; Tue, 14 Apr 2026 09:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776158190; bh=XdU3+uXpTQHIkDhg40fCylMNlGQWcd1ytCGfIDJGre4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NwGVb1PjURl89jj6D0za1hOgBuYJOHOhbHYJAVHRMEPiRxT7rNp/VoQL2DttNvyVV AzP1cQje3+dbP1GSuMYiT/qXdkSiHReAtUWQzwSz9biONaTrzE8e2VoWalqKGtfHuQ dlcS9GVEF4e5kSSiS9U0JZAUlz5EYr5U/8A2mmDf3CGN+yLvDj+8xi0yfQ8mzyiyMH J05Iy1sPTEcHKdB9MAYsIFEEsHdDryjrfntuB8YYXZaJx8awahZlsQUX/U8GvGs4lK 1/FybHYNiGtX+zI0WbFdwICFc1lZj0OVmPrCH+lNGvZxV335gOXO0jGW9usRS1dxXz /6qXrLknPeprw== Date: Tue, 14 Apr 2026 10:16:27 +0100 From: Simon Horman To: Aleksandr Loktionov Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, Jacob Keller Subject: Re: [PATCH iwl-next 4/10] ice: reorder ice_flash_info fields to eliminate padding Message-ID: <20260414091627.GX469338@kernel.org> References: <20260410074921.1254213-1-aleksandr.loktionov@intel.com> <20260410074921.1254213-5-aleksandr.loktionov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260410074921.1254213-5-aleksandr.loktionov@intel.com> On Fri, Apr 10, 2026 at 09:49:15AM +0200, Aleksandr Loktionov wrote: > From: Jacob Keller > > The ice_flash_info structure has a u16 sr_words field before a u32 > flash_size value. This creates a 2-byte hole as well as 3 bytes of > padding at the end of the structure due to the blank_nvm_mode bitfield. > > Re-order the structure to place flash_size first, which gives a better > layout and reduces padding. > > Signed-off-by: Jacob Keller > Signed-off-by: Aleksandr Loktionov Reviewed-by: Simon Horman