From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB34A395256 for ; Tue, 14 Apr 2026 09:38:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776159536; cv=none; b=Ej+mxWTGS0A1fM26ERjGxd7MGT0tl2X49swPLq9A4vaCXYiym/8WPF+0eYh0k7tyMNxNQr5JJbzZtO/xJmiR40Te/noNHI3kEbgnGBjFUUcpCvTM7+P136kZRNBp7BACqSntCBIZd6SPLFHcT8ojJiuHgwoxSlNTMExSDLox0h4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776159536; c=relaxed/simple; bh=V0Twrt94RMQHR87PARXsvnrB4lobZx+97fuAAeeHGfQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X+OuBEAP36u/ijjzoNO8F1t4sNvyQm3RaBtUpoRo4xj+BvVqXsZz9h/tCVp6s1pV0i7k4Mgbb4VCNr98I3kaZhsrmjMgDV9lWlb3BNRgEPJzxT0tTHtwE4Ez0amZXTjmjfLp9MrpfbeiAMhbqSuLfGkxYfyFbEaJXNCNGhz90/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gTdHq9mb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gTdHq9mb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5A32C2BCB4; Tue, 14 Apr 2026 09:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776159535; bh=V0Twrt94RMQHR87PARXsvnrB4lobZx+97fuAAeeHGfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gTdHq9mbrBoCjTJQZ7S5TZYU/IpPVc6NmfIQcdb2pGBVtfNAeBxJUq3ee44Q2JUaY tXrQS7kEa+DLy4KJ94kICM2Kf5WBqDVJdd9EF2js/0iqld7WrStkcuhOYrpdKFS+k6 pfNf+tvAsS9CMMFR+ilvENDVwFx8Z+ERLlXpqb1UF4ZQVXynmQj/b/oXJDYaxgxWoM V24+no4uU0uTmuTMq3yXeHUVHz27zFy2m8vabdYusciJMXYaaTqS4mK+BtOvGXnRa5 LeMp1J14LbYTZ04i+uZTAMPa7L6bfNSh0JnKTO5gI4wJQbRAF785U/zgMAYGBgZKvk kWa5cRbllyzmA== Date: Tue, 14 Apr 2026 10:38:52 +0100 From: Simon Horman To: Aleksandr Loktionov Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org Subject: Re: [PATCH iwl-next 8/10] ice: move ice_phy_get_speed_eth56g() from ice_ptp_hw.c to ice_common.c Message-ID: <20260414093852.GA469338@kernel.org> References: <20260410074921.1254213-1-aleksandr.loktionov@intel.com> <20260410074921.1254213-9-aleksandr.loktionov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260410074921.1254213-9-aleksandr.loktionov@intel.com> On Fri, Apr 10, 2026 at 09:49:19AM +0200, Aleksandr Loktionov wrote: > ice_phy_get_speed_eth56g() is currently a file-local (static) > helper in ice_ptp_hw.c. Future users outside that compilation > unit require access to it. FWIIW, I think it would be slightly better if this patch was accompanied by such a user. > > Move the function to ice_common.c, add a declaration in > ice_common.h, and relocate the enum ice_eth56g_link_spd from > ice_ptp_hw.h to ice_type.h so it is visible to callers of the > new exported function. > > Suggested-by: Karol Kolacinski > Signed-off-by: Aleksandr Loktionov Reviewed-by: Simon Horman