From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76C5434EF0C for ; Wed, 15 Apr 2026 05:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776232695; cv=none; b=mn2ycfGNwo3UiNFoHvaDf83dwz9jPiX4qNIr5O4/xIehT2MqbXhS7m5gXb4AaCXpU3LcikppuuKecvzjBaKa7/cNc4XRQXncqfU030w7CkaG0UuT+8HlempG6I1falnaUpVLlWY8dnMiV/Xojmhw5++iW18mEGuMEgAgan/3E6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776232695; c=relaxed/simple; bh=YJk7HFFywOAvglX29zYP4iiLAIOHUmcE1zceWMyjEtA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rdplr/Byilb6LOr7vddAOLvuzhUx+QbpuHqOG4nz13XaZ6FEi4MA/K84ryNB0BJ5euy1yuoK7qGOiMniR0iWtUEY1d2XrqcaB4++AWxhmP3RF/AK/5r+mL2nWvP8z8LH9al0SBUnaPwuo/HyGKkr0lrQEoRlYqA437zbDtRM9o4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TlW0yCkL; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TlW0yCkL" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-79a7109f568so75158417b3.1 for ; Tue, 14 Apr 2026 22:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776232693; x=1776837493; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=J7Qu+iufcZ9jYk8S+wuxRjUaOgj3R8vJUSvzid2gdM4=; b=TlW0yCkLIUBrvRuZTGswlI+GJHBMFFyVA1SRcXn5BMqV9Ujb5FhwfPEBoGmxCR3hL2 CdF3kooUryWPabs6wKdosOsBxrtCE/SHio/Ii8HtuUCZ6f2fE8c0RDM/Yo9zoNIR8nj2 6J4YDpN9TZfWhspbIOohqeDLPw4aHcwBv3uS4WZ96GhkdsqtCTQr4OR/PXvZXPpoFkbB e4NgD0w08T7n76l5FEOK53jFB4lYGJp0rLQiYW+UaFk9A1q24Xc9GWDRZwIyy0fcmaIm XEQ0b718Xvn4SYcubqmyq4A6lk703CF/FEtdUNMmHJuIIERo3wYNFpLCyM0QV6528Gvn CDOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776232693; x=1776837493; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J7Qu+iufcZ9jYk8S+wuxRjUaOgj3R8vJUSvzid2gdM4=; b=URV8J3VzB7SGMiqq3a8L9t3uxJBqxr+DveWtQeJBrirSTk2xKEBRZYCgy2ivPf5r05 hUCvQQVVxSDbaOkzX0IwpbxMAcwuys+aBtqlHvKXoRWdk98FjCIkY+trKU1lt27/pFfJ MhfF2Bhg7nhL8F3sqH9+iXQofcefVAp7Pdj3i+lduKyIs6JegVgst85aY82cGWDlCUSl 7MZHlIIJb++zMC3kWYc0pNilxG8TuUvlzoZ3ukvQn1o9HHlR7IWZHxodg3AEsmJLGUjF amDdbap7Yqx2ESoM36NIrjqGTrsTVkuD4d4FFdcqeVRZ2HZr456GsrG7PkLecF+YZWkW nd/g== X-Gm-Message-State: AOJu0Ywvjl3ptBPq0Om3IbGU9gIEyM59CAl+qjlCd97h3vHCzaUvcMwQ o/kkWhk1tVDpW3psnuOUt2gYzG4mLd+BBshy8paHZ0LDyOLt0TcSJDmW6QqWfAfdh9THVQ== X-Gm-Gg: AeBDievbUKM0Oz6G9vSv7Spj1y93Q/nb0MKNS/2G4ePH5R1I/YlBsIhevOlUXusPWko /dGSkCO9NXjP01PYvD9adD+9lR5ABh7++mA5/gUc7kXFiqg6KzhsNuZRqJjlMTlN929DscsJ6Qe sDsKfyq9kRJfgif0YnjO67UxzRF9M0ktpeIn2x/utbMvqAKvEi1MiVHwYkOrImtYzV4jhAG5/JY ghYvpVYOPkJr8SkaxOVtZXXJ+TDO8SOIQLFQk3ZbcMULgY1dfPXsJG6Y60P3Xa8FKa//Lz2AAjb nijLrJ95g2hVrEYL2jLiYr1EZgT+JXX9DJDpBaLoBJYa/HhFY5N/rLieEp4OPjvOWHZgNdQNzYB TNYV+iI2uHDi+xsZea0NSxh4Qyk4W4K+3HIo3xuORvzfhMH/1q2KGxLNTVZlSAOpydm/xsHDK1V 2UpTNoPcRs8kCrW6G4oW7D+8KlsMB4boglDRgb8j6BwRjSRJP5r0nBCOx2UjvGFKOO1ZoD6i1Wp QwzP4vqUfyJ3AJ8XqbD1tW4Dy1uu5Q2Ur6t9Gs= X-Received: by 2002:a05:690c:85:b0:7a2:f14d:5a1 with SMTP id 00721157ae682-7af7252df6emr209920057b3.49.1776232693315; Tue, 14 Apr 2026 22:58:13 -0700 (PDT) Received: from TDC4045031631.e0cglfehwr0e5gttmepj3hi3hf.ux.internal.cloudapp.net ([20.63.37.123]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b768d387eesm4440177b3.29.2026.04.14.22.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 22:58:12 -0700 (PDT) From: Ashutosh Desai To: netdev@vger.kernel.org Cc: linux-hams@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Ashutosh Desai Subject: [PATCH v3 net] rose: fix OOB reads on short CLEAR REQUEST frames Date: Wed, 15 Apr 2026 05:57:56 +0000 Message-Id: <20260415055756.3825584-1-ashutoshdesai993@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rose_process_rx_frame() calls rose_decode() which reads skb->data[2] without any prior length check. For CLEAR REQUEST frames the state machines then read skb->data[3] and skb->data[4] as the cause and diagnostic bytes. A crafted 3-byte ROSE CLEAR REQUEST frame passes the minimum length gate in rose_route_frame() and reaches rose_process_rx_frame(), where rose_decode() reads one byte past the header and the state machines read two bytes past the valid buffer. A remote peer can exploit this to leak kernel memory contents or trigger a kernel panic. Add a pskb_may_pull(skb, 3) check before rose_decode() to cover its skb->data[2] access, and a pskb_may_pull(skb, 5) check afterwards for the CLEAR REQUEST path to cover the cause and diagnostic reads. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Ashutosh Desai --- V2 -> V3: drop kfree_skb() calls to fix double-free; add end-user visible symptom to commit log; use [net] subject prefix V1 -> V2: switch skb->len check to pskb_may_pull; add pskb_may_pull(skb, 3) before rose_decode() to cover its skb->data[2] access v2: https://lore.kernel.org/netdev/177614667427.3606651.8700070406932922261@gmail.com/ v1: https://lore.kernel.org/netdev/20260409013246.2051746-1-ashutoshdesai993@gmail.com/ net/rose/rose_in.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/rose/rose_in.c b/net/rose/rose_in.c index 0276b393f0e5..8e60dc562b4a 100644 --- a/net/rose/rose_in.c +++ b/net/rose/rose_in.c @@ -269,8 +269,14 @@ int rose_process_rx_frame(struct sock *sk, struct sk_buff *skb) if (rose->state == ROSE_STATE_0) return 0; + if (!pskb_may_pull(skb, 3)) + return 0; + frametype = rose_decode(skb, &ns, &nr, &q, &d, &m); + if (frametype == ROSE_CLEAR_REQUEST && !pskb_may_pull(skb, 5)) + return 0; + switch (rose->state) { case ROSE_STATE_1: queued = rose_state1_machine(sk, skb, frametype); -- 2.34.1