From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zebra.wilibox.com (zebra.wilibox.com [62.77.155.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76D6E3914EE; Wed, 15 Apr 2026 06:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.77.155.212 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776235506; cv=none; b=CW4dIRNnhEJAKWvK6nn6+B3e2gFIjS2vnB8H9c/ZZb0KsW3A/gTcdq+I/P26/kNkj+ypyh9N61OD9rfj54T+9Mt6Ji2t5hjrSL+JDckz7LVOgILHxn8lelbq7rj7rtwf1Bf9KSs3A+cy0IjelAIDnuMBDcfL62iKnlPc1Pf5Ixo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776235506; c=relaxed/simple; bh=7WTEyNFffV6w+pCAcVJLy3VQLEuiEkAU9UhKwjIbB94=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DLuPGNeKGsXau4HWHWBTfTUZl9+tnSyAixRkJSGf9iYqss/8kYvEESPOs8F1TFhdXT6BETGDs9PV1+kKxGEGWKvR1MuG8zzp4nUTLf4gHHp6jxzWWNrxjh/jWzm+W6URz7+uPumG5unN9tL/AnpjG4XewupqQAGQNaXV5VvT3mA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=iconn-networks.com; spf=pass smtp.mailfrom=iconn-networks.com; dkim=pass (2048-bit key) header.d=iconn-networks.com header.i=@iconn-networks.com header.b=LQ8vHv9z; arc=none smtp.client-ip=62.77.155.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=iconn-networks.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iconn-networks.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iconn-networks.com header.i=@iconn-networks.com header.b="LQ8vHv9z" Received: from debian (unknown [81.7.79.211]) (Authenticated sender: ernestas.k@iconn-networks.com) by zebra.wilibox.com (Postfix) with ESMTPSA id 3F08616B45F; Wed, 15 Apr 2026 09:35:39 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iconn-networks.com; s=default; t=1776234939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=L05OlKW4YM2KyYAU8naVj9tMRq09rF1jmo/4V29Em5Y=; b=LQ8vHv9zseyWnC4CdOgzlUazV2Q2265npKJ4RnBdQswExJAbJDFl9yo9hen6MaTLmjc2Gk B9HjzLZwi0V/PD58Fk4tjay++VR5fC3F/xtfqzmyCl9CVSQCvYe/ZXGUhEH3VbdI0AUEce M0lmBgp/eMu3pMuEtS4qeKc0UXiRaYfBvmJe1Ke0UMzvqWwJtZZRr3IZIvZkoPpDkquQdy ooHUQaz9iEP9AajI1XXEeyacBwFPYAfUCnyz+IVh+F8CiGSFLvJ+9lGBaKKwDWWJR8YY+Q 5lsjlBL/1JwvxjXGRf81H8U1zzGXN8PdS6tf/mSAKcNJS6M9K30J71khSxVlpQ== Authentication-Results: zebra.wilibox.com; auth=pass smtp.auth=ernestas.k@iconn-networks.com smtp.mailfrom=ernestas.k@iconn-networks.com From: Ernestas Kulik To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Ernestas Kulik Subject: [PATCH] llc: Return -EINPROGRESS from llc_ui_connect() Date: Wed, 15 Apr 2026 09:34:57 +0300 Message-ID: <20260415063457.1008868-1-ernestas.k@iconn-networks.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Given a zero sk_sndtimeo, llc_ui_connect() skips waiting for state change and returns 0, confusing userspace applications that will assume the socket is connected, making e.g. getpeername() calls error out. Set rc to -EINPROGRESS before considering blocking, akin to AF_INET sockets. Signed-off-by: Ernestas Kulik --- net/llc/af_llc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index 59d593bb5d18..9317d092ba84 100644 --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -515,10 +515,12 @@ static int llc_ui_connect(struct socket *sock, struct sockaddr_unsized *uaddr, sock->state = SS_UNCONNECTED; sk->sk_state = TCP_CLOSE; goto out; } + rc = -EINPROGRESS; + if (sk->sk_state == TCP_SYN_SENT) { const long timeo = sock_sndtimeo(sk, flags & O_NONBLOCK); if (!timeo || !llc_ui_wait_for_conn(sk, timeo)) goto out; -- 2.53.0