From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 040203314B9 for ; Wed, 15 Apr 2026 09:16:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776244601; cv=none; b=XplI3wTjtUmRwSBRQI+Ee1zJCGjmz8i+Zsu6QvXd+HFbwMYusc35J6p8wyL78cndOU7LDZDXz56jDPRM7QiPFZl/dyfrzPmkkW5I9tbcyA0CnZ9rSLrSj7Sf3F470oOzR4IWC2iSfaJzWzwy9Tf9osmSdLOU9mdAE+SyPWiNQHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776244601; c=relaxed/simple; bh=j4lFk/+qPXA6eEIINMAlpfhUyBqIoNeTBMMGZLESU/4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WTy2beZbhcB8spvsaMDGDl6RHf/617dB5eP+bjoQYqQ40tNRDP9bL+cCclj9crqdlfzM5eCvEMkiqtXP2nULoSJinHDc++YV9+hOLmtJ9NSxBMxqJjDF58myVJqUc2FLkeX5z58wA7MGAaYpd9SFf5WsX9mZFzyQjpJCdVJO2jM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WPd509RE; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WPd509RE" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776244588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jm2OTrB1IC4L+3C9wJ4DJw6F0AdGiQYFZiRAbNrcD70=; b=WPd509RE6lp2b+OTbhpEbapnpR6N34LbMIueBdCgb89IWwy8E36ChS4JYQznXoYCxzK5P9 CX/JFhBZhiopRUiFRhRodcYoKPgpsYrWClgOxKD9zJpsGwL8SbVJKGd/dl1SXhGD6z1Ldb ZlIyXqUpwHGiNqSneD9lsRycMMMhHMc= From: Qingfang Deng To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Qingfang Deng , Kees Cook , Guillaume Nault , Eric Woudstra , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Paul Mackerras , linux-ppp@vger.kernel.org, Jaco Kroon , James Carlson , Dianne Skoll , Denys Fedoryshchenko Subject: [RFC PATCH net-next] pppoe: drop getsockname() syscall Date: Wed, 15 Apr 2026 17:16:12 +0800 Message-ID: <20260415091614.266198-1-qingfang.deng@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The getsockname syscall is not used by pppd. It also has two flaws: 1. It does not hold the socket lock, so if the struct is being changed in pppoe_connect() simultaneously, it may see partial updates. 2. If the lower network device is renamed, this operation still returns the original name. Given it is unused and buggy, remove the syscall. Signed-off-by: Qingfang Deng --- Note: sent as RFC, since net-next is closed. drivers/net/ppp/pppoe.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c index d546a7af0d54..0d64a16715e2 100644 --- a/drivers/net/ppp/pppoe.c +++ b/drivers/net/ppp/pppoe.c @@ -688,22 +688,6 @@ static int pppoe_connect(struct socket *sock, struct sockaddr_unsized *uservaddr goto end; } -static int pppoe_getname(struct socket *sock, struct sockaddr *uaddr, - int peer) -{ - int len = sizeof(struct sockaddr_pppox); - struct sockaddr_pppox sp; - - sp.sa_family = AF_PPPOX; - sp.sa_protocol = PX_PROTO_OE; - memcpy(&sp.sa_addr.pppoe, &pppox_sk(sock->sk)->pppoe_pa, - sizeof(struct pppoe_addr)); - - memcpy(uaddr, &sp, len); - - return len; -} - static int pppoe_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) { @@ -1049,7 +1033,7 @@ static const struct proto_ops pppoe_ops = { .connect = pppoe_connect, .socketpair = sock_no_socketpair, .accept = sock_no_accept, - .getname = pppoe_getname, + .getname = sock_no_getname, .poll = datagram_poll, .listen = sock_no_listen, .shutdown = sock_no_shutdown, -- 2.43.0