From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3029422538F for ; Wed, 15 Apr 2026 13:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776259592; cv=none; b=mn/qn36UB9upvG43ERni5yH4NX65K9Os1Xgm1gel74apEJZfo52PFfIACOWuROzJEO1gQtGahZq8CcXlmDnDPvScLILRb0lLG1F83fqhah09X2foHjzTYf0dmoPPjn175vAhYSvgHlsHq0yvO9V8fY6iouF1SErMYbTcBiFY1wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776259592; c=relaxed/simple; bh=DENY9p9CKwihwW347KzzpeYMyVvwNcN5J3ZSHZcwozU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=czF/uKUiP20BMfBuMofCq+sgFaOzHnzUe6uffr94yZxz//wjXDndJp138NNc2F/Kk4qJjY+O5tY0SJ0Ti48RMzDi9ntnjuEPdh5kMh88LQ7547zAJbdUigLJpy+4m5hnAsHvDAms77PzCVbc3RcTfj2w0s717Inp+iytArc/DpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bf7vnJgp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bf7vnJgp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B309EC19424; Wed, 15 Apr 2026 13:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776259592; bh=DENY9p9CKwihwW347KzzpeYMyVvwNcN5J3ZSHZcwozU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bf7vnJgpzCsbPUH8WG8aESx8Oi+xPqzTkKQaUX7Pc5u2zei199VgIVJlfLq5cU4v9 TGajpwWHwS8L9OyXYRva8Iv/nJm3OJj1vLNpCyfTKA/MnGfZUAvSVIQ/irb6M1vPGI UZ/oAZ0211kBLmKkwVazf18jzrnthWWp5eGlXWWilmllIaKghpfjLJ4XiGSFjLTDMU zeP86rJ4KfySFbfchl5zVQHbNaci1v7fIEwY8mEgOl0inXbgomqSDYoiZZ0f2WqjEY HxNJrENRJAV4FdDNtfNQpLJGIrIFUlXbr2IGm7IpEY4juAuAOVw0Met80TpFdcYMFQ z6Q+AO+uypEtQ== From: Simon Horman To: aleksandr.loktionov@intel.com Cc: 'Simon Horman' , intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, kiran.patil@intel.com Subject: Re: [PATCH iwl-net 2/5] iavf: fix error path in iavf_request_misc_irq Date: Wed, 15 Apr 2026 14:26:11 +0100 Message-ID: <20260415132610.803526-2-horms@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413073035.4082204-3-aleksandr.loktionov@intel.com> References: <20260413073035.4082204-3-aleksandr.loktionov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: 'Simon Horman' This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. Full review at: https://sashiko.dev --- iavf: fix error path in iavf_request_misc_irq This patch drops the free_irq() call from the error path of iavf_request_misc_irq() when request_irq() fails. This is intended to prevent a kernel warning when freeing an unrequested vector. > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c > index dad001abc9086..ab5f5adc2d3c2 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > @@ -587,7 +587,6 @@ static int iavf_request_misc_irq(struct iavf_adapter *adapter) > dev_err(&adapter->pdev->dev, > "request_irq for %s failed: %d\n", > adapter->misc_vector_name, err); > - free_irq(adapter->msix_entries[0].vector, netdev); Does this patch completely fix the warning? If request_irq() fails, iavf_request_misc_irq() returns an error but leaves adapter->msix_entries allocated. In caller error handling paths like iavf_disable_vf() which clean up after a failure, iavf_free_misc_irq() is called: static void iavf_free_misc_irq(struct iavf_adapter *adapter) { struct net_device *netdev = adapter->netdev; if (!adapter->msix_entries) return; free_irq(adapter->msix_entries[0].vector, netdev); } Since adapter->msix_entries is still allocated, the check passes and free_irq() is called on the unrequested vector anyway, triggering the exact same warning. Does the driver need to explicitly track whether the IRQ was successfully requested? > } > return err; > }