From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FA62386428; Wed, 15 Apr 2026 23:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776294640; cv=none; b=jPJSEfSJs+vwjK+Z+MasOzM/P7FT+yjX+i87QwhRf++MJiZUvtb+Z6DckkxAMfBiEkGNcdaYY3RM11Vy/SKBLrzbyMGMWRflDMKjGD+XzVAaJ3ydfpo394v/GGr1vxDkvUTah67peGsLO0F/BdM6uHq9crfir4mUu83PlRV+GBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776294640; c=relaxed/simple; bh=1vX5Nf8nVSLCHfIZmp0Dp274peJGW6rXdzrkcnJj11k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sJcCBtmuIpboRCSqEHVhvqwAZMVHMC9qY770L0+pgkL3zxIIdRiFKSkPyfmnzdClv8zIO5TdtIDybW3hBtkCaIxKF4CWv1NUdV9Y3JpTzrB1wf5otL4vXlUXYv6pXFTj+z/Vi6n1vayi1P32FWQVKIyoJk5f30/mDvtS0TtkJtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=Pd8lBd43; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="Pd8lBd43" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 50944113F5D; Thu, 16 Apr 2026 01:10:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1776294630; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=lv+bx+kmxOmu38ISk0zfCOIzdtCopAFmqK83omwzikQ=; b=Pd8lBd430kyqw3v9Ow4eyH0WLz/WUTfmg+EdsTKQPFbBhmCKJCVqEck6/mBHXxW0NIpDIj QU+MRymb/Es1vY3GhGIWBEyEDsMtGZWBRHIdo4xpEGkrv2c/9xP4CoxOgRlEvIC6RURfJE 1JL3/ZaolIW7oHKfrGNMJ4TZiNDXODYZY8oQ0x94mrKU70RVjMvbiqtz5RK/LrLAOrsBPV xXBydYxWA4flSJXDaBtC332gEknzQJvdQRoEStWKgMeSfNKM0i75nxC3jAix6qkwkLD1pB ZdlnlZPblGGN5vyEK5lYjVdt82iYCqITa3Zei28kE7cdU5tDRdJdqq0yHrEC4Q== From: Marek Vasut To: netdev@vger.kernel.org Cc: Marek Vasut , Sebastian Andrzej Siewior , stable@vger.kernel.org, "David S. Miller" , Andrew Lunn , Eric Dumazet , Jakub Kicinski , Nicolai Buchwitz , Paolo Abeni , Ronald Wahl , Yicong Hui , linux-kernel@vger.kernel.org Subject: [net,PATCH v4 2/2] net: ks8851: Avoid excess softirq scheduling Date: Thu, 16 Apr 2026 01:09:45 +0200 Message-ID: <20260415231020.455298-2-marex@nabladev.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415231020.455298-1-marex@nabladev.com> References: <20260415231020.455298-1-marex@nabladev.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 The code injects a packet into netif_rx() repeatedly, which will add it to its internal NAPI and schedule a softirq, and process it. It is more efficient to queue multiple packets and process them all at the local_bh_enable() time. Reviewed-by: Sebastian Andrzej Siewior Fixes: e0863634bf9f ("net: ks8851: Queue RX packets in IRQ handler instead of disabling BHs") Cc: stable@vger.kernel.org Signed-off-by: Marek Vasut --- Cc: "David S. Miller" Cc: Andrew Lunn Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Nicolai Buchwitz Cc: Paolo Abeni Cc: Ronald Wahl Cc: Sebastian Andrzej Siewior Cc: Yicong Hui Cc: linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org --- V3: New patch V4: Add RB from Sebastian --- drivers/net/ethernet/micrel/ks8851_common.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/micrel/ks8851_common.c b/drivers/net/ethernet/micrel/ks8851_common.c index 6c375647b24de..4afbb40bc0e4a 100644 --- a/drivers/net/ethernet/micrel/ks8851_common.c +++ b/drivers/net/ethernet/micrel/ks8851_common.c @@ -373,9 +373,12 @@ static irqreturn_t ks8851_irq(int irq, void *_ks) if (status & IRQ_LCI) mii_check_link(&ks->mii); - if (status & IRQ_RXI) + if (status & IRQ_RXI) { + local_bh_disable(); while ((skb = __skb_dequeue(&rxq))) netif_rx(skb); + local_bh_enable(); + } return IRQ_HANDLED; } -- 2.53.0