From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34CCE34A79D for ; Thu, 16 Apr 2026 18:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776365841; cv=none; b=IIgNXGGI/m6CYUBV31+TfNwYyuXk6q3CZMd/iCpe4xSxiWdSSmdcVEnGFcdznxwx7BAnaIv6GV4rIlxQFOQ79+8i7yH+ohSxTJS6MjyWi7O2pPYQwyKTrW4oQkQgmt6PJxrtyy9+JbhMEt82/L9qRPL/E3ZIzEMmeF1bA4rRCcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776365841; c=relaxed/simple; bh=w834SvXjmC+fYhuPlm8ZRQWYXnO/e/tM1C61oQJ2qho=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j49WuQku624Nt1/q/qqdZ2SbkxUdA4ZmXA72p6vMqRz3Do/bV4rDS3SiTeHuwZ85+p7zTEcMKj1aT1obHkpZGeQbaS/kK4X012gIgit+7RqG7ja89Xxj839z3o+xq1/psZdX0aEoOn1OnEYCrTbaBy6k9rKso6D0bvEj9b220bU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qbzl5kUW; arc=none smtp.client-ip=209.85.210.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qbzl5kUW" Received: by mail-ot1-f66.google.com with SMTP id 46e09a7af769-7d7fdb922a5so6734503a34.3 for ; Thu, 16 Apr 2026 11:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776365839; x=1776970639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MpcQn7YIwPgLJjXWEcJlubBUKnmYI97pYatrgEKDY/M=; b=qbzl5kUW8YcZ6NXKSZYbVm75dCcg2WF2WT9mavMl1+IS3qgnPGKheqWzaP0vFwDGDN U6blBIDzRaV9qrwLmPYZjX68c7uLfSlaT0oL26+GhFMM0urRXJ7zjCpUqPSDOIx/4phY FS+gsqUdfKGEfnDgLJmVVFlKZc4ullSan5Y2I/qkMmuIxl8p7MoTYBp8ieCletY8eiF+ vPWadkPggYJ9s38pZNpADsNZAScHUfxH1oX6bhvTRpEmymzCuYklzHgZSdvwHUm1HjU1 bM8eQ75jFl8LD/0KJUL87O6A8qatP4IQD17hHE+uvs/uS+D8SOEhVwQegRRAO6ev/kBt /jaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776365839; x=1776970639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MpcQn7YIwPgLJjXWEcJlubBUKnmYI97pYatrgEKDY/M=; b=CyAaNXjVRd3JNTDCI+UdLuNel0wHGEafJRMtFWBfgJxRK2dF9VIK7L9OmF8vA4d8I3 3BkRwQxjxOeNvHrshHLiywl7oulzrwiAFJwSpxdYDxHC7HaYUgAkOmGfi+ZPdGwTUmI6 PZoa2woKOS1VUxJB0Tk0Ac0kMbwQyvPar+0TjcFHnbRf7ehoqH54hynHFvwOt1R3UnQK DbfN+MYAgJFu73aRc3RMtnhM0k67YTiU6CFSDLyMO/tdLiUx88lCGRa6kDjTnh5E9Q2w onKbaYslnc6GDcPH7jnctihvQcTEb3kFhpZbkVC3TcZViN6oeJe6QlBseUej7QfUNXmI VwJg== X-Gm-Message-State: AOJu0YwUTNKdIbjKvpW+zPkSQEyAW8Yq0RDfX8xoyksJYnLzKVLJ/23V 6AfZUBsilvKoMTm7FGDPd3NrpvE8ZQf7Wf2dK5IvN5BPGncIBqqWw4RfQVTIuWr3 X-Gm-Gg: AeBDieupg4isWUIm+Rbq5Rzd3za7L9FuEiOvYM6JaYlMI2q2NXICmRIJXC3v7yKeyHi RKXhcoltjZME/YdCU5x6z1TZtobAwjWLZihB8pg33peBWKDQ//IzrQ3vk2HpEdwT1JASKokRjHq P1c42FtsHFjSdloLvnF1A5y/QROSy5ykF2rrNAL/WGghF+TgAcGacvkp1Kw7Gaex3kLxkYqx9OF oOi879qzdStu8mOGi7z4pUg0AI3TMtQBlP5CjRt+Jwdo1l2A6eN+ge853SWjTj5IaKOmyM4xzp+ BuPuYelZS5hghcNzVHJcf7KsSoCSQ9g9sfc5G++jHcHEEcfNiNfzwYEXCH8rT8CJniafu/vK/QR oNt5CodlN6CtRjF9iPHVV6V/ffz1km1M6Aw3Xz7RoyrMfjVEMs1oFfIUnNa506G/zGsDPyHioHT 8cNhXN1J7DjaY1/0q0je3SasimiGs= X-Received: by 2002:a05:6830:81ec:b0:7dc:18e:b584 with SMTP id 46e09a7af769-7dc922df2b0mr380408a34.4.1776365839042; Thu, 16 Apr 2026 11:57:19 -0700 (PDT) Received: from localhost ([2a03:2880:12ff:2::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dc90a6583fsm522635a34.10.2026.04.16.11.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 11:57:18 -0700 (PDT) From: Stanislav Fomichev X-Google-Original-From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Alexander Duyck , kernel-team@meta.com, Aleksandr Loktionov Subject: [PATCH net v8 05/15] fbnic: convert to ndo_set_rx_mode_async Date: Thu, 16 Apr 2026 11:57:02 -0700 Message-ID: <20260416185712.2155425-6-sdf@fomichev.me> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260416185712.2155425-1-sdf@fomichev.me> References: <20260416185712.2155425-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert fbnic from ndo_set_rx_mode to ndo_set_rx_mode_async. The driver's __fbnic_set_rx_mode() now takes explicit uc/mc list parameters and uses __hw_addr_sync_dev() on the snapshots instead of __dev_uc_sync/__dev_mc_sync on the netdev directly. Update callers in fbnic_up, fbnic_fw_config_after_crash, fbnic_bmc_rpc_check and fbnic_set_mac to pass the real address lists calling __fbnic_set_rx_mode outside the async work path. Cc: Alexander Duyck Cc: kernel-team@meta.com Reviewed-by: Aleksandr Loktionov Signed-off-by: Stanislav Fomichev --- .../net/ethernet/meta/fbnic/fbnic_netdev.c | 20 ++++++++++++------- .../net/ethernet/meta/fbnic/fbnic_netdev.h | 4 +++- drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 4 ++-- drivers/net/ethernet/meta/fbnic/fbnic_rpc.c | 2 +- 4 files changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c index b4b396ca9bce..c406a3b56b37 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c @@ -183,7 +183,9 @@ static int fbnic_mc_unsync(struct net_device *netdev, const unsigned char *addr) return ret; } -void __fbnic_set_rx_mode(struct fbnic_dev *fbd) +void __fbnic_set_rx_mode(struct fbnic_dev *fbd, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { bool uc_promisc = false, mc_promisc = false; struct net_device *netdev = fbd->netdev; @@ -213,10 +215,10 @@ void __fbnic_set_rx_mode(struct fbnic_dev *fbd) } /* Synchronize unicast and multicast address lists */ - err = __dev_uc_sync(netdev, fbnic_uc_sync, fbnic_uc_unsync); + err = __hw_addr_sync_dev(uc, netdev, fbnic_uc_sync, fbnic_uc_unsync); if (err == -ENOSPC) uc_promisc = true; - err = __dev_mc_sync(netdev, fbnic_mc_sync, fbnic_mc_unsync); + err = __hw_addr_sync_dev(mc, netdev, fbnic_mc_sync, fbnic_mc_unsync); if (err == -ENOSPC) mc_promisc = true; @@ -238,18 +240,21 @@ void __fbnic_set_rx_mode(struct fbnic_dev *fbd) fbnic_write_tce_tcam(fbd); } -static void fbnic_set_rx_mode(struct net_device *netdev) +static void fbnic_set_rx_mode(struct net_device *netdev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { struct fbnic_net *fbn = netdev_priv(netdev); struct fbnic_dev *fbd = fbn->fbd; /* No need to update the hardware if we are not running */ if (netif_running(netdev)) - __fbnic_set_rx_mode(fbd); + __fbnic_set_rx_mode(fbd, uc, mc); } static int fbnic_set_mac(struct net_device *netdev, void *p) { + struct fbnic_net *fbn = netdev_priv(netdev); struct sockaddr *addr = p; if (!is_valid_ether_addr(addr->sa_data)) @@ -257,7 +262,8 @@ static int fbnic_set_mac(struct net_device *netdev, void *p) eth_hw_addr_set(netdev, addr->sa_data); - fbnic_set_rx_mode(netdev); + if (netif_running(netdev)) + __fbnic_set_rx_mode(fbn->fbd, &netdev->uc, &netdev->mc); return 0; } @@ -551,7 +557,7 @@ static const struct net_device_ops fbnic_netdev_ops = { .ndo_features_check = fbnic_features_check, .ndo_set_mac_address = fbnic_set_mac, .ndo_change_mtu = fbnic_change_mtu, - .ndo_set_rx_mode = fbnic_set_rx_mode, + .ndo_set_rx_mode_async = fbnic_set_rx_mode, .ndo_get_stats64 = fbnic_get_stats64, .ndo_bpf = fbnic_bpf, .ndo_hwtstamp_get = fbnic_hwtstamp_get, diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h index 9129a658f8fa..eded20b0e9e4 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h +++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.h @@ -97,7 +97,9 @@ void fbnic_time_init(struct fbnic_net *fbn); int fbnic_time_start(struct fbnic_net *fbn); void fbnic_time_stop(struct fbnic_net *fbn); -void __fbnic_set_rx_mode(struct fbnic_dev *fbd); +void __fbnic_set_rx_mode(struct fbnic_dev *fbd, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc); void fbnic_clear_rx_mode(struct fbnic_dev *fbd); void fbnic_phylink_get_pauseparam(struct net_device *netdev, diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_pci.c b/drivers/net/ethernet/meta/fbnic/fbnic_pci.c index b7c0b7349d00..7e85b480203c 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_pci.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_pci.c @@ -135,7 +135,7 @@ void fbnic_up(struct fbnic_net *fbn) fbnic_rss_reinit_hw(fbn->fbd, fbn); - __fbnic_set_rx_mode(fbn->fbd); + __fbnic_set_rx_mode(fbn->fbd, &fbn->netdev->uc, &fbn->netdev->mc); /* Enable Tx/Rx processing */ fbnic_napi_enable(fbn); @@ -180,7 +180,7 @@ static int fbnic_fw_config_after_crash(struct fbnic_dev *fbd) } fbnic_rpc_reset_valid_entries(fbd); - __fbnic_set_rx_mode(fbd); + __fbnic_set_rx_mode(fbd, &fbd->netdev->uc, &fbd->netdev->mc); return 0; } diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c b/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c index 42a186db43ea..fe95b6f69646 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_rpc.c @@ -244,7 +244,7 @@ void fbnic_bmc_rpc_check(struct fbnic_dev *fbd) if (fbd->fw_cap.need_bmc_tcam_reinit) { fbnic_bmc_rpc_init(fbd); - __fbnic_set_rx_mode(fbd); + __fbnic_set_rx_mode(fbd, &fbd->netdev->uc, &fbd->netdev->mc); fbd->fw_cap.need_bmc_tcam_reinit = false; } -- 2.52.0