From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EA2A34B1B4 for ; Thu, 16 Apr 2026 18:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776365843; cv=none; b=Y28OBJmVddIbH0XEGdnZybs8Y3C5+fbHjrTGhVBNbQF3WKW/V+yMyD2nrigWylCIhO85CCqOFLIzOwCy0mWr0XyOqF//suW9q+KdFEwRnZ/olzT6ZSWeZpQT08hRHqGS1RVIKgN4Uyc83H0UWeBaOdftzQ7Qa8/A4Sw1jeJa/UU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776365843; c=relaxed/simple; bh=Ha+loX0JVubvlhVDjMyc8KFLsBSp75jlVlO4LbRd2Nk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qee0JhqogzquucEtlj4dOZF1Sj1WrZjwyRtLZyHpaeLlpjVdJm9Ph+j1Y/jSzRj2c6Zah73FX7fA21UiFfDQrIx7PLblPVgzsc5qbthFJkxhAOMX+oPwxk5s/m3aa6qFk3w7Lo9aHtamMV24YmHhlTEJnGHRFX6PENzikq66tR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L7pCGydG; arc=none smtp.client-ip=209.85.167.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L7pCGydG" Received: by mail-oi1-f193.google.com with SMTP id 5614622812f47-4670464029eso4739534b6e.2 for ; Thu, 16 Apr 2026 11:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776365841; x=1776970641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HtgGAyqS8DwTcDUuPNHQIODcc+hJGqRr3oaNkxkpAZ0=; b=L7pCGydG4Oyzb71XQHtIOiAZgIU1GexM0tnaPI0yLvqebcN63WJ3eOJkqY8YF27Wr3 2Jusc/sw8y58jBOUfzDJOK+Cq+VcFjj2QHoppE755zRQxYvHbL/S3C59kN5pDpMmoGO2 vWLKP0j5953EfUpjllw1rK2lBwtIA7Cy7S5D0ZXPeZuQVhFqMTmjQQWL0uZoDNCF48GW nhM/u8z2vtXIA2pzbRjCXbuVIOFaJxKGpI+RkKp5g29yuIZvEftCmg0zKeq+ZoHVDoJw gcg29hyzvWpC2bPKrnmGVNH63Un1LVRAg9z5xwJa9yRw3xO/pmR38XD63wLTlCUCFx4m fiXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776365841; x=1776970641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HtgGAyqS8DwTcDUuPNHQIODcc+hJGqRr3oaNkxkpAZ0=; b=CdrVpoPm8D8RKGKpVMEt0f6BbDfmFV7lK5NrBuwW9YPFqSm2tMDoJg7qYZT2awWHBn UKRvn//cQaKoAvl5ISOXd0G9xwZMHGGd8rVGYJmL841fLBOiAUf7ENfdVNNelv9CNEHd J87/+B+D7Fb1BO/jOkkb+mXRV6nI7K2n7eeNdVSW0IRBAiAKeichaqN4v9xVI0xxA/ku J7Te0/N8x4sBii3Gsph5YNFC4Hz7S9h0aj/IYLAX41g2cmpHoOfwdY4nnvMU0Z7w3XwJ SPkjsjPh9/hNC6G2B/Cs0T49NbpGDXkv3P449XiUl5SaRVvL5D9LK9ZI4M368aQu6Hi2 VmzA== X-Gm-Message-State: AOJu0YwrDQknRK1UTN17baGduLV4mOIOS1sKZ6xw3Krqb87n6GJ15Zu3 NouaTYDkbf1ZMxWx7Djuz47TW43pRR/xhWbq8nHpuE4JPF6yFesj5yFa0ccEqlQ+ X-Gm-Gg: AeBDietDQrL25ycnaWO95zREA9uwKbu9KSdVN05IsKDlHj4WVwBnm7gblvOxwJJ1LCu nFMDXOdBFCVpDWe7JigPWIOhv9uDHfKZFSjDZrUnGYQzDPA2Jb+hIgkyGomV8RM3Vz9b2Sv46yx 1sfh7YYACti1i0FRqg8DgWUTi4A12yJEGvCtqJL3bf+R8TLEPOMRJSvpVPnowQx+NC9hwyDvXZJ l2Uks1TwHX2pVQsBxHPQNS8HMZ5aGlZWu6ArDtWr3y8aTbyPkZYjn9CliZmPDDhv4RReA4Vc4Ox 75CHUJ+WPq0yIcEv8at+Js1qfDr+05OhY80wcevi4Rn9HHE1+eoSEjtEOHLjHC7mM7Y17OVvlJg TxYOaJPyR3qpFf+bXKRzT6UzktnF3LlZxPR3MRcKcXVNTOwEVaq8vT8NjS1Ingq5xwPNFREUpzP N7sqP+rypRKgNuih4DWsdGerE0wvc= X-Received: by 2002:a54:4e99:0:b0:467:2f84:b0c6 with SMTP id 5614622812f47-4799a169d3dmr90670b6e.8.1776365841089; Thu, 16 Apr 2026 11:57:21 -0700 (PDT) Received: from localhost ([2a03:2880:12ff:9::]) by smtp.gmail.com with ESMTPSA id 5614622812f47-47997fb24d8sm493251b6e.16.2026.04.16.11.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 11:57:20 -0700 (PDT) From: Stanislav Fomichev X-Google-Original-From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Michael Chan , Pavan Chebbi , Aleksandr Loktionov Subject: [PATCH net v8 07/15] bnxt: convert to ndo_set_rx_mode_async Date: Thu, 16 Apr 2026 11:57:04 -0700 Message-ID: <20260416185712.2155425-8-sdf@fomichev.me> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260416185712.2155425-1-sdf@fomichev.me> References: <20260416185712.2155425-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert bnxt from ndo_set_rx_mode to ndo_set_rx_mode_async. bnxt_set_rx_mode, bnxt_mc_list_updated and bnxt_uc_list_updated now take explicit uc/mc list parameters and iterate with netdev_hw_addr_list_for_each instead of netdev_for_each_{uc,mc}_addr. The bnxt_cfg_rx_mode internal caller passes the real lists under netif_addr_lock_bh. BNXT_RX_MASK_SP_EVENT is still used here, next patch converts to the direct call. Cc: Michael Chan Cc: Pavan Chebbi Reviewed-by: Michael Chan Reviewed-by: Aleksandr Loktionov Signed-off-by: Stanislav Fomichev --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 31 +++++++++++++---------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 2715632115a5..61d4a9911413 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -11132,7 +11132,8 @@ static int bnxt_setup_nitroa0_vnic(struct bnxt *bp) } static int bnxt_cfg_rx_mode(struct bnxt *); -static bool bnxt_mc_list_updated(struct bnxt *, u32 *); +static bool bnxt_mc_list_updated(struct bnxt *, u32 *, + const struct netdev_hw_addr_list *); static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init) { @@ -11222,7 +11223,7 @@ static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init) } else if (bp->dev->flags & IFF_MULTICAST) { u32 mask = 0; - bnxt_mc_list_updated(bp, &mask); + bnxt_mc_list_updated(bp, &mask, &bp->dev->mc); vnic->rx_mask |= mask; } @@ -13620,17 +13621,17 @@ void bnxt_get_ring_drv_stats(struct bnxt *bp, bnxt_get_one_ring_drv_stats(bp, stats, &bp->bnapi[i]->cp_ring); } -static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask) +static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask, + const struct netdev_hw_addr_list *mc) { struct bnxt_vnic_info *vnic = &bp->vnic_info[BNXT_VNIC_DEFAULT]; - struct net_device *dev = bp->dev; struct netdev_hw_addr *ha; u8 *haddr; int mc_count = 0; bool update = false; int off = 0; - netdev_for_each_mc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, mc) { if (mc_count >= BNXT_MAX_MC_ADDRS) { *rx_mask |= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count = 0; @@ -13654,17 +13655,17 @@ static bool bnxt_mc_list_updated(struct bnxt *bp, u32 *rx_mask) return update; } -static bool bnxt_uc_list_updated(struct bnxt *bp) +static bool bnxt_uc_list_updated(struct bnxt *bp, + const struct netdev_hw_addr_list *uc) { - struct net_device *dev = bp->dev; struct bnxt_vnic_info *vnic = &bp->vnic_info[BNXT_VNIC_DEFAULT]; struct netdev_hw_addr *ha; int off = 0; - if (netdev_uc_count(dev) != (vnic->uc_filter_count - 1)) + if (netdev_hw_addr_list_count(uc) != (vnic->uc_filter_count - 1)) return true; - netdev_for_each_uc_addr(ha, dev) { + netdev_hw_addr_list_for_each(ha, uc) { if (!ether_addr_equal(ha->addr, vnic->uc_list + off)) return true; @@ -13673,7 +13674,9 @@ static bool bnxt_uc_list_updated(struct bnxt *bp) return false; } -static void bnxt_set_rx_mode(struct net_device *dev) +static void bnxt_set_rx_mode(struct net_device *dev, + struct netdev_hw_addr_list *uc, + struct netdev_hw_addr_list *mc) { struct bnxt *bp = netdev_priv(dev); struct bnxt_vnic_info *vnic; @@ -13694,7 +13697,7 @@ static void bnxt_set_rx_mode(struct net_device *dev) if (dev->flags & IFF_PROMISC) mask |= CFA_L2_SET_RX_MASK_REQ_MASK_PROMISCUOUS; - uc_update = bnxt_uc_list_updated(bp); + uc_update = bnxt_uc_list_updated(bp, uc); if (dev->flags & IFF_BROADCAST) mask |= CFA_L2_SET_RX_MASK_REQ_MASK_BCAST; @@ -13702,7 +13705,7 @@ static void bnxt_set_rx_mode(struct net_device *dev) mask |= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST; vnic->mc_list_count = 0; } else if (dev->flags & IFF_MULTICAST) { - mc_update = bnxt_mc_list_updated(bp, &mask); + mc_update = bnxt_mc_list_updated(bp, &mask, mc); } if (mask != vnic->rx_mask || uc_update || mc_update) { @@ -13721,7 +13724,7 @@ static int bnxt_cfg_rx_mode(struct bnxt *bp) bool uc_update; netif_addr_lock_bh(dev); - uc_update = bnxt_uc_list_updated(bp); + uc_update = bnxt_uc_list_updated(bp, &dev->uc); netif_addr_unlock_bh(dev); if (!uc_update) @@ -15986,7 +15989,7 @@ static const struct net_device_ops bnxt_netdev_ops = { .ndo_start_xmit = bnxt_start_xmit, .ndo_stop = bnxt_close, .ndo_get_stats64 = bnxt_get_stats64, - .ndo_set_rx_mode = bnxt_set_rx_mode, + .ndo_set_rx_mode_async = bnxt_set_rx_mode, .ndo_eth_ioctl = bnxt_ioctl, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = bnxt_change_mac_addr, -- 2.52.0