Re: [PATCH net v2 2/2] bnge: remove unsupported backing store type

Przemek Kitszel
2026-04-16T03:54:48Z

On 4/15/26 17:16, Vikas Gupta wrote:
> The backing store type, BNGE_CTX_MRAV, is not applicable in Thor Ultra
> devices. Remove it from the backing store configuration, as the firmware

I guess the removed code was needed for previous devices, what is the
impact for them?

> will not populate entities in this backing store type, due to which the
> driver load fails.
>
> Fixes: 29c5b358f385 ("bng_en: Add backing store support")
> Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
> Reviewed-by: Dharmender Garg <dharmender.garg@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/bnge/bnge_rmem.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_rmem.c b/drivers/net/ethernet/broadcom/bnge/bnge_rmem.c
> index 94f15e08a88c..b066ee887a09 100644
> --- a/drivers/net/ethernet/broadcom/bnge/bnge_rmem.c
> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_rmem.c
> @@ -324,7 +324,6 @@ int bnge_alloc_ctx_mem(struct bnge_dev *bd)
> u32 l2_qps, qp1_qps, max_qps;
> u32 ena, entries_sp, entries;
> u32 srqs, max_srqs, min;
> - u32 num_mr, num_ah;
> u32 extra_srqs = 0;
> u32 extra_qps = 0;
> u32 fast_qpmd_qps;
> @@ -390,21 +389,6 @@ int bnge_alloc_ctx_mem(struct bnge_dev *bd)
> if (!bnge_is_roce_en(bd))
> goto skip_rdma;
>
> - ctxm = &ctx->ctx_arr[BNGE_CTX_MRAV];
> - /* 128K extra is needed to accommodate static AH context
> - * allocation by f/w.
> - */
> - num_mr = min_t(u32, ctxm->max_entries / 2, 1024 * 256);
> - num_ah = min_t(u32, num_mr, 1024 * 128);
> - ctxm->split_entry_cnt = BNGE_CTX_MRAV_AV_SPLIT_ENTRY + 1;
> - if (!ctxm->mrav_av_entries || ctxm->mrav_av_entries > num_ah)
> - ctxm->mrav_av_entries = num_ah;
> -
> - rc = bnge_setup_ctxm_pg_tbls(bd, ctxm, num_mr + num_ah, 2);
> - if (rc)
> - return rc;
> - ena |= FUNC_BACKING_STORE_CFG_REQ_ENABLES_MRAV;
> -
> ctxm = &ctx->ctx_arr[BNGE_CTX_TIM];
> rc = bnge_setup_ctxm_pg_tbls(bd, ctxm, l2_qps + qp1_qps + extra_qps, 1);
> if (rc)