From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFBF022A817; Mon, 20 Apr 2026 15:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776699217; cv=none; b=f65RuExYNbQoXKIvtyb7O0S9AOnb8Qr8zyFnLLvDnrOHzeLo3DgWCUAaewCrHOQ52IsG3yMfIR8ZZbR/UopJah5ll6S1O4hYw5OFomaGRg1MxruDiphAsQqLHfUB//sRC62YwBQcA9PIv84SgUo9jVly49xzQqs0GSyJBKuP2og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776699217; c=relaxed/simple; bh=Kjn532amPlaxRPE+ZdGcJATDJi/VPSFQUdv5WzNh3iQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oyYxSVzSmXBeX+AEfSSmtFWDUoXBl4+XMdI2yH9w+SgzRR4AyH+fqxm83+qdLmHccSziQ5zQ38sHGH/3ls9CLU0qGPdWL6T1usISvRRZXcAw3Uh6HJxBALOOCfnCoQQLTNajlp8NEI3EzJfSaWcdIF4+vY0x026gEMlURJKkkiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J11F5QCY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J11F5QCY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB776C2BCB6; Mon, 20 Apr 2026 15:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776699217; bh=Kjn532amPlaxRPE+ZdGcJATDJi/VPSFQUdv5WzNh3iQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J11F5QCYiqW9f+FhXzUDFhRkgicfaczvTTTau4KaRSn4neTbdcCd30wvVz/YZ1xCe oqPzbdI7kX/dtrKjpsCniam/m5IYQjV9mnNscDlUPk1jxAJf+XG2db3Q3W0JLWMigt tCfZHRso3vpYoNYVcPdfu2ZWNzQfmRpdjfabXCibgYFVndLyK+D49fJhW9hd6qbbzn LZtYOXco0BhQ2tuyTBhBreacs4LEtyimjQIUSdpkiNbl1uQb+WFncUtq/cm78GpJ8L orroCGJd+BUumTBtViNQ/EByhVV4NsxbKCyR5kzZywq3H5uWtys5+FDxtqotCSOmuk PquIH7zpKJr8g== Date: Mon, 20 Apr 2026 17:33:34 +0200 From: Krzysztof Kozlowski To: Minda Chen Cc: Alexandre Torgue , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, devicetree@vger.kernel.org Subject: Re: [net-next v2 2/5] dt-bindings: net: starfive,jh7110-dwmac: Add JHB100 support Message-ID: <20260420-messy-elite-panther-a7ffbc@quoll> References: <20260417024523.107786-1-minda.chen@starfivetech.com> <20260417024523.107786-3-minda.chen@starfivetech.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260417024523.107786-3-minda.chen@starfivetech.com> On Fri, Apr 17, 2026 at 10:45:20AM +0800, Minda Chen wrote: > Add StarFive JHB100 dwmac support and compatible. > The JHB100 dwmac shares the same driver code as the JH7110 dwmac, Please describe the hardware or programming interface, not driver code. > which contains 2 SGMII interfaces, 1 RGMII/RMII interface and > 1 RMII interface. > JHB100 dwmac has only one reset signal and one main interrupt > line. Drop all below, not relevant. > > Please refer to below: > > JHB100: reset-names = "stmmaceth"; > > Example usage of JHB100 in the device tree: > > gmac0: ethernet@11b80000 { > compatible = "starfive,jhb100-dwmac", > "snps,dwmac-5.20"; > interrupts = <225>; > interrupt-names = "macirq"; > ... > }; > > Signed-off-by: Minda Chen > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > .../bindings/net/starfive,jh7110-dwmac.yaml | 23 +++++++++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 38bc34dc4f09..85cd3252e8b1 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -115,6 +115,7 @@ properties: > - sophgo,sg2044-dwmac > - starfive,jh7100-dwmac > - starfive,jh7110-dwmac > + - starfive,jhb100-dwmac > - tesla,fsd-ethqos > - thead,th1520-gmac > > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > index 0d1962980f57..edc246a71ce3 100644 > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > @@ -18,6 +18,7 @@ select: > enum: > - starfive,jh7100-dwmac > - starfive,jh7110-dwmac > + - starfive,jhb100-dwmac > required: > - compatible > > @@ -30,6 +31,9 @@ properties: > - items: > - const: starfive,jh7110-dwmac > - const: snps,dwmac-5.20 > + - items: > + - const: starfive,jhb100-dwmac So that's an enum in previous "items" list.... but your commit msg said your devices are compatible, so confusing. Best regards, Krzysztof