From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80C75331A78 for ; Mon, 20 Apr 2026 15:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776700583; cv=none; b=jmWo25F46YA32EXJlNTU0FWXv+0okuWWW6TvBFI7oVu7pGP2a3hsR9+j3LxRoH/cQKw0Cp2Z0eaAjN/J0l87LBfTGiEDU/KaX4HjE/I1MRfqm8b1N/4YGIf+WL6KTKSnI11l2XMEtmt2ebyfTGsbVCitXMV/X2DXnrv8iPDQGBo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776700583; c=relaxed/simple; bh=9Qgqeri4ieAdo6+5MWuNmYIp4MCTl3DLSaPutxRqWfM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GTvga64kYBZdnkfEEYtmdFqiezo90n6R7nHNdO2fNUbvqwMt6DIuUz/k5hmtUVarQ1KrfUfeie7operY/EKnDrBmAlzxmoREAWnFyN31yq9cAM4mJp7HYfSKy3YN3XXkBFVxG8+S1IwsNofjf2fH0d5VaIH+vxrOgijISGLB5w8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ksmEw8KY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ksmEw8KY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E37D6C19425; Mon, 20 Apr 2026 15:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776700583; bh=9Qgqeri4ieAdo6+5MWuNmYIp4MCTl3DLSaPutxRqWfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ksmEw8KYLFBEBK2tCdF7SXGEKmpxM7ZICe3lhvRKln9sXBeFa2xWxzLFjbC5vrc13 /WbPEX4nslhLuPVukFOPgxQiWh5raYTvk3f+21U1GLBrIyhe+B05EMYDrgo1N3hrlQ JkYk+tUCAhA29Y6fn8UCJiw6xLCidkOv6vXTr3p9XGs1J6vmnh2AjGXW8LEiyFjZaT uHuqXIP4CqZtieutBJ7lO/MyogE32IXEa7NFgXQ+L4jZmJp5bqONbZdibB471R6oGv k1fOEYGPzteio9nK9ycuEf7mAZiYKqr5YhQWPlrUY7n+YBqvp6ELPuvez97WFtyOfI j8qUoiy9mbmMA== From: Simon Horman To: aleksandr.loktionov@intel.com Cc: 'Simon Horman' , intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, jan.glaza@intel.com Subject: Re: [PATCH iwl-net 3/4] ice: support RDMA on 4+-port E830 devices Date: Mon, 20 Apr 2026 16:56:04 +0100 Message-ID: <20260420155604.576318-1-horms@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260417062954.1241900-4-aleksandr.loktionov@intel.com> References: <20260417062954.1241900-4-aleksandr.loktionov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: 'Simon Horman' This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. Full review at: https://sashiko.dev --- ice: support RDMA on 4+-port E830 devices This patch narrows the RDMA capability check to keep RDMA enabled for E830 devices configured with more than 4 ports, as they do not share the limitations of E810 and E82X devices. > diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c > --- a/drivers/net/ethernet/intel/ice/ice_common.c > +++ b/drivers/net/ethernet/intel/ice/ice_common.c > @@ -2509,7 +2509,7 @@ ice_recalc_port_limited_caps(struct ice_hw *hw, struct ice_hw_common_caps *caps) > caps->maxtc = 4; > ice_debug(hw, ICE_DBG_INIT, "reducing maxtc to %d (based on #ports)\n", > caps->maxtc); > - if (caps->rdma) { > + if (caps->rdma && hw->mac_type != ICE_MAC_E830) { > ice_debug(hw, ICE_DBG_INIT, "forcing RDMA off\n"); > caps->rdma = 0; > } Does this leave the diagnostic message further down out of sync with the new condition? If the device is an E830 with more than 4 ports, RDMA remains enabled, but because the dev_info() call just below this block is evaluated for all devices with more than 4 ports: ice_recalc_port_limited_caps() { if (hw->dev_caps.num_funcs > 4) { ... if (caps->rdma && hw->mac_type != ICE_MAC_E830) { ice_debug(hw, ICE_DBG_INIT, "forcing RDMA off\n"); caps->rdma = 0; } /* print message only when processing device capabilities * during initialization. */ if (caps == &hw->dev_caps.common_cap) dev_info(ice_hw_to_dev(hw), "RDMA functionality is not available with the current device configuration.\n"); } } Could this cause confusion by logging a warning about RDMA being disabled when it is actually active?