From: Simon Horman <horms@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Grzegorz Nitka <grzegorz.nitka@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Petr Oros <poros@redhat.com>,
Sunitha Mekala <sunithax.d.mekala@intel.com>,
Timothy Miskell <timothy.miskell@intel.com>
Subject: Re: [PATCH net 0/4] Intel Wired LAN Driver Updates 2026-04-20 (ice)
Date: Wed, 22 Apr 2026 10:23:04 +0100 [thread overview]
Message-ID: <20260422092304.GJ651125@horms.kernel.org> (raw)
In-Reply-To: <20260420-jk-iwl-net-2026-04-20-ptp-e825c-phy-interrupt-fixes-v1-0-bc2240f42251@intel.com>
On Mon, Apr 20, 2026 at 05:51:24PM -0700, Jacob Keller wrote:
> Since this is a set of related fixes for just the ice driver, Jake provides
> the following description for the series:
Thanks for the excellent cover letter and patch descriptions.
Reviewed-by: Simon Horman <horms@kernel.org>
For completeness:
* I have looked over the AI generated review of patch 2/4 by Sashiko.
You may wish to too. But I do not believe that feedback warrants
holding up this series. Actually, I am skeptical those issues
should be addressed at all.
* I have also looked over the AI generated review based on Chris Mason's
review prompts which is available at https://netdev-ai.bots.linux.dev
(if only it had a name!). It flags an potentially incorrect Fixes tag in
patch 4/4. However, the cover letter for the patch explains the
choice of Fixes tag, effectively rebutting the analysis generated by AI
(I guess it didn't take the commit message sufficiently into account.)
prev parent reply other threads:[~2026-04-22 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 0:51 [PATCH net 0/4] Intel Wired LAN Driver Updates 2026-04-20 (ice) Jacob Keller
2026-04-21 0:51 ` [PATCH net 1/4] ice: fix timestamp interrupt configuration for E825C Jacob Keller
2026-04-21 0:51 ` [PATCH net 2/4] ice: perform PHY soft reset for E825C ports at initialization Jacob Keller
2026-04-21 0:51 ` [PATCH net 3/4] ice: fix ready bitmap check for non-E822 devices Jacob Keller
2026-04-21 0:51 ` [PATCH net 4/4] ice: fix ice_ptp_read_tx_hwtstamp_status_eth56g Jacob Keller
2026-04-22 9:23 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422092304.GJ651125@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grzegorz.nitka@intel.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sunithax.d.mekala@intel.com \
--cc=timothy.miskell@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox