From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7586A1E98EF; Thu, 23 Apr 2026 02:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776913189; cv=none; b=lW/a67WaMOSfkwIGefvK29gRJ+ApdBKCbifylyfkYtG/reLqBI7N+DkaeVnc/DBscLeHlsEEFpwg0AswUeIVFzhbSjEvPevCmPuA4Bo6pjEijPvm7O42LqhrkLQoQiXVSLSz9v/bgprHmtio7b8ulnTvC1E8NuR0IAVti2JrfCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776913189; c=relaxed/simple; bh=nrPmGgWOlDO3ud/YqvY9Phquk3C5jLK2y8xKPWW8mwE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PMvaIq3Z8cuRBOQY8kM+ABDS27CO3b71sKLAnOmFhDLEXqPJhBvQInai+QG0DrpHFO/JjT3pEAeDOSFuB3wHHg7Ph7tXZSWjqwmTiL8cMO2WYuL+keIzDJPL900G6cUkxTyol6afMK37h1cKLUpOYN9+VhVuyOS/uwRP3a+XVSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rC4iF5Yv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rC4iF5Yv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F835C19425; Thu, 23 Apr 2026 02:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776913189; bh=nrPmGgWOlDO3ud/YqvY9Phquk3C5jLK2y8xKPWW8mwE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rC4iF5YvZWRWJyCEgxyVVTSFyUnfa5fOr2hQ6Q62jNF5pSsYxDH1sT8b+zr+MtXkz wA6T92x1YuoRaIxr/JLIBKICL+cwTnTlMmWXMAdCLW36LiG4Y0OXivRMz2narxyrDa Ms+oOLBsphUxMwvz9QafBbrfCfNxS0hNcoYvzGp+xzdicxtsKXXLRZ/aAdhCpqn2WG 2D/pQHkuW69AnNSRAeypCY275pQTQEDQygpxGcRqN+hBxTQms1336i3T2Hdl3GRJHT AkaoKxF+br+bg0LkEACwUrLoOoSeH99Ugk5wBLoiArKobjyLd3Tf5yJZ1QPr6GJf6C JsK3UHL1ioUhA== Date: Wed, 22 Apr 2026 19:59:47 -0700 From: Jakub Kicinski To: Cosmin Ratiu Cc: Boris Pismenny , "willemdebruijn.kernel@gmail.com" , "andrew+netdev@lunn.ch" , "daniel.zahka@gmail.com" , "davem@davemloft.net" , "leon@kernel.org" , "linux-kernel@vger.kernel.org" , "edumazet@google.com" , "linux-rdma@vger.kernel.org" , Rahul Rameshbabu , Raed Salem , Dragos Tatulea , "kees@kernel.org" , Mark Bloch , "pabeni@redhat.com" , Tariq Toukan , Saeed Mahameed , "netdev@vger.kernel.org" , Gal Pressman Subject: Re: [PATCH net 1/2] net/mlx5e: psp: Fix invalid access on PSP dev registration fail Message-ID: <20260422195947.5b5dc5b1@kernel.org> In-Reply-To: <5167f0714e3ddf750f80740bf2ab18a7bb567b16.camel@nvidia.com> References: <20260417050201.192070-2-tariqt@nvidia.com> <20260418190848.204170-1-kuba@kernel.org> <20260420100917.1e4be22a@kernel.org> <20260421072609.4b15e7b9@kernel.org> <3ca1bee450608d37cd0f9199ebc44c52c084cb08.camel@nvidia.com> <20260421080951.570e6e49@kernel.org> <6d96452f67d5b58578f67f97f750101abd4af9f6.camel@nvidia.com> <20260421113210.4f6a8eb6@kernel.org> <5167f0714e3ddf750f80740bf2ab18a7bb567b16.camel@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 22 Apr 2026 15:13:04 +0000 Cosmin Ratiu wrote: > > > Can you call mlx5e_psp_cleanup() when register fails for now? > > > > Done for the next version, currently undergoing testing. > > There's a snag: priv->psp may be accessed concurrently from > mlx5e_get_stats() -> mlx5e_fold_sw_stats64() so we'd need to play > tricks with RCU and that goes beyond what a net fix should be: It's a > redesign of how priv->psp is handled in the driver. There's a risk we > are missing things, or it becomes more intrusive that what a fix should > be. Questionable. > I would like to ask you: let's please not do this redesign of priv->psp > in a rush, and leave it for the net-next series I mentioned... > > To reiterate, would you like to take patch 2? Sure, whatever. But it has to be reposted, of course.