From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C231FBEBC for ; Thu, 23 Apr 2026 16:29:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961765; cv=none; b=Q7gVLcDQetd2zzHobWR+t/LzjO3jN+SbR/VTfXPFC47G7Y1FW2ltkWDgwjfyEdfG4GIYOIZGy7cjBxWz3BRrzu0iSAXSnBy3qhzN6gmoiOONQlSyaEvRfIjU9etHC4ca0ipLUe0E0uSz8WgmpFTmCn7jNLvMqIUVAEM7g6nnu6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776961765; c=relaxed/simple; bh=1dP9r6KsChftBuI2JpeBlTGZwoiAP3vqscR1wZR1+t8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Az/y46M8ODhprGZxf56AGQFc7uiWAo6z+nJn338p8C9Vc4ClwHlMF4edkXp1pboDcMuiuWrQITagOq98eF1AoIXXugbJErlJkdURgiGrniwJJKY05dxDpJbWOy+rczgNsaXRZ/485fPTwcUihE7ikXTPHKB5in6tg+x2DL6Xy/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XPWle9fg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XPWle9fg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADEE7C2BCAF; Thu, 23 Apr 2026 16:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776961764; bh=1dP9r6KsChftBuI2JpeBlTGZwoiAP3vqscR1wZR1+t8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XPWle9fg+rCRf4fF10a5hmPtRkHDlPtsJk0d2bKNI3S/eU3sMeys6exToKvbxp3hv l//Xrk5c+s28itVvpa0KD1DMBbnc9y3EuW0MKA2HUey+bLMd/UGRX8j003VF8jZDPA X6xR6MAnFR2sa76Vq/VWl4y+xhPtAcrimXWxVvD/oO3nCeFI5AmD55cu1XzEcWzNe5 KFGlkQ8mI0imyo72pzgze1PAsGMAvnJR1NdjFUmy1XmZESypiGmVdLDojdV/QvQk2O rEYfOwCFwAOcQNLH26jMxw0zZjUzJmpsCjmVl1sqMrsWrbvAmKqr9EBTQjkduHeUz3 tq1LKhFX6jRwg== Date: Thu, 23 Apr 2026 09:29:22 -0700 From: Jakub Kicinski To: "Tauro, Riana" Cc: Raag Jadav , , , , , , , , , , , , , , , , Zack McKevitt , Lijo Lazar , "Hawking Zhang" , "David S. Miller" , "Paolo Abeni" , Eric Dumazet , Subject: Re: [PATCH 3/4] drm/drm_ras: Add DRM RAS netlink error event notification Message-ID: <20260423092922.6c527d75@kernel.org> In-Reply-To: <65c6839f-a92d-4122-b347-a1250dde961d@intel.com> References: <20260311102913.3387468-6-riana.tauro@intel.com> <20260311102913.3387468-9-riana.tauro@intel.com> <09f253b3-ee64-4fbb-8cec-820e9769aa80@intel.com> <69c061b4-eb40-4e2d-aeaa-5dfa47b2db8c@intel.com> <65c6839f-a92d-4122-b347-a1250dde961d@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 23 Apr 2026 11:22:45 +0530 Tauro, Riana wrote: > We had some questions regarding events in netlink >=20 > 1) According to netlink spec, "Events are considered less idiomatic for=20 > netlink and notifications should be preferred." > Since we currently don't have a response that matches a get operation to= =20 > use notify. Would using an event be acceptable? I have only glanced at previous messages but would it not work to include the counter values into the "event" as if it was it was a counter get? If it makes no sense - it's fine. We have been adding events in some places, too, in networking. The thinking is basically that when the app that does the user space monitoring starts it will often want to know the state of the world. So we end up with "get state of the world" and "notify about state of the world" which should really be the same format. > 2) Is there a way to check if there are subscribers to a group before=20 > creating the event message? > =C2=A0 =C2=A0Currently the subscriber check happens in=20 > netlink_broadcast_filtered, but a reviewer suggested we could > =C2=A0 =C2=A0optimize by skipping message creation if there are no subsc= ribers. Yes, genl_has_listeners()