Re: [PATCH 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()

Yury Norov
2026-04-20T17:59:52Z

On Mon, Apr 20, 2026 at 07:49:19AM +0000, Ping-Ke Shih wrote:
> Yury Norov <ynorov@nvidia.com> wrote:
> > --- a/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c
> > +++ b/drivers/net/wireless/realtek/rtw89/rtw8852b_common.c
> > @@ -206,9 +206,9 @@ static void rtw8852bx_efuse_parsing_tssi(struct rtw89_dev *rtwdev,
> > static bool _decode_efuse_gain(u8 data, s8 *high, s8 *low)
> > {
> > if (high)
> > - *high = sign_extend32(FIELD_GET(GENMASK(7, 4), data), 3);
> > + *high = FIELD_GET_SIGNED(GENMASK(7, 4), data);
> > if (low)
> > - *low = sign_extend32(FIELD_GET(GENMASK(3, 0), data), 3);
> > + *low = FIELD_GET(GENMASK(3, 0), data);
>
> FIELD_GET_SIGNED()?
>
> >
> > return data != 0xff;
> > }

Ah sorry. Will fix in v2