Re: [PATCH v2 2/2] pinctrl: qcom: add the TLMM driver for the Nord platforms

Bartosz Golaszewski
2026-04-27T14:19:30Z

On Mon, Apr 27, 2026 at 4:17 PM Bjorn Andersson <andersson@kernel.org> wrote:
>
> On Mon, Apr 27, 2026 at 04:00:30PM +0200, Bartosz Golaszewski wrote:
> > diff --git a/drivers/pinctrl/qcom/pinctrl-nord.c b/drivers/pinctrl/qcom/pinctrl-nord.c
> [..]
> > +enum nord_functions {
> > + msm_mux_gpio,
> > + msm_mux_aoss_cti,
> > + msm_mux_atest_char0,
> > + msm_mux_atest_char1,
> > + msm_mux_atest_char2,
> > + msm_mux_atest_char3,
> > + msm_mux_atest_char_start,
> > + msm_mux_atest_usb20,
> > + msm_mux_atest_usb21,
> > + msm_mux_aud_intfc0_clk,
> > + msm_mux_aud_intfc0_data0,
> > + msm_mux_aud_intfc0_data1,
> > + msm_mux_aud_intfc0_data2,
> > + msm_mux_aud_intfc0_data3,
> > + msm_mux_aud_intfc0_data4,
> > + msm_mux_aud_intfc0_data5,
> > + msm_mux_aud_intfc0_data6,
> > + msm_mux_aud_intfc0_data7,
> > + msm_mux_aud_intfc0_ws,
> > + msm_mux_aud_intfc10_clk,
> > + msm_mux_aud_intfc10_data0,
> > + msm_mux_aud_intfc10_data1,
> > + msm_mux_aud_intfc10_ws,
> > + msm_mux_aud_intfc1_clk,
> > + msm_mux_aud_intfc1_data0,
> > + msm_mux_aud_intfc1_data1,
> > + msm_mux_aud_intfc1_data2,
> > + msm_mux_aud_intfc1_data3,
> > + msm_mux_aud_intfc1_data4,
> > + msm_mux_aud_intfc1_data5,
> > + msm_mux_aud_intfc1_data6,
> > + msm_mux_aud_intfc1_data7,
>
> Is there any reason to keep these 8 "data" lanes as separate pingroups?
>

The answer here and elsewhere is: no. I just didn't have other states
in DTS to visualize the resulting nodes and it didn't occur to me to
update other functions as well. I'll do it in v3.

Bart