Re: [PATCH net v2 2/4] net: macb: drop in-flight Tx SKBs on close

Nicolai Buchwitz
2026-04-29T22:14:58Z

Hi Théo

On 29.4.2026 11:26, Théo Lebrun wrote:
> [...]

>> Side note, not blocking: macb_close() doesn't cancel tx_error_task,
>> so the workqueue handler can race with this loop on tx_skb[]. The
>> exposure is pre-existing, but maybe worth a follow-up adding
>> cancel_work_sync() between napi_disable() and macb_free_consistent().
>
> Yes, noticed that while working on the context swapping series [0].
> The goal here is to improve MACB piecewise, so I won't take that on in
> the current series.
>
> [0]:
> https://lore.kernel.org/all/90f843aa3940bdbabadddce27314c1f1@tipi-net.de/t/#mda18f759c27a4d833084b23605463994632d97e3
> (and the two replies)

Yes, flagged it on that series too. Wasn't my intention to fold it
into this one either, just wanted to make sure it doesn't get lost
with so much in flight on macb right now, which I really appreciate!

> [...]

Cheers,
Nicolai