Re: [PATCH net v2 3/4] net: macb: increment stats.tx_dropped on tx error

Nicolai Buchwitz
2026-04-28T21:25:47Z

On 28.4.2026 18:32, Théo Lebrun wrote:
> macb_tx_error_task() is the workqueue callback on Tx errors interrupts
> (MACB_TX_ERR_FLAGS). Count number of errored SKBs and increment the Tx
> dropped stat by that amount.
>
> Two types of dropped (not consumed) packets:
> - Those that have been TX_USED but with an error.
> - Those that have not been TX_USED but that'll we drop to reset.
>
> Fixes: 89e5785fc8a6 ("[PATCH] Atmel MACB ethernet driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 9 +++++++++
> 1 file changed, 9 insertions(+)

> [...]

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>