From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BF5D3822A1 for ; Tue, 28 Apr 2026 22:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777416135; cv=none; b=g4zjY6gRIJGrXCtkS7+GF2kWeERwLhuVdgtOc2g5JcMhSUGhtCdOEMn1SzEc9BeJXcpe/7sG0N/SS34xvIRlg3B8rM0Ymfchfww6IC9tYJlCx8AtmYT2wwuKLN9n+AjI3qZf2HB7jqoF3B+Iihy1Q9658ax7v1KuO3tH+TGWbBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777416135; c=relaxed/simple; bh=aKUYZj3dKoRf2r8cTorj5veYi8EvMq/P59Mop727o3Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s8QOm3iIenBLzalDZX8PoQ87trLehFl6lDAh/0VDtadMscsREzmnZl0DkNzTQN8OY2PWs9ANzzPbVmmCaujk+6C1Bbz1wZ8txvAFCfbGkAbjfSgsuhGv2GIfc9ezt+Ar/pwGVMZk0XeH+DyY9/sAqB6a60tzvtLFwFGaGganG8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ceaYSdQo; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ceaYSdQo" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-793fdbb8d3aso129141227b3.3 for ; Tue, 28 Apr 2026 15:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777416132; x=1778020932; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cpsYT+KuyZIiwZWdP0lM/x4OtgL97fY3WCk6CAMYDUs=; b=ceaYSdQoRCa5WcPhevMa4RnDA4mD4/xxjtQDRSCG7GZoJyMjBs7T37+GTQoMbHx4yc XCmY7UmLu4i+YTw5NCnuEZsy45wD54vZoTjh/JZpcJip8SsvWSi9aN0mXAyj9Y7iCsP8 jFSo+yLnZCsXH7a4MC1SdlBBvtR1ujhTPLawHgP0R659e8afLJxCYv9mxJeZ9L9/5Foy XM28JbfljSt+4JavYo15tdCMBQMgirHmoETh7nUEQC1ivLOpiouXgDZ0g+G+aEXDm3C1 FaRX/re1OYGtbIQMyiNwyrxwQvCZzEIoNL3xGdnANJamY5kC82AFRAEBJHUXuzDk5JR7 5GYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777416132; x=1778020932; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cpsYT+KuyZIiwZWdP0lM/x4OtgL97fY3WCk6CAMYDUs=; b=gojg17sAz/GlCHzgTOTI718e9qfkVIHUf5QVHhR/wfJIvzEY4dTmIsdFzkBegZ9yVx rE73g0iHhLL5nqOMyVHhqCUofdWXsuNNkofDthXD60Xaxo2iXZSIuFJR0XL3prbiouWb dRiGhI1OFDZ8qVp3HTMCo7r/kyrv7WMnVxmDxvHo+tzZ96HQPPN7nsQA6C7iihxED3TW gmWz6XCRGmjLie64B7uLLHhyYuyHsd4+mLvE7eyPPiKPsHV/AYkNai/tARqgOLhL18CJ vAA84T1ZrHNz0f/A6noZE7hKt0sEBjuHNgwzZOLwXwuZ61Jf0vfWv9E+Y1Br9QIVgqg4 nDcQ== X-Gm-Message-State: AOJu0Ywt2iERwpzXqla1jyF4LXhADDil/EqjAVyXSrKc8Ol6F3RDfspR vN3Rr+vBClCWabLA8LOc0DQZLcCfjrFYLxg3/SYSUEwZC3r1kOcuDwk4 X-Gm-Gg: AeBDiesQ6IsVtHDoC1QYw7sF7gsFkjjiWs04Y8JBBcRX4dgOHOCF7cNjXW7UxTkXHCR w4cGO3j4ZwnA6HHf3lbYXxREa0TX4sve62wV3QCZCPkSu+yXUDFgmT5ntokmvBNff88choP2QHu h8ev67i9dwXqovorODSie2Eo/yEufhYw1GehPylYR3xG8YvvUc2THGvWty2pspiWvePk/P7aP7C /Ngljh5l0WynawjuZrPBp0QSq2n9HaIhH+k9rF40psTmtIzqlS6Oh7vc/zC2JCGr8KQgwcsDw+7 v++bf6uuHhv5rW2faSdeC4fHqz1dSYEnTQvyt427sMK8U72iNiP4YtayP75DRHILVp9ITQznOsM HBD9RZXwGRcB9GxLc43+V8UhwC5tWIfgkChw4tJl+ClmWALTHLEcKIAgorY7ES/cDID1DcUBw9n umxikfeK5PBBcIx6St64ci4WlbBa74zEoX X-Received: by 2002:a05:690c:b17:b0:7b9:d6b8:b9ac with SMTP id 00721157ae682-7bcf558efe6mr52968327b3.26.1777416131438; Tue, 28 Apr 2026 15:42:11 -0700 (PDT) Received: from localhost ([2a03:2880:f806:45::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd258a2eafsm4650877b3.29.2026.04.28.15.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 15:42:11 -0700 (PDT) From: Bobby Eshleman Date: Tue, 28 Apr 2026 15:41:58 -0700 Subject: [PATCH net-next 01/11] net: add netmem_tx modes that indicate dma capability Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260428-tcp-dm-netkit-v1-1-719280eba4d2@meta.com> References: <20260428-tcp-dm-netkit-v1-0-719280eba4d2@meta.com> In-Reply-To: <20260428-tcp-dm-netkit-v1-0-719280eba4d2@meta.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Alex Shi , Yanteng Si , Dongliang Mu , Michael Chan , Pavan Chebbi , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , kernel-team@meta.com, Daniel Borkmann , Nikolay Aleksandrov , Shuah Khan Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Mina Almasry , Bobby Eshleman X-Mailer: b4 0.14.3 From: Bobby Eshleman Devices that support netmem TX previously set dev->netmem_tx = true. This was checked in validate_xmit_unreadable_skb() to drop unreadable skbs (skbs with dmabuf-backed frags) before they reach drivers that would mishandle them or devices that would not have the iommu mappings for them. Some virtual devices like netkit (or ifb) never DMA and never touch frag contents, as they essentially just forward the skb to another device. They are unable to forward unreadable skbs, however, because they fail to pass TX validation checks on dev->netmem_tx. This single bit flag doesn't give the TX validator enough information to differentiate devices that will attempt DMA on the unreadable skb and those that will simply route it untouched. This patch fixes this issue by adding an additional bit to netmem_tx, so that drivers can indicate 1) if they have netmem support, and 2) if they do, are they DMA-capable or not? Replace the boolean with a 2-bit enum: NETMEM_TX_NONE - no netmem TX support (drop unreadable skbs) NETMEM_TX_DMA - full support, device does DMA NETMEM_TX_NO_DMA - pass-through, device never DMAs Subsequent patches update netmem drivers to the new flags. Assisted-by: Claude Code:claude-sonnet-4-6 Signed-off-by: Bobby Eshleman --- Documentation/networking/net_cachelines/net_device.rst | 2 +- Documentation/networking/netmem.rst | 8 +++++++- Documentation/translations/zh_CN/networking/netmem.rst | 7 ++++++- include/linux/netdevice.h | 11 +++++++++-- 4 files changed, 23 insertions(+), 5 deletions(-) diff --git a/Documentation/networking/net_cachelines/net_device.rst b/Documentation/networking/net_cachelines/net_device.rst index 1c19bb7705df..c85784259544 100644 --- a/Documentation/networking/net_cachelines/net_device.rst +++ b/Documentation/networking/net_cachelines/net_device.rst @@ -10,7 +10,7 @@ Type Name fastpath_tx_acce =================================== =========================== =================== =================== =================================================================================== unsigned_long:32 priv_flags read_mostly __dev_queue_xmit(tx) unsigned_long:1 lltx read_mostly HARD_TX_LOCK,HARD_TX_TRYLOCK,HARD_TX_UNLOCK(tx) -unsigned long:1 netmem_tx:1; read_mostly +unsigned long:2 netmem_tx:2; read_mostly char name[16] struct netdev_name_node* name_node struct dev_ifalias* ifalias diff --git a/Documentation/networking/netmem.rst b/Documentation/networking/netmem.rst index b63aded46337..217869d1108d 100644 --- a/Documentation/networking/netmem.rst +++ b/Documentation/networking/netmem.rst @@ -95,4 +95,10 @@ Driver TX Requirements netdev@, or reach out to the maintainers and/or almasrymina@google.com for help adding the netmem API. -2. Driver should declare support by setting `netdev->netmem_tx = true` +2. Driver should declare support by setting `netdev->netmem_tx` to the + appropriate mode: + + - `NETMEM_TX_DMA`: for physical devices that perform DMA. + + - `NETMEM_TX_NO_DMA`: for virtual or passthrough devices that do + not DMA, but still support handling of netmem-backed skbs. diff --git a/Documentation/translations/zh_CN/networking/netmem.rst b/Documentation/translations/zh_CN/networking/netmem.rst index fe351a240f02..320f3eacf51b 100644 --- a/Documentation/translations/zh_CN/networking/netmem.rst +++ b/Documentation/translations/zh_CN/networking/netmem.rst @@ -89,4 +89,9 @@ dma-mapping API 去处理。 使用某个还不存在的 netmem API，你可以自行添加并提交到 netdev@，也可以联系维护 人员或者发送邮件至 almasrymina@google.com 寻求帮助。 -2. 驱动程序应通过设置 netdev->netmem_tx = true 来表明自身支持 netmem 功能。 +2. 驱动程序应将 `netdev->netmem_tx` 设置为适当的模式： + + - `NETMEM_TX_DMA`：适用于执行 DMA 的物理设备。 + + - `NETMEM_TX_NO_DMA`：适用于不执行 DMA 的虚拟或透传设备，但仍支持 + 处理 netmem 支持的 skb。 diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 0e1e581efc5a..11d68e75eb4f 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1788,6 +1788,12 @@ enum netdev_stat_type { NETDEV_PCPU_STAT_DSTATS, /* struct pcpu_dstats */ }; +enum netmem_tx_mode { + NETMEM_TX_NONE, /* no netmem TX support */ + NETMEM_TX_DMA, /* DMA-capable netmem TX (real HW) */ + NETMEM_TX_NO_DMA, /* no DMA, e.g. passthrough for virtual devs */ +}; + enum netdev_reg_state { NETREG_UNINITIALIZED = 0, NETREG_REGISTERED, /* completed register_netdevice */ @@ -1809,7 +1815,8 @@ enum netdev_reg_state { * @lltx: device supports lockless Tx. Deprecated for real HW * drivers. Mainly used by logical interfaces, such as * bonding and tunnels - * @netmem_tx: device support netmem_tx. + * @netmem_tx: device netmem TX mode (NETMEM_TX_NONE, NETMEM_TX_DMA, + * or NETMEM_TX_NO_DMA). * * @name: This is the first field of the "visible" part of this structure * (i.e. as seen by users in the "Space.c" file). It is the name @@ -2132,7 +2139,7 @@ struct net_device { struct_group(priv_flags_fast, unsigned long priv_flags:32; unsigned long lltx:1; - unsigned long netmem_tx:1; + unsigned long netmem_tx:2; ); const struct net_device_ops *netdev_ops; const struct header_ops *header_ops; -- 2.52.0