From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910A33F9F3B for ; Tue, 28 Apr 2026 10:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777373028; cv=none; b=dzcNet3TZlwS//+hml/avWQpZtsyzXrJMn2OeWDavf9lus6C3U+1NQetdwfCS9hKQJ2q5ruc1kox30aTnkbY/HjtYUBzgl8v4rGVYF3XzpuHdKwYHjBj+LmF8nfOPd7yx0vJHav4mWzmUHZre+oEDSajyUKls7f8VRz0hm2xgqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777373028; c=relaxed/simple; bh=Txo9jXdDRugPyX7qmDybQ2dYpzzLy0YS2OMMBLInikE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SnHlNfVc10way5r92TlpbwLIsVdVrSF4rtrPwdmzFTy8a32/kL6NsRw85idOPfrCQp2nrIsi84H3eT6IujgFvBkdnRRTdOItApXAaQcwU33m+5rzB7BBetuaLoux1685EIygrFLaJdWU5G01P9l71JCM9QAWyTIShpIJPFfWK6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OnXstZmN; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OnXstZmN" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso114526425e9.1 for ; Tue, 28 Apr 2026 03:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777373025; x=1777977825; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hKtRqSF01B3I4gaZJfxuG2QF2TOpMdK++wbIpuZOUFw=; b=OnXstZmN7ww1Q4bhga8AwQWndl6j+ndOBx2NRQaG/ke7OEbOxNum8W/rv6iVgWWpsP q3CqBLQEPXY6iz2D7jDqte1G8jU5tZRYGnO5sYLmLOYq0HhrVh8lUNG2Pa+PTDRUbBj8 yXvz1CKuvbjoMO/5hlzvifIjmBs1huNuA2I2nkMOI0UGUJStbkpc26sEi5r1jR65caUI rKz1BFO0+/M/uhxlM+PjQdZhsnYgbUuAwIfTbMeQZ7QefPDTYw6nsVY264kH03ze1LtD lTRdJn7H0otmTRynmseltG+hfSWaQ6x3nMXcRRDxxFzlXhbdE1cKgLGYcmyphB1lBzLY ZXsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777373025; x=1777977825; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hKtRqSF01B3I4gaZJfxuG2QF2TOpMdK++wbIpuZOUFw=; b=Ki39/3lY4dcvhJNsZ8LpQVP0qtFouKESndFTS0YGWWdetKg2KxJn55zpedmoxaG6Km CIQZFRqQpGzHyJGTAGCd1WkgOf8hPqIMkiBAWfF0iMJFq0OMmNDQegDnAhfVDl0mv9Ja 5vEAIDc1HjUYtSrvCqghEj6wP2i9Ydqdq90iWjjqCEz88/cMOoeb/GVafWHy/g1G19Vv FAqPrA0pPfmfYb8E2NlZM4vehYk5zGqXRaGwHGS3Hm3wz+mthc8Sadi0NFrK1Ggh8t9P mDMbshcLuz7TfZkrfNXBEUG9K2llXrNyYm8pbtluTdDEbab7dPldzxVAKjZaDY84NDvy OJCQ== X-Forwarded-Encrypted: i=1; AFNElJ/OEUX6bSx/zVCSviIMkIy2IZzszROalzsaiPaRc0pE8ZDw9XUMJr356tRZCuvF23cX7R+C46s=@vger.kernel.org X-Gm-Message-State: AOJu0Yy11r2usmuiP4PGnXw+ItC4Je5QCcvzEydk8lfiEdedJ3pi5Ape PQQrbyxhPxA6n3BNv65yoTB+nVeEwWrl2jAopZysorgU2XsBXM3rBBOy X-Gm-Gg: AeBDietHe0DEh25XiitexTb5HX/Gnwa1FrLdipGf96cZ6fatQMWDLGiGkzMhf7rXvVD LzHMDj5fipy3/q/E9ODk5ZBwsCWNZ+CRu/KRHqKu0AvVnjFnnQSNdKu78wrA9Bexqf4rFB+HeeN FsC4g9djtNV0NhrjQ9l89ZX37sU/FVI0+Y41y/5C0yKz4OdTfDKqF7jWLPtrLlQiYXUvT1n0otN qlYHQry59BrobgpD96FGLe+zqn2/4Z7um4BJL8cuibxELB7ODrql/7Aqzr4wuxAaKaG4G0RTQAg 4U/p8MmQQl64/d/kgQaP5oMlW4VYnuOEzRwl4rO29oFImc97zfPdrDa34R5I+8Km2rbkvQ2HxOB Iwqgv8PS7deV02//z3LlN0XZ2PfEIAXgt5hYSn/azOLqqy1WzsXJBU9upkXKvZ5W/KdDAbi+Xfe Ocb0zGgrNYgh5hRKiWItkfG0FLP2tEhUZQHPT5jkTwGlVFFNwavZXxy3cgCmr/G8+RdaP20sp63 1o= X-Received: by 2002:a05:600c:a08b:b0:48a:53cb:8604 with SMTP id 5b1f17b1804b1-48a78a536acmr28625155e9.14.1777373024680; Tue, 28 Apr 2026 03:43:44 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a77af28e6sm41696855e9.6.2026.04.28.03.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 03:43:44 -0700 (PDT) Date: Tue, 28 Apr 2026 11:43:42 +0100 From: David Laight To: Andy Shevchenko Cc: Yury Norov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED() Message-ID: <20260428114342.0d674fd8@pumpkin> In-Reply-To: References: <20260427214127.406067-1-ynorov@nvidia.com> <20260427214127.406067-8-ynorov@nvidia.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 28 Apr 2026 10:10:22 +0300 Andy Shevchenko wrote: > On Mon, Apr 27, 2026 at 05:41:24PM -0400, Yury Norov wrote: > > Switch from sign_extend32(FIELD_GET()) to the dedicated > > FIELD_GET_SIGNED() and don't calculate the fields length explicitly. > > ... > > > for (i = 0; i < ADDC_T_AVG; i++) { > > tmp = rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD); > > - dc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11); > > - dc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11); > > + dc_re += FIELD_GET_SIGNED(0xfff000, tmp); > > + dc_im += FIELD_GET_SIGNED(0xfff, tmp); > > In the same driver the GENMASK() is being used, why not doing it here while at it? To me those bit masks look more readable than the GENMASK() calls would be. David > > > } > > ... > > > for (i = 0; i < ADDC_T_AVG; i++) { > > tmp = rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD); > > - dc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11); > > - dc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11); > > + dc_re += FIELD_GET_SIGNED(0xfff000, tmp); > > + dc_im += FIELD_GET_SIGNED(0xfff, tmp); > > } > > Ditto, and it even looks like the same piece repeating twice in different > compilation units of the same driver... >