From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Camelia Groza <camelia.groza@nxp.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
thomas.petazzoni@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next] net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising
Date: Tue, 28 Apr 2026 14:58:27 +0200 [thread overview]
Message-ID: <20260428125827.238469-1-maxime.chevallier@bootlin.com> (raw)
When configuring the link parameters in forced mode for the AQR-105, the
Extended Next Page bit gets advertised for Multi-Gigabit modes.
This is done through bit 12 of MDIO_AN_ADVERTISE in MDIO_MMD_AN. This
contains a copy of the MII_ADVERTISE, for which 802.3 defines bit 12 as
the Extended Next Page advertising. This bit used to be marked as
reserved, but a proper define for it was added in :
commit e7a62edd34b1 ("net: phy: qcom: at803x: Use the correct bit to disable extended next page")
Let's use it instead of the ADVERTISE_RESV definition, making the code
more self-documenting.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
drivers/net/phy/aquantia/aquantia_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
index 41f3676c7f1e..e95d391a6dc2 100644
--- a/drivers/net/phy/aquantia/aquantia_main.c
+++ b/drivers/net/phy/aquantia/aquantia_main.c
@@ -385,15 +385,15 @@ static int aqr105_setup_forced(struct phy_device *phydev)
vend |= MDIO_AN_VEND_PROV_1000BASET_HALF;
break;
case SPEED_2500:
- adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV);
+ adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP);
vend |= MDIO_AN_VEND_PROV_2500BASET_FULL;
break;
case SPEED_5000:
- adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV);
+ adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP);
vend |= MDIO_AN_VEND_PROV_5000BASET_FULL;
break;
case SPEED_10000:
- adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV);
+ adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP);
ctrl10 |= MDIO_AN_10GBT_CTRL_ADV10G;
break;
default:
--
2.49.0
next reply other threads:[~2026-04-28 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 12:58 Maxime Chevallier [this message]
2026-04-28 13:38 ` [PATCH net-next] net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising Andrew Lunn
2026-04-30 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428125827.238469-1-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=camelia.groza@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox