From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65C533A8730 for ; Wed, 29 Apr 2026 08:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777450942; cv=none; b=GcBWtTczCxCNNlc2XjirJ5kFQwrEuASdHHwvzq7meJ9zxhBXgfFNGSt4UWilwNKEcfHWoPuJVqUCKi/GS0sri7M4t1D0IWjTEIx415mKWWveiFBjYdxtPsWAdRVUtjSpx7yrO8K1Be0Yk6Ui2v1PvhQ+NeePIE04+aQJgrdJhxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777450942; c=relaxed/simple; bh=lN3xppOIzKBtHzIbSQpJBLnW5rsBuOpCUFOM6xxjK7Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oYeF1dJ6gMEE+jBCxp6g9ZqNR2tyktdQcgooXt/WLZMy4/VOfJywedGGnS92k06qTwPxfzkOLiDaveZat1JflmM7dKk//spEaOJbpPI0x3eujpwAbJi5Ma3IPD80pT4cnyE8f4nmKMvcf8Q2Gc1Naqzuj/0rsaRu2e3yRKM7xxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=mDvsOJx4; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="mDvsOJx4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1777450939; bh=3aB+ayvPJBk4tp2t4E9ZpbfPNI5byZJpdzWObelhBUs=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=mDvsOJx4yBbK0wY7Ee6Nvgcbxqm/od/eBh+6vq71M0BrMbYaGil7K7LUkaEWRDyJb njjW2oJXtPg+TfiKElFMN+ORNkRJ2vthGh1Ov7YqABB8XiA1yPm4fWid8dhc9i3vZa mlfAPoUA29k0XHQgjXwCKYq8UFybKuKhWlf72FP0S8/hDuimuSp1oF0ODxKUDyCjaw 1OlH9QKtApnLV6wJuQQ+m/RDCPrmDfXAiW38kYZCrnX7tX7TuzuXJaJNJOpZr2IzNI 4tk/j4rt4P4Ce7JrtGCjAqZywj4VhfGGUM1/R224KFRmAEnbIjoqNDPussRwj7AfRt pV8Wicv/3soWQ== Received: by codeconstruct.com.au (Postfix, from userid 10000) id 6DB0860280; Wed, 29 Apr 2026 16:22:19 +0800 (AWST) From: Jeremy Kerr Date: Wed, 29 Apr 2026 16:21:42 +0800 Subject: [PATCH net 2/2] net: mctp: test: Use dev_direct_xmit for TX to our test device Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260429-dev-mctp-test-fixes-v1-2-1127b7425809@codeconstruct.com.au> References: <20260429-dev-mctp-test-fixes-v1-0-1127b7425809@codeconstruct.com.au> In-Reply-To: <20260429-dev-mctp-test-fixes-v1-0-1127b7425809@codeconstruct.com.au> To: Matt Johnston , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: netdev@vger.kernel.org, kernel test robot X-Mailer: b4 0.16-dev In our test cases, we typically feed a packet sequence into the routing code, then inspect the device's TXed skbs to assert specific behaviours. Using dev_queue_xmit() for our TX path introduces a fair bit of complexity between the test packet sequence and the test device's ndo_start_xmit callback; which may mean that the skbs have not hit the device at the point we're inspecting the TXed skb list. Use dev_direct_xmit instead, as we want a direct a path as possible here, and the test dev does not need any queueing, scheduling or flow control. Fixes: 6ab578739a4c ("net: mctp: test: move TX packetqueue from dst to dev") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202604281320.525eee17-lkp@intel.com Signed-off-by: Jeremy Kerr --- net/mctp/test/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mctp/test/utils.c b/net/mctp/test/utils.c index c3987d5ade7a..6eef8d485c25 100644 --- a/net/mctp/test/utils.c +++ b/net/mctp/test/utils.c @@ -116,7 +116,7 @@ void mctp_test_destroy_dev(struct mctp_test_dev *dev) static int mctp_test_dst_output(struct mctp_dst *dst, struct sk_buff *skb) { skb->dev = dst->dev->dev; - dev_queue_xmit(skb); + dev_direct_xmit(skb, 0); return 0; } -- 2.39.5