RE: [Intel-wired-lan] [PATCH 1/2] ice: allow creating VFs when !CONFIG_ICE_SWITCHDEV

Loktionov, Aleksandr
2026-04-29T09:18:04Z

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Vincent Chen via Intel-wired-lan
> Sent: Wednesday, April 29, 2026 8:51 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>
> Cc: andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; vincent.chen@sifive.com
> Subject: [Intel-wired-lan] [PATCH 1/2] ice: allow creating VFs when
> !CONFIG_ICE_SWITCHDEV
>
> Currently ice_eswitch_attach_vf() is called unconditionally in
> ice_start_vfs(), which causes VF creation to fail when
> CONFIG_ICE_SWITCHDEV is not defined.
>
> Fix this by adding switchdev mode checks at the call sites before
> calling ice_eswitch_attach_vf(), consistent with how
> ice_eswitch_attach_sf() is already handled in ice_devlink_port_new().
> This is similar to commit aacca7a83b97 ("ice: allow creating VFs for
> !CONFIG_NET_SWITCHDEV") which fixed the same issue for the previous
> ice_eswitch_configure() API.
>
> Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
> ---
> drivers/net/ethernet/intel/ice/ice_sriov.c | 14 ++++++++------
> drivers/net/ethernet/intel/ice/ice_vf_lib.c | 3 ++-
> 2 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c
> b/drivers/net/ethernet/intel/ice/ice_sriov.c
> index 843e82fd3bf9..6a0b724e46f9 100644
> --- a/drivers/net/ethernet/intel/ice/ice_sriov.c
> +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c
> @@ -484,12 +484,14 @@ static int ice_start_vfs(struct ice_pf *pf)
> goto teardown;
> }
>
> - retval = ice_eswitch_attach_vf(pf, vf);
> - if (retval) {
> - dev_err(ice_pf_to_dev(pf), "Failed to attach VF
> %d to eswitch, error %d",
> - vf->vf_id, retval);
> - ice_vf_vsi_release(vf);
> - goto teardown;
> + if (ice_is_eswitch_mode_switchdev(pf)) {
> + retval = ice_eswitch_attach_vf(pf, vf);
> + if (retval) {
> + dev_err(ice_pf_to_dev(pf), "Failed to
> attach VF %d to eswitch, error %d",
> + vf->vf_id, retval);
> + ice_vf_vsi_release(vf);
> + goto teardown;
> + }
> }
>
> set_bit(ICE_VF_STATE_INIT, vf->vf_states); diff --git
> a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> index de9e81ccee66..71595410174c 100644
> --- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
> @@ -807,7 +807,8 @@ void ice_reset_all_vfs(struct ice_pf *pf)
> ice_vf_rebuild_vsi(vf);
> ice_vf_post_vsi_rebuild(vf);
>
> - ice_eswitch_attach_vf(pf, vf);
> + if (ice_is_eswitch_mode_switchdev(pf))
> + ice_eswitch_attach_vf(pf, vf);
>
> mutex_unlock(&vf->cfg_lock);
> }
> --
> 2.34.1

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>