Re: [PATCH iwl-net] idpf: fix RSS LUT memcpy size

Simon Horman
2026-04-30T16:58:37Z

On Wed, Apr 29, 2026 at 09:42:30AM +0200, Larysa Zaremba wrote:
> Based on the following feedback from Sashiko (received for iXD phase 1
> patchset, but valid for the net tree):
>
> "Is the bounds check xn_params.recv_mem.iov_len < lut_buf_size sufficient?
> Since lut_buf_size only represents the size of the array elements, should
> this check instead verify that the payload is at least
> sizeof(struct virtchnl2_rss_lut) + lut_buf_size?
>
> [...]
>
> Does memcpy copy the correct amount of data here? rss_lut_size stores the
> number of 32-bit entries, not the size in bytes. Should it use
> lut_buf_size or rss_data->rss_lut_size * sizeof(u32) instead?"
>
> After inspecting the code, it was concluded that RSS memcpy size is in fact
> 4 times smaller than it has to be, since a single array entry in a u32, and
> rss_data->rss_lut_size is clearly used as an array size. Required Rx buffer
> size is also too small, but this is a common issue in the idpf code.
>
> Use a full buffer size (lut_buf_size) instead of the array length
> (rss_data->rss_lut_size) when doing memcpy of RSS lookup table.
> While at it, increase required Rx buffer size to a whole flex-array
> containing structure instead of just the array.
>
> Link: https://sashiko.dev/#/patchset/20260323174052.5355-1-larysa.zaremba%40intel.com?part=8
> Fixes: 95af467d9a4e ("idpf: configure resources for RX queues")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>

Reviewed-by: Simon Horman <horms@kernel.org>

There is an AI generated review of this patch available on sashiko.dev.
It seems to me that the issues raised there do warrant further investigation.
But that they are pre-existing problems that and don't need to
block progress of this patch.