From: Jakub Kicinski <kuba@kernel.org>
To: Neal Cardwell <ncardwell@google.com>, Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] selftests/net: packetdrill: add tcp_syncookies_ip6_9k
Date: Wed, 29 Apr 2026 16:33:38 -0700 [thread overview]
Message-ID: <20260429163338.423c75ee@kernel.org> (raw)
In-Reply-To: <CADVnQyn-U-QgyT-HqeqZVX3FJi-UCgwfGJk2VaBBhjajKoih6g@mail.gmail.com>
On Wed, 29 Apr 2026 16:47:14 -0400 Neal Cardwell wrote:
> > diff --git a/gtests/net/packetdrill/code.c b/gtests/net/packetdrill/code.c
> > index d90bffabcfe6..6d8d20e64d8c 100644
> > --- a/gtests/net/packetdrill/code.c
> > +++ b/gtests/net/packetdrill/code.c
> > @@ -129,6 +129,7 @@ static void write_symbols(struct code_state *code)
> > emit_var(code, "TCPI_OPT_WSCALE", TCPI_OPT_WSCALE);
> > emit_var(code, "TCPI_OPT_ECN", TCPI_OPT_ECN);
> > emit_var(code, "TCPI_OPT_SYN_DATA", TCPI_OPT_SYN_DATA);
> > + emit_var(code, "TCPI_OPT_SACK", TCPI_OPT_SACK);
> > #endif /* linux */
> > }
>
> Sure! Done. I added all the missing bit values in the following commit:
>
> https://github.com/google/packetdrill/commit/faa0dfb54065118625e169d3111ce09c65b20229
>
> This can be picked up with the following, or similar:
>
> git clone https://github.com/google/packetdrill.git
Updated in netdev CI.
next prev parent reply other threads:[~2026-04-29 23:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 8:00 [PATCH net-next] selftests/net: packetdrill: add tcp_syncookies_ip6_9k Eric Dumazet
2026-04-29 14:15 ` Neal Cardwell
2026-04-29 15:39 ` Eric Dumazet
2026-04-29 16:48 ` Jakub Kicinski
2026-04-29 17:09 ` Eric Dumazet
2026-04-29 17:15 ` Eric Dumazet
2026-04-29 20:47 ` Neal Cardwell
2026-04-29 23:33 ` Jakub Kicinski [this message]
2026-04-30 2:09 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429163338.423c75ee@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox