From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF550B672 for ; Thu, 30 Apr 2026 02:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777514405; cv=none; b=mVca7U5ViNczCgNlC2l0I5QCHln0ND+Il+QSVcDi3rDOWE5ThR3JbNhgTLKi0yIp6fyY+y6fQKodrBTW8tiCo1vjoxPgZOr7PaYkVpYoSdxD+Tv5M6uvR9MbRF26rd4YNx8EmvKMHzJzRAoXbKgqLuOUFPzD/J+pMYB0BZaVvoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777514405; c=relaxed/simple; bh=B6FsFeB3KyWWTfncPSh42chuXWXna92iSyPvit3Meuk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iJHV/vAijM7XZv21BC99mlkA1yOxnqDJekX9KJMlUH/U+rdMwFylHn/T3l4fJIrfc3kU2amqVbqa0yUvmqj8kto+smMbsCsHB1FtpRTylf7w5/KQUTnZloNLlkciOfi4m7XC3oJZYEM2EsywU0P0jRFSIWzBMx4K+VG9EkUlCow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AvTO2+mC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AvTO2+mC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34C58C19425; Thu, 30 Apr 2026 02:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777514405; bh=B6FsFeB3KyWWTfncPSh42chuXWXna92iSyPvit3Meuk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AvTO2+mCZgHNeKQnM073vj9syWAhE3ncwhmGNe4DF0av1pucviT/JTNoyrSXY9aAd nv+EdTZ4GOGnwYWUVw2feBhAhczsbLc1wuKkO20NgnbGjDo8CzEObeWDKLbnPRNra4 to1SRhEXBhxOwLCh03ecwH3oofV6lUvCqKj/Xj6Umuvd2Mb2tzMtnSmJqvEd05c7/K m8ht9O1X7cPESi2gJteezHBtJUEUOwU2ePAEAMIfKimrtEqV4hLiUrnn+GG6iUKyFI SPd08+SVK8JLhdxt4nRW3anmVw9Tj28dAaFmZacfvfMPzDGWrNhOCmjgd95GreWhm0 1j9887D0Bnf4Q== Date: Wed, 29 Apr 2026 19:00:04 -0700 From: Jakub Kicinski To: Eric Dumazet Cc: "David S . Miller" , Paolo Abeni , Simon Horman , Jamal Hadi Salim , Jiri Pirko , netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH v2 net-next 3/4] net/sched: switch tc_dump_qdisc() to for_each_netdev_dump() Message-ID: <20260429190004.2bb674d4@kernel.org> In-Reply-To: <20260428170414.250566-4-edumazet@google.com> References: <20260428170414.250566-1-edumazet@google.com> <20260428170414.250566-4-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 28 Apr 2026 17:04:13 +0000 Eric Dumazet wrote: > static int tc_dump_qdisc(struct sk_buff *skb, struct netlink_callback *cb) > { > + struct { > + unsigned long ifindex; > + int q_idx; > + } *ctx = (void *)cb->ctx; > + unsigned long s_ifindex; > + struct net_device *dev; > + int s_q_idx, q_idx; > int err; > > - s_idx = cb->args[0]; > - s_q_idx = q_idx = cb->args[1]; > - > - idx = 0; > ASSERT_RTNL(); > > err = nlmsg_parse_deprecated(nlh, sizeof(struct tcmsg), tca, TCA_MAX, > @@ -1896,42 +1896,40 @@ static int tc_dump_qdisc(struct sk_buff *skb, struct netlink_callback *cb) > if (err < 0) > return err; > > - for_each_netdev(net, dev) { > + s_ifindex = ctx->ifindex; > + s_q_idx = ctx->q_idx; > + > + for_each_netdev_dump(net, dev, ctx->ifindex) { compilers point out that s_ifindex is set but not used since we iterate directly on ctx->ifindex -- pw-bot: cr